From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Tony Lindgren <tony@atomide.com>, Lee Jones <lee.jones@linaro.org>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: Regression in next with "mfd: twl6040: The chip does not support bulk access"
Date: Fri, 23 Sep 2016 13:19:43 +0300 [thread overview]
Message-ID: <8b8a49cd-ca7b-4580-58ba-3e05d933853e@ti.com> (raw)
In-Reply-To: <139a8c7b-8cfe-fa21-634a-4551511f0cea@ti.com>
On 09/23/16 10:20, Peter Ujfalusi wrote:
> On 09/22/16 21:07, Tony Lindgren wrote:
>> Hi,
>>
>> Looks like commit 7a17e47f6403 ("mfd: twl6040: The chip does not
>> support bulk access") breaks at least omap4-duovero.
>
> That's odd. I see no such errors on omap4 PandaBoard-ES nor on omap5 uEVM.
> The IRQ status is one register so even in bulk access it is one read. So the
> use_single_rw should have no effect on the access.
>
> The only time when regmap would try to use bulk access to twl6040 is when we
> execute regcache_sync() on it after resuming the chip and this would fail at
> the first time when it tries to restore more than one consecutive registers.
>
> I just tested things on next-20160915 and I see no errors at all.
Retested on next-20160923 and I see no issue on Panda-ES or omap5-uevm.
My guess is that you receive an interrupt from twl6040 while the chip is
powered down, the regmap is set to cache only. But this has nothing to do with
the bulk or non bulk access... Looking at the commit logs and git blame I see
no recent change in the driver(s) for twl6040 which changed the way it loads
and/or powers up/down.
--
Péter
next prev parent reply other threads:[~2016-09-23 10:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 18:07 Regression in next with "mfd: twl6040: The chip does not support bulk access" Tony Lindgren
2016-09-23 7:20 ` Peter Ujfalusi
2016-09-23 10:19 ` Peter Ujfalusi [this message]
2016-09-23 14:27 ` Tony Lindgren
2016-09-23 14:26 ` Tony Lindgren
2016-09-23 15:24 ` Santosh Shilimkar
2016-09-23 19:05 ` Peter Ujfalusi
2016-09-23 20:46 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b8a49cd-ca7b-4580-58ba-3e05d933853e@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox