From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68DC83D45C3 for ; Mon, 20 Jul 2026 10:34:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543659; cv=none; b=P6zKPKARBSWHyNXAP1AtjJHzBX7gauA0KcKkK8nxacbnwksOUhzcELQhQ8ut+k5PqvKyDsF/Wgn6vZ5M3qCyAC5FPdCN85IMYrKwEanh9peUo4qZD4BD5XglMpMqT38xC1Dlnsvihoq+Wr90D10OL4f3zr0hAJMKtEAXGtXHMNI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784543659; c=relaxed/simple; bh=nfb9wr1IkGcOE/xOB087/ooy5UHg3twujjs8ono0J50=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=JATwh4vsGCxdYS2d263RGItr1lTtdmDAArgkIISLH6bY2P6HRD+usMzHnyIQ8BzfInAPBCiMufrGhay4SWO1O/kBczqzU1/yfyVYLZDGciUx4dLfzIogI90fqgsfWp+wfaAoxuEwlAYLtZ/kkTrEhfmKXwOWhEfJca5LLlR0rXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hwhQA1Ms; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JDYzPe5g; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hwhQA1Ms"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JDYzPe5g" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66K9vUBx2282431 for ; Mon, 20 Jul 2026 10:34:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dHewdeqeVNcntSNtq50xsoiwCnZXmMXQMckL5dStHcY=; b=hwhQA1MsitD5btdd JqsR13zTYhd8UuvDpj3UXwKAUPj0TaA5iOiiU4fX3Dl0h9mYVWFrxWQnM99+iJ4g ANjDaLE4FRRQuJu80TqDoXekVCzaxkVLwtmfcI6PJATKmGrTqGCbOwiZ6OYuFEI8 jOh4DmrE1VTsI8P1lcjSb7gPcsmo/WiWwBtB1y7hkqOgW7fehnlM2UbgKLWXfV/O 0zqdnt3bPWdecuslW7LhPv33ZFqcWXsEp5FqPXPeNcHWCq9XKRAlNqK/qi2+P7In a+NLjlbpaVpOdDkCchhe5vLBtRiXesNklo53o2kwUF+jj/a2DAXWu6+yKeS9pNvl II1jsg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhfvxgneq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 10:34:17 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51a8db414c7so165798901cf.0 for ; Mon, 20 Jul 2026 03:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784543656; x=1785148456; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dHewdeqeVNcntSNtq50xsoiwCnZXmMXQMckL5dStHcY=; b=JDYzPe5gSFLBXpr0jn2UytSwo/xvsKQ7ZbV/6tTuv96WzY1QALl9SvYfYcWUSHJUry LM523S9jKJqQQHurk/iiU+Deb7lwSsPamTYcK0cJt0jrd+Selie8m1oO14gW9fyLAr8L 6XdjzcEJ3FCqb0KimAFBHcvphQhX0RqjWmemVWNOVZ2ijbhYwq5P0FG2QxZ34aWejg/c 22ueaFihn8CaAO6LXAd1TOhtaHr9oafftuLYpFY0mCUjlZcsvX0fTRQRLyidwVGTjpcA RAc8zmeLKR47KeDJbZ/4y8h3QSRPlJZkahAheqKrEsFf/938F7Y0vKew7nQQlOTwymmz 3MiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784543656; x=1785148456; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dHewdeqeVNcntSNtq50xsoiwCnZXmMXQMckL5dStHcY=; b=J2g/Xm957URAClDHOdSEuBT/HUZbNo906GfjeSJyt2FpfqtOVVjSCbcQQopbJwjJ74 HYuxSBdlwn39AG4PjazfvJo8SOLy3lpAsIU8UxUYwtlRJiBBI9ODrBN4fW+JsaKlADUC 3ndftzO+OpqhgFS7d5zE2PgSQfUWtLr5G4bNoSKqhWwYb6dFkbsW40XUeVTAqi7OIswL YHjhNtVFSDbfPiZU/yZqW34/MMejeBnZHRBLYNLHuaK4Np14GCtrrH60jjsja6prwvBV GryAoiN97mEFoNzYxSXHWM7IvZiLrwg2xMDi/04vMW1TZpMMVyKH56CMLpCsUwDaFDbm D3AA== X-Forwarded-Encrypted: i=1; AHgh+RpL8TlulvjSfJAk0RXrhd36EMtlZfLPrkcqWjsm6sJlL3is044lw6nZzIHCOYc47hh1M14rd3nZ4G1f@vger.kernel.org X-Gm-Message-State: AOJu0Yzeqf08ljLsyE/4ch3EG1fsFBBiOzARAAd2P7EIvLoHT7unO6Lq BjDjwRmfxfdZA/hPTMcb6kbXcrsZfRoNGoQ1SpAm1sr5imcz7mLoXOC1Xe7cjU8vUbJuUCx1XN1 BsIZ3Zf7IcNVm2K1J33qZk5dRBMOtNn42wHXItFbbYPbv4cKnuBik/zh6n5ixtC6u X-Gm-Gg: AfdE7cn5Y/ABgV90IQe6jLX77wYUAeiyFDU+dRXWs6dGq+OhBFMg24r4JAJjeRIOWdW RqsvZY+2EbdHzI9OxotXHt/zXmJge6xjE3J2P5IMYVERVn9iEPRPx9QLmvrf2mc7hjQZMBsB+Oq fceDPsHUBl5Bg8qp/M+7QSfrsSzvONKQ1iG9soOTt5ucBLpi8suqBZDoGPEi5xs1viq7YP5wz0Q W/MSE0o1FegRIXhgSAQEp1AyoGSTH5qg6ezBZ9GatHIndyfBiOodNaKErCcdIqhInSkm3xSNNpx ai2AwEvmxmLTiHpeujZ5CZIfdj2gSoxNcuP2eGPLwyczorLVW4T2xdgNJ4x1vbqGs1r+Jkes0Cx W3pFnGI1hXiaTGx1PjGUA4I4skBdTvDPctID06rjMDen5lQzP2v8vsLuvA2QDW+N+1lGf5wx08Y ZE/OdVhRGSpgXd+02qy8YjL8BkXE/pk/3rWey7Ck80wO+a1rx6We25FUaobQ2Y4rgbzlw= X-Received: by 2002:ac8:5d88:0:b0:519:55c0:a1e5 with SMTP id d75a77b69052e-5213c8e3aa1mr118701061cf.8.1784543655139; Mon, 20 Jul 2026 03:34:15 -0700 (PDT) X-Received: by 2002:ac8:5d88:0:b0:519:55c0:a1e5 with SMTP id d75a77b69052e-5213c8e3aa1mr118700261cf.8.1784543654369; Mon, 20 Jul 2026 03:34:14 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c17009adff3sm439489566b.2.2026.07.20.03.34.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 03:34:13 -0700 (PDT) Message-ID: <8d86ca46-d329-4e65-a7bf-2b79fccddf05@oss.qualcomm.com> Date: Mon, 20 Jul 2026 12:34:10 +0200 Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH 8/8] media: ov2740: remove NULL reg_write callback To: Sakari Ailus , Link Mauve Cc: Srinivas Kandagatla , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Tianshu Qiu , Bingbu Cao , Mauro Carvalho Chehab , Aaro Koskinen , Andreas Kemnade , Roger Quadros , Tony Lindgren , Lee Jones , Arnd Bergmann , Greg Kroah-Hartman , Bartosz Golaszewski , "Vaibhaav Ram T.L" , Kumaravel Thiagarajan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vladimir Zapolskiy , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Praveen Teja Kundanala , Kalyani Akula , Michal Simek , Alexandre Belloni , Joshua Kinard , Antoniu Miclaus , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?UTF-8?Q?Onur_=C3=96zkan?= , Daniel Lezcano , Johan Hovold , Ronald Claveau , Salah Triki , Yury Norov , David Carlier , Achim Gratz , Alexander Sverdlin , Patrick Wicki , Markus Heidelberg , Markus Perkins , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Bjorn Helgaas , Abd-Alrhman Masalkhi , Chen Ni , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, mfd@lists.linux.dev, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, linux-sunxi@lists.linux.dev, rust-for-linux@vger.kernel.org References: <20260715175229.24672-1-linkmauve@linkmauve.fr> <20260715175229.24672-9-linkmauve@linkmauve.fr> Content-Language: en-US, nl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=HKLz0Itv c=1 sm=1 tr=0 ts=6a5df9a9 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=2y0c4oOAfBMx015UTLoA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDExNyBTYWx0ZWRfX/JsmZXR1KnBp a3ojZ7xhSX9y6UiQIlUCBOKKmL2osndT7PcenXH9frIFbO8/4UU3Y0VORrmW+hT6EVhBHGaJaKK SJ+Ugh305q+SSOpYTJ0BJJaYaYatiYk= X-Proofpoint-GUID: DxHNCfxgX_nzu2Yy3yAXGZX2_EwntQXG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDExNyBTYWx0ZWRfX/3Huem/+Hk0b T+h8TouPw2qg9WcRLsy2ME0LBTxNZ0GvC1ZIJU/lx6IdxD5D4De1UeIbNcQcQH1xzxKKzI7ZM1m K8GAwQ3zyOQ/XSiQgUJ3Zqrf79gKQ1GQzfwuDztcVcjtT8/SA8AjzyT6oa8R/MNtpEcnSQMeB/M xIItlXE+vHttq2lOZfARwv7+FTm96Nq7uQU3d5tHohHjaYYFXNHsw8mhuAOc66eLr93p5alP8xO DgGOVB7RInQK1S9QGxA9g9BQNLgbvInOfwnnGfDE4dqqvFZ0chRTHqkFGAwU+4Q3Rd/5Flc2kkh vJUo8gn+sto296JUkVZ0HpQBWg2VUCAK8kGxWAf9zIRzvp4JxYAZWzX2UGd1MnizYX6QTvKo7pc 6j/G3WPPl6ys0tjVVSv3T5BvKRmOAH6MfOywZ3lAsgwsQvp8It2ri8EolJQT4KixdKqiIBxm4dD 9LL8eDzENdr3JbqHP3Q== X-Proofpoint-ORIG-GUID: DxHNCfxgX_nzu2Yy3yAXGZX2_EwntQXG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_02,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 clxscore=1011 malwarescore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200117 Hi Sakari, On 20-Jul-26 11:39, Sakari Ailus wrote: > Hi, > > On Wed, Jul 15, 2026 at 07:52:24PM +0200, Link Mauve wrote: >> This field is already initialized to NULL, so there is no reason to >> write it again. >> >> This prevents it from appearing while grepping for reg_write in the >> future. >> >> Signed-off-by: Link Mauve > > I believe we need a real name here. We don't need a real name / official name here, just a "known identity", IOW not "anonoymous1234" since Link has clearly is using Link Mauve as their internet identity (given they went through the trouble of registering it as a domain) I believe the S-o-b here is fine as is. See: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330 where the "real name" policy was weakened to "known identity". Regards, Hans > >> --- >> drivers/media/i2c/ov2740.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c >> index fb590dfadda1..799eca4023da 100644 >> --- a/drivers/media/i2c/ov2740.c >> +++ b/drivers/media/i2c/ov2740.c >> @@ -1271,7 +1271,6 @@ static int ov2740_register_nvmem(struct i2c_client *client, >> nvmem_config.compat = true; >> nvmem_config.base_dev = dev; >> nvmem_config.reg_read = ov2740_nvmem_read; >> - nvmem_config.reg_write = NULL; >> nvmem_config.priv = nvm; >> nvmem_config.stride = 1; >> nvmem_config.word_size = 1; > > I think it'd be nicer to do the initialisation in variable declaration -- > all the information is available already there. >