From: Md Danish Anwar <a0501179@ti.com>
To: Simon Horman <horms@kernel.org>, MD Danish Anwar <danishanwar@ti.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Roger Quadros <rogerq@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Andrew Lunn <andrew@lunn.ch>,
Richard Cochran <richardcochran@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>, <nm@ti.com>,
<srk@ti.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] net: ti: icss-iep: Add IEP driver
Date: Fri, 4 Aug 2023 11:57:08 +0530 [thread overview]
Message-ID: <8e0da18c-3856-d9af-3940-85dcc7f698a0@ti.com> (raw)
In-Reply-To: <ZMvE63ooNyoRZK/y@kernel.org>
On 03/08/23 8:46 pm, Simon Horman wrote:
> On Thu, Aug 03, 2023 at 04:31:51PM +0530, MD Danish Anwar wrote:
>> From: Roger Quadros <rogerq@ti.com>
>>
>> Add a driver for Industrial Ethernet Peripheral (IEP) block of PRUSS to
>> support timestamping of ethernet packets and thus support PTP and PPS
>> for PRU ethernet ports.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>
> ...
>
>> +static int icss_iep_pps_enable(struct icss_iep *iep, int on)
>> +{
>> + int ret = 0;
>> + struct timespec64 ts;
>> + struct ptp_clock_request rq;
>> + unsigned long flags;
>> + u64 ns;
>
> For networking code, please arrange local variables in reverse xmas tree
> order - longest line to shortest.
>
> https://github.com/ecree-solarflare/xmastree is your friend here.
>
> ...
Sure Simon, I will take care of this in next revision.
--
Thanks and Regards,
Danish.
next prev parent reply other threads:[~2023-08-04 6:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 11:01 [PATCH 0/4] Introduce IEP driver and packet timestamping support MD Danish Anwar
2023-08-03 11:01 ` [PATCH 1/4] dt-bindings: net: Add ICSS IEP MD Danish Anwar
2023-08-03 15:27 ` Conor Dooley
2023-08-04 6:26 ` Md Danish Anwar
2023-08-04 15:35 ` Conor Dooley
2023-08-07 4:38 ` [EXTERNAL] " Md Danish Anwar
2023-08-03 11:01 ` [PATCH 2/4] net: ti: icss-iep: Add IEP driver MD Danish Anwar
2023-08-03 15:16 ` Simon Horman
2023-08-04 6:27 ` Md Danish Anwar [this message]
2023-08-03 11:01 ` [PATCH 3/4] net: ti: icssg-prueth: add packet timestamping and ptp support MD Danish Anwar
2023-08-03 11:01 ` [PATCH 4/4] net: ti: icssg-prueth: am65x SR2.0 add 10M full duplex support MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e0da18c-3856-d9af-3940-85dcc7f698a0@ti.com \
--to=a0501179@ti.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox