diff for duplicates of <8f4a47f8-18dc-cb73-10db-033e5e5adb25@ti.com> diff --git a/a/1.txt b/N1/1.txt index 15188f5..bc9c33d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1 +1,62 @@ -<<< No Message Collected >>> +Hi Rob, + +On 1/25/21 6:04 PM, Rob Herring wrote: +> On Fri, Jan 15, 2021 at 02:58:19PM -0600, Suman Anna wrote: +>> The '#address-cells' property looks to be a required property for +>> interrupt controller nodes as indicated by a warning message seen +>> when building dtbs with W=2. Adding the property to the PRUSS INTC +>> dts nodes though fails the dtbs_check. Add this property to the +>> PRUSS INTC binding to make it compliant with both dtbs_check and +>> building dtbs. +>> +>> Signed-off-by: Suman Anna <s-anna@ti.com> +>> --- +>> Hi Rob, +>> +>> This patch is also part of our effort to get rid of the warnings seen +>> around interrupt providers on TI K3 dtbs [1]. I needed this in the PRUSS +>> INTC bindings to not get a warning with dtbs_check while also ensuring +>> no warnings while building dtbs with W=2. +>> +>> I would have expected the '#address-cells' requirement to be inherited +>> automatically. And looking through the schema files, I actually do not +>> see the interrupt-controller.yaml included automatically anywhere. You +>> had asked us to drop the inclusion in this binding in our first version +>> with YAML [3]. Am I missing something, and how do we ensure that this +>> is enforced automatically for everyone? +> +> interrupt-controller.yaml is applied to any node named +> 'interrupt-controller'. More generally, if 'compatible' is not present, +> then we look at $nodename for the default 'select'. In your case, you +> didn't name the node appropriately. + +Thanks for the clarification. Yeah, I didn't add anything specifically, since +the expectation is interrupt-controller. Should I be adding that to this binding? + +> +> We can't check this in interrupt-controller.yaml because #address-cells +> is not always 0. GICv3 is one notable exception. +> +>> +>> regards +>> Suman +>> +>> [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115083003.27387-1-lokeshvutla@ti.com/ +> +> I've commented on this thread now in regards to #address-cells. + +I suppose I still need this patch to be defined to unblock the ICSSG nodes +getting accepted by our dts maintainer. Care to give your Reviewed-by for the +change? Or I can spin a v2 with $nodename added as well if that's needed too. + +regards +Suman + +> +> Rob +> +>> [2] https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210114194805.8231-1-s-anna@ti.com/ +>> [3] https://patchwork.kernel.org/comment/23484523/ +>> +>> .../bindings/interrupt-controller/ti,pruss-intc.yaml | 6 ++++++ +>> 1 file changed, 6 insertions(+) diff --git a/a/content_digest b/N1/content_digest index 8116c0e..a218151 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -18,6 +18,67 @@ " Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>\0" "\00:1\0" "b\0" - <<< No Message Collected >>> + "Hi Rob,\n" + "\n" + "On 1/25/21 6:04 PM, Rob Herring wrote:\n" + "> On Fri, Jan 15, 2021 at 02:58:19PM -0600, Suman Anna wrote:\n" + ">> The '#address-cells' property looks to be a required property for\n" + ">> interrupt controller nodes as indicated by a warning message seen\n" + ">> when building dtbs with W=2. Adding the property to the PRUSS INTC\n" + ">> dts nodes though fails the dtbs_check. Add this property to the\n" + ">> PRUSS INTC binding to make it compliant with both dtbs_check and\n" + ">> building dtbs.\n" + ">>\n" + ">> Signed-off-by: Suman Anna <s-anna@ti.com>\n" + ">> ---\n" + ">> Hi Rob,\n" + ">>\n" + ">> This patch is also part of our effort to get rid of the warnings seen\n" + ">> around interrupt providers on TI K3 dtbs [1]. I needed this in the PRUSS\n" + ">> INTC bindings to not get a warning with dtbs_check while also ensuring\n" + ">> no warnings while building dtbs with W=2.\n" + ">>\n" + ">> I would have expected the '#address-cells' requirement to be inherited\n" + ">> automatically. And looking through the schema files, I actually do not\n" + ">> see the interrupt-controller.yaml included automatically anywhere. You\n" + ">> had asked us to drop the inclusion in this binding in our first version\n" + ">> with YAML [3]. Am I missing something, and how do we ensure that this\n" + ">> is enforced automatically for everyone?\n" + "> \n" + "> interrupt-controller.yaml is applied to any node named \n" + "> 'interrupt-controller'. More generally, if 'compatible' is not present, \n" + "> then we look at $nodename for the default 'select'. In your case, you \n" + "> didn't name the node appropriately.\n" + "\n" + "Thanks for the clarification. Yeah, I didn't add anything specifically, since\n" + "the expectation is interrupt-controller. Should I be adding that to this binding?\n" + "\n" + "> \n" + "> We can't check this in interrupt-controller.yaml because #address-cells \n" + "> is not always 0. GICv3 is one notable exception.\n" + "> \n" + ">>\n" + ">> regards\n" + ">> Suman\n" + ">>\n" + ">> [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115083003.27387-1-lokeshvutla@ti.com/\n" + "> \n" + "> I've commented on this thread now in regards to #address-cells.\n" + "\n" + "I suppose I still need this patch to be defined to unblock the ICSSG nodes\n" + "getting accepted by our dts maintainer. Care to give your Reviewed-by for the\n" + "change? Or I can spin a v2 with $nodename added as well if that's needed too.\n" + "\n" + "regards\n" + "Suman\n" + "\n" + "> \n" + "> Rob\n" + "> \n" + ">> [2] https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210114194805.8231-1-s-anna@ti.com/\n" + ">> [3] https://patchwork.kernel.org/comment/23484523/\n" + ">>\n" + ">> .../bindings/interrupt-controller/ti,pruss-intc.yaml | 6 ++++++\n" + >> 1 file changed, 6 insertions(+) -1f8e92354edec47581bd0cc8bf1a89a0e61701e50330ddca087865fa03596a23 +0e5159f128c1fc765b780315b74a7792a7fa0f2887529cad3b24c4a24f92f47e
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox