RE: OMAP DSS Enable clocks in dss_setup_partial_planes

[Ben Tucker <btucker@mpcdata.com>]

> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> Sent: 12 January 2011 09:14
> To: ext Ben Tucker
> Cc: linux-omap@vger.kernel.org
> Subject: Re: OMAP DSS Enable clocks in dss_setup_partial_planes
>
> Hi,
>
> On Tue, 2011-01-11 at 17:41 +0000, ext Ben Tucker wrote:
> > From 086e3454c8f154cd90a4669899f2179f16ef32cd Mon Sep 17 00:00:00
> 2001
> > From: Ben Tucker <btucker@mpc-data.co.uk>
> > Date: Thu, 13 Jan 2011 12:56:45 +0000
> > Subject: [PATCH] OMAP DSS Enable clocks in dss_setup_partial_planes
> >  Enable the interface clocks while calling>
> >  >  configure_dispc().
>
> This description doesn't really tell anything which isn't selfevident
> from the code below. Please check
> http://who-t.blogspot.com/2009/12/on-commit-messages.html
>
> But I presume this is about RFBI. If so, correct place to enable the
> clocks would be in rfbi.c.
>
>  Tomi
>

Apologies for the commit message. Updated patch below.

Are you sure the code to enable clocks should be placed in rfbi.c? The DSI
code (dsi.c) uses dss_setup_partial_planes() in the same way as rfbi.c and
there is no clock enable code there. Also omap_dss_mgr_apply() within
manager.c enables clocks for the configure_dispc() call.

	Ben


>From fac7afefc4f80c3045ce73bb34e24a037ed26edc Mon Sep 17 00:00:00 2001
From: Ben Tucker <btucker@mpc-data.co.uk>
Date: Sat, 15 Jan 2011 07:18:49 +0000
Subject: [PATCH] OMAP2,3: DSS2: Enable clocks in dss_setup_partial_planes

Fix a deadly bus halt when using RFBI or DSI interfaced panels
due to access to the OMAP DSS subsystem while interface and
peripheral clocks are disabled.
Resolved by enabling the clocks while calling the
configure_dispc() in dss_setup_partial_planes().
---
 drivers/video/omap2/dss/manager.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/video/omap2/dss/manager.c
b/drivers/video/omap2/dss/manager.c
index 545e9b9..cb90dac 100644
--- a/drivers/video/omap2/dss/manager.c
+++ b/drivers/video/omap2/dss/manager.c
@@ -1106,7 +1106,9 @@ void dss_setup_partial_planes(struct omap_dss_device
*dssdev,
        mc->w = w;
        mc->h = h;

+       dss_clk_enable(DSS_CLK_ICK | DSS_CLK_FCK1);
        configure_dispc();
+       dss_clk_disable(DSS_CLK_ICK | DSS_CLK_FCK1);

        mc->do_manual_update = false;

--
1.7.3.2