From: Jacob Keller <jacob.e.keller@intel.com>
To: Adam Ford <aford173@gmail.com>, <netdev@vger.kernel.org>
Cc: <aford@beaconembedded.com>, Andrew Lunn <andrew@lunn.ch>,
"Grygorii Strashko" <grygorii.strashko@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] net: ethernet: davinci_emac: Use MAC Address from Device Tree
Date: Mon, 23 Oct 2023 17:14:17 -0700 [thread overview]
Message-ID: <97e1f76a-3505-4783-838a-10b9cacee8bd@intel.com> (raw)
In-Reply-To: <20231022151911.4279-1-aford173@gmail.com>
On 10/22/2023 8:19 AM, Adam Ford wrote:
> Currently there is a device tree entry called "local-mac-address"
> which can be filled by the bootloader or manually set.This is
> useful when the user does not want to use the MAC address
> programmed into the SoC.
>
> Currently, the davinci_emac reads the MAC from the DT, copies
> it from pdata->mac_addr to priv->mac_addr, then blindly overwrites
> it by reading from registers in the SoC, and falls back to a
> random MAC if it's still not valid. This completely ignores any
> MAC address in the device tree.
>
> In order to use the local-mac-address, check to see if the contents
> of priv->mac_addr are valid before falling back to reading from the
> SoC when the MAC address is not valid.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
> V2: Rebase, add R-B tag, and post stand-alone for netdev branch, since
> the device tree patch has already been accepted via the omap tree.
Looks like you didn't add the tag for which tree. Given the context, I
would assume net-next.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2023-10-24 0:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 15:19 [PATCH V2] net: ethernet: davinci_emac: Use MAC Address from Device Tree Adam Ford
2023-10-24 0:14 ` Jacob Keller [this message]
2023-10-24 1:22 ` Adam Ford
2023-10-24 9:24 ` Paolo Abeni
2023-10-24 9:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97e1f76a-3505-4783-838a-10b9cacee8bd@intel.com \
--to=jacob.e.keller@intel.com \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox