From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, khilman@baylibre.com
Subject: Re: [PATCH v5 0/8] drm/omap: Add virtual-planes support
Date: Tue, 12 Oct 2021 13:36:03 +0300 [thread overview]
Message-ID: <99c11b0b-eab8-a7b9-8aab-8cc06be14cd5@ideasonboard.com> (raw)
In-Reply-To: <a4e72823-6e92-cce1-0607-5506ddda42fa@baylibre.com>
On 12/10/2021 11:30, Neil Armstrong wrote:
> On 12/10/2021 09:15, Tomi Valkeinen wrote:
>> On 23/09/2021 10:06, Neil Armstrong wrote:
>>> This patchset is the follow-up the v4 patchset from Benoit Parrot at [1].
>>>
>>> This patch series adds virtual-plane support to omapdrm driver to allow the use
>>> of display wider than 2048 pixels.
>>>
>>> In order to do so we introduce the concept of hw_overlay which can then be
>>> dynamically allocated to a plane. When the requested output width exceed what
>>> be supported by one overlay a second is then allocated if possible to handle
>>> display wider then 2048.
>>>
>>> This series replaces an earlier series which was DT based and using statically
>>> allocated resources.
>>>
>>> This implementation is inspired from the work done in msm/disp/mdp5
>>> driver.
>>>
>>> Changes since v4 at [1]:
>>> - rebased on v5.15-rc2
>>
>> What is this based on? Doesn't apply to v5.15-rc2, and "error: sha1 information is lacking or useless".
>
> Indeed the sha1 info is useless, it's based on v5.15-rc2 on top of "HACK: drm/omap: increase DSS5 max tv pclk to 192MHz"
> in order to validate on 2k monitors.
I'm personally fine with removing the HACK from that, and applying it
too. I used the patch for a long time without any issues. However, I
never found anyone to confirm that 192MHz is fine (or that it's not
fine). Too old HW for finding HW engineers to look at it =).
Tomi
next prev parent reply other threads:[~2021-10-12 10:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 7:06 [PATCH v5 0/8] drm/omap: Add virtual-planes support Neil Armstrong
2021-09-23 7:06 ` [PATCH v5 1/8] drm/omap: Add ability to check if requested plane modes can be supported Neil Armstrong
2021-10-12 7:21 ` Tomi Valkeinen
2021-10-12 8:32 ` Neil Armstrong
2021-09-23 7:06 ` [PATCH v5 2/8] drm/omap: Add ovl checking funcs to dispc_ops Neil Armstrong
2021-09-23 7:06 ` [PATCH v5 3/8] drm/omap: introduce omap_hw_overlay Neil Armstrong
2021-10-12 7:59 ` Tomi Valkeinen
2021-10-12 8:47 ` Neil Armstrong
2021-09-23 7:06 ` [PATCH v5 4/8] drm/omap: omap_plane: subclass drm_plane_state Neil Armstrong
2021-10-12 8:13 ` Tomi Valkeinen
2021-10-12 8:56 ` Neil Armstrong
2021-09-23 7:06 ` [PATCH v5 5/8] drm/omap: Add global state as a private atomic object Neil Armstrong
2021-10-12 10:44 ` Tomi Valkeinen
2021-10-12 13:23 ` Neil Armstrong
2021-10-12 13:38 ` Tomi Valkeinen
2021-10-12 15:41 ` Neil Armstrong
2021-09-23 7:06 ` [PATCH v5 6/8] drm/omap: dynamically assign hw overlays to planes Neil Armstrong
2021-10-12 13:34 ` Tomi Valkeinen
2021-10-12 14:45 ` Neil Armstrong
2021-09-23 7:07 ` [PATCH v5 7/8] drm/omap: add plane_atomic_print_state support Neil Armstrong
2021-09-23 7:07 ` [PATCH v5 8/8] drm/omap: Add a 'right overlay' to plane state Neil Armstrong
2021-10-06 8:17 ` [PATCH v5 0/8] drm/omap: Add virtual-planes support Neil Armstrong
2021-10-06 12:48 ` Tomi Valkeinen
2021-10-12 7:15 ` Tomi Valkeinen
2021-10-12 8:30 ` Neil Armstrong
2021-10-12 10:36 ` Tomi Valkeinen [this message]
2021-10-12 13:27 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99c11b0b-eab8-a7b9-8aab-8cc06be14cd5@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox