From: "Krishnamoorthy, Balaji T" <balajitk@ti.com>
To: Lesly A M <leslyam@ti.com>
Cc: linux-omap@vger.kernel.org, Nishanth Menon <nm@ti.com>,
David Derrick <dderrick@ti.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v8 4/7] omap3: pm: TWL5030 version checking
Date: Thu, 3 Mar 2011 17:30:09 +0530 [thread overview]
Message-ID: <AANLkTik6t7MzHiKzoGv0B5PGug1pt2Oas2C5mtCeLLm3@mail.gmail.com> (raw)
In-Reply-To: <1299072653-13414-5-git-send-email-leslyam@ti.com>
On Wed, Mar 2, 2011 at 7:00 PM, Lesly A M <leslyam@ti.com> wrote:
<snip>
> static struct device *
> add_numbered_child(unsigned chip, const char *name, int num,
> void *pdata, unsigned pdata_len,
> @@ -1056,6 +1114,9 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id)
> /* setup clock framework */
> clocks_init(&client->dev, pdata->clock);
>
> + /* read TWL IDCODE Register */
> + twl_read_idcode_register();
> +
you missed check for TRITON again
BTW can you make twl_read_idcode_register static
if you are not exporting ?
@@ -1109,14 +1109,12 @@
} else {
twl_id = TWL4030_CLASS_ID;
twl_map = &twl4030_map[0];
+ twl_read_idcode_register();
}
/* setup clock framework */
clocks_init(&client->dev, pdata->clock);
- /* read TWL IDCODE Register */
- twl_read_idcode_register();
-
/* load power event scripts */
if (twl_has_power() && pdata->power)
twl4030_power_init(pdata->power);
> /* load power event scripts */
> if (twl_has_power() && pdata->power)
> twl4030_power_init(pdata->power);
> diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h
> index f4bd475..d3cc2ac 100644
> --- a/include/linux/i2c/twl.h
> +++ b/include/linux/i2c/twl.h
> @@ -150,7 +150,12 @@
> #define MMC_PU (0x1 << 3)
> #define MMC_PD (0x1 << 2)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-03 12:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 13:30 [PATCH v8 0/8] omap3: pm: TWL4030 power scripts and workaround for TWL errata 27 Lesly A M
2011-03-02 13:30 ` [PATCH v8 1/7] omap3: pm: Fix for the TRITON sleep/wakeup sequence Lesly A M
2011-03-08 13:14 ` Menon, Nishanth
2011-03-02 13:30 ` [PATCH v8 2/7] omap3: pm: Correct the warning print during script loading Lesly A M
2011-03-08 13:18 ` Menon, Nishanth
2011-03-02 13:30 ` [PATCH v8 3/7] omap3: pm: TWL4030 power scripts for OMAP3 boards Lesly A M
2011-03-07 21:02 ` Kevin Hilman
2011-03-08 6:50 ` Manuel, Lesly Arackal
2011-03-08 16:29 ` Nishanth Menon
2011-03-08 16:03 ` Menon, Nishanth
2011-03-02 13:30 ` [PATCH v8 4/7] omap3: pm: TWL5030 version checking Lesly A M
2011-03-03 12:00 ` Krishnamoorthy, Balaji T [this message]
2011-03-10 4:15 ` Menon, Nishanth
2011-03-02 13:30 ` [PATCH v8 5/7] mfd: TWL4030: changes for TRITON Errata 27 workaround Lesly A M
2011-03-07 21:14 ` Kevin Hilman
2011-03-08 7:14 ` Manuel, Lesly Arackal
2011-03-02 13:30 ` [PATCH v8 6/7] omap3430: Updating the board file to use TWL4030 scripts Lesly A M
2011-03-07 19:42 ` Kevin Hilman
2011-03-07 21:10 ` Kevin Hilman
2011-03-08 7:06 ` Manuel, Lesly Arackal
2011-03-08 7:01 ` Manuel, Lesly Arackal
2011-03-02 13:30 ` [PATCH v8 7/7] omap3630: " Lesly A M
2011-03-07 21:25 ` [PATCH v8 0/8] omap3: pm: TWL4030 power scripts and workaround for TWL errata 27 Kevin Hilman
2011-03-08 7:30 ` Manuel, Lesly Arackal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTik6t7MzHiKzoGv0B5PGug1pt2Oas2C5mtCeLLm3@mail.gmail.com \
--to=balajitk@ti.com \
--cc=dderrick@ti.com \
--cc=leslyam@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).