From: Cory Maccarrone <darkstar6262@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] [omap1] Bluetooth device code common to HTC smartphones
Date: Sun, 8 Aug 2010 10:28:53 -0700 [thread overview]
Message-ID: <AANLkTikGA9-TCM7v+_yivBYtxiX3ByJ7_ub1FOP0LgBO@mail.gmail.com> (raw)
In-Reply-To: <20100804101507.GG9881@atomide.com>
On Wed, Aug 4, 2010 at 3:15 AM, Tony Lindgren <tony@atomide.com> wrote:
> * Cory Maccarrone <darkstar6262@gmail.com> [100802 18:23]:
>> This change adds in a bluetooth controld driver/rfkill
>> interface to the serial bluetooth controller found on many
>> HTC smartphones such as the HTC Herald and HTC Wizard.
>
> To me it looks like most of this should be in drivers/bluetooth/omap7xx.c
> or something like that. Then you can just pass it the gpio numbers in
> the platform_data.
>
Not sure I agree that it fits there. The driver isn't really a
bluetooth driver -- it's really just an RFKILL interface, and some
code to toggle UART clocks on and off, plus GPIO work on a
board-specific level. In principle, the gpios could be set and the
clocks enabled in the board files, and this driver wouldn't be
necessary to get working bluetooth (as we'd use hciattach on
/dev/ttyS*). But then, we can't toggle it off for power saving.
Maybe a better place would be plat-omap/? But it really is more
specific to these HTC boards, not the architecture itself.
So really, the only point of this driver is to be able to power on and
off the external bluetooth chip, which is why I submitted it as helper
code to the board files.
- Cory
next prev parent reply other threads:[~2010-08-08 17:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 15:29 [PATCH 0/5] HTC Herald various device support Cory Maccarrone
2010-08-02 15:29 ` [PATCH 1/5] [OMAP] HTCHERALD: MMC, I2C, HTCPLD and related devices Cory Maccarrone
2010-08-04 10:10 ` Tony Lindgren
2010-08-08 17:39 ` [PATCH 1/5 v2] " Cory Maccarrone
2010-08-02 15:29 ` [PATCH 2/5] [OMAP] htcherald: SPI register config, TSC2046 touchscreen Cory Maccarrone
2010-08-04 10:12 ` Tony Lindgren
2010-08-02 15:29 ` [PATCH 3/5] [omap1] omap7xx clocks, mux, serial fixes Cory Maccarrone
2010-08-04 10:13 ` Tony Lindgren
2010-08-02 15:29 ` [PATCH 4/5] [omap1] Bluetooth device code common to HTC smartphones Cory Maccarrone
2010-08-04 10:15 ` Tony Lindgren
2010-08-08 17:28 ` Cory Maccarrone [this message]
2010-08-09 7:43 ` Tony Lindgren
2010-08-09 17:28 ` Cory Maccarrone
2010-08-10 6:36 ` Tony Lindgren
2010-08-02 15:29 ` [PATCH 5/5] [htcherald] Add board support for UARTs, bluetooth Cory Maccarrone
2010-08-04 10:16 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2010-08-02 15:23 [PATCH 0/5] HTC Herald various device support Cory Maccarrone
2010-08-02 15:23 ` [PATCH 4/5] [omap1] Bluetooth device code common to HTC smartphones Cory Maccarrone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikGA9-TCM7v+_yivBYtxiX3ByJ7_ub1FOP0LgBO@mail.gmail.com \
--to=darkstar6262@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).