From: Grazvydas Ignotas <notasas@gmail.com>
To: felipe.balbi@nokia.com
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
David Brownell <david-b@pacbell.net>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 3/5] arm: omap: switch over to gpio_set_debounce
Date: Sun, 20 Jun 2010 20:03:45 +0300 [thread overview]
Message-ID: <AANLkTikf8S0ixtDTXftuhhCIM1cbRJlgYoU27drvUwUH@mail.gmail.com> (raw)
In-Reply-To: <20100617044502.GB4237@nokia.com>
On Thu, Jun 17, 2010 at 7:45 AM, Felipe Balbi <felipe.balbi@nokia.com> wrote:
> Hi,
>
> On Wed, Jun 16, 2010 at 07:26:30PM +0200, ext Grazvydas Ignotas wrote:
>> So how is this supposed to be used here, should I request all GPIOs I
>> want to have debouncing on, setup debounce time and release them for
>> gpio-keys to take? Or should I wait for this to get supported in
>> gpio-keys?
>
> to me it looks like the *_keys_gpio_init() function should be passed down to
> gpio-keys as a ->setup() callback and you should probably also pass a
> ->teardown() which would clear debounce time when you remove the driver.
> Then only call those functions after gpio has been requested.
gpio-keys platform data already has 'debounce_interval' member, which
is used to setup timer (if nonzero) in the driver. So I maybe it would
be better to modify gpio-keys to try to set debounce, and if that
fails make it fall back to it's current timer-based debounce
functionality?
next prev parent reply other threads:[~2010-06-20 17:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 10:02 [PATCH 0/6] teach gpiolib about gpio debouncing felipe.balbi
2010-05-17 10:02 ` [PATCH 1/5] gpiolib: introduce set_debounce method felipe.balbi
2010-05-20 18:06 ` Andrew Morton
2010-05-20 18:52 ` Felipe Balbi
2010-05-20 19:04 ` Alan Cox
2010-05-20 19:16 ` Andrew Morton
2010-05-20 20:51 ` Alan Cox
2010-05-20 19:45 ` Mark Brown
2010-05-20 22:50 ` David Brownell
2010-05-21 6:49 ` Felipe Balbi
2010-05-21 10:11 ` Alan Cox
2010-05-21 13:14 ` David Brownell
2010-05-21 13:34 ` Alan Cox
2010-05-21 13:23 ` David Brownell
2010-05-21 10:05 ` Alan Cox
2010-05-17 10:02 ` [PATCH 2/5] arm: omap: gpio: implement " felipe.balbi
2010-05-17 10:02 ` [PATCH 3/5] arm: omap: switch over to gpio_set_debounce felipe.balbi
2010-06-16 17:26 ` Grazvydas Ignotas
2010-06-17 4:45 ` Felipe Balbi
2010-06-20 17:03 ` Grazvydas Ignotas [this message]
2010-06-20 21:12 ` Felipe Balbi
2010-05-17 10:02 ` [PATCH 4/5] arm: omap: remove the unused omap_gpio_set_debounce methods felipe.balbi
2010-05-17 10:02 ` [PATCH 5/5] arm: omap: move all gpio defines to plat/gpio.h felipe.balbi
2010-05-17 10:08 ` Felipe Balbi
2010-05-20 18:04 ` [PATCH 0/6] teach gpiolib about gpio debouncing Andrew Morton
2010-05-20 18:55 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikf8S0ixtDTXftuhhCIM1cbRJlgYoU27drvUwUH@mail.gmail.com \
--to=notasas@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).