From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= Subject: Re: [PATCH 0/8] Suspend block api (version 8) Date: Wed, 26 May 2010 03:06:20 -0700 Message-ID: References: <1274482015-30899-1-git-send-email-arve@android.com> <201005242049.18920.rjw@sisk.pl> <87wrusvrqe.fsf@deeprootsystems.com> <201005250138.16293.rjw@sisk.pl> <1274863655.5882.4875.camel@twins> <1274867106.5882.5090.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1274867106.5882.5090.camel@twins> Sender: linux-kernel-owner@vger.kernel.org To: Peter Zijlstra Cc: "Rafael J. Wysocki" , Kevin Hilman , felipe.balbi@nokia.com, Linux PM , LKML , Linux OMAP Mailing List , Tony Lindgren , Paul Walmsley List-Id: linux-omap@vger.kernel.org 2010/5/26 Peter Zijlstra : > On Wed, 2010-05-26 at 02:41 -0700, Arve Hj=F8nnev=E5g wrote: >> On Wed, May 26, 2010 at 1:47 AM, Peter Zijlstra wrote: >> > On Tue, 2010-05-25 at 01:38 +0200, Rafael J. Wysocki wrote: >> >> > This of course will lead to a scattering of suspend blockers in= to any >> >> > drivers/subsystems considered "useful", which by looking throug= h current >> >> > Android kernels is many of them. >> >> >> >> That depends on the maintainers of these subsystems, who still ha= ve the power >> >> to reject requested changes. >> > >> > So as a scheduler maintainer I'm going to merge a patch that does = a >> > suspend_blocker when the runqueue's aren't empty... how about that= ? >> > >> >> I don't know if you are serious, since the all the runqueues are nev= er >> empty while suspending, this would disable opportunistic suspend >> altogether. > > So why again was this such a great scheme? Go fix your userspace to n= ot > not run when not needed. > I was not talking about our user-space code. Suspend has to be called by a running thread, so at least one runqueue is not empty. --=20 Arve Hj=F8nnev=E5g