From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Contreras Subject: Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues Date: Tue, 18 May 2010 14:43:25 +0300 Message-ID: References: <1272746671-13423-1-git-send-email-ohad@wizery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from fg-out-1718.google.com ([72.14.220.152]:27685 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895Ab0ERLnc (ORCPT ); Tue, 18 May 2010 07:43:32 -0400 Received: by fg-out-1718.google.com with SMTP id 22so1028598fge.1 for ; Tue, 18 May 2010 04:43:26 -0700 (PDT) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Ohad Ben-Cohen Cc: linux-omap@vger.kernel.org, Kanigeri Hari , Omar Ramirez Luna , Guzman Lugo Fernando , Menon Nishanth , Hiroshi Doyu On Tue, May 18, 2010 at 2:14 PM, Ohad Ben-Cohen wrote: >>> Unfortunately I don't have a setup right now to test this, but the code >>> seems to be ok for our needs, don't you think ? >> >> But yeah, actually that fits our needs; calling the dma_map only, >> while still wrong, will give us the same behavior we have right now >> (v2.6.33). > > Great, so are you ok with this patchset proposal ? I thought you were going to add separate ioctls, one for dma_map, and another for dma_unmap that receive direction as an argument. Then, map the current PROC_FLUSH/INVALIDATE to those without changing their semantics, but marking them as deprecated. > I'll just add support for the VM_IO path you mentioned. Cool. I actually tried your patches to render to the framebuffer, and everything seemed to work fine. I didn't check for error codes or anything, so I'm not sure what's going on. -- Felipe Contreras