From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Contreras Subject: Re: [RFC/PATCH 0/6] DSPBRIDGE: fix mem+cache API issues Date: Sat, 15 May 2010 11:26:57 +0300 Message-ID: References: <1272746671-13423-1-git-send-email-ohad@wizery.com> <4BEDA964.9070704@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:58403 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752624Ab0EOI06 (ORCPT ); Sat, 15 May 2010 04:26:58 -0400 Received: by fxm6 with SMTP id 6so2204509fxm.19 for ; Sat, 15 May 2010 01:26:57 -0700 (PDT) In-Reply-To: <4BEDA964.9070704@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Omar Ramirez Luna Cc: Ohad Ben-Cohen , "linux-omap@vger.kernel.org" , "Kanigeri, Hari" , "Guzman Lugo, Fernando" , "Menon, Nishanth" , Hiroshi Doyu On Fri, May 14, 2010 at 10:49 PM, Omar Ramirez Luna wrote: > On 5/14/2010 2:27 PM, Felipe Contreras wrote: > [...] >> >> So, I tried your patches, and a simple test app worked fine without >> modification, but a real video decoding hanged the device >> completely... some spinlock was stuck. I don't know if it's because of >> your patches, or because of the state of the bridge at that point. >> I'll try first to rebase to the latest to have a better idea of what's >> happening. > > You may want to check if you have this patch "DSPBRIDGE: Fix declaration and > initialization of sync objects"[1] I used what Ohad suggested: 13e2573. So no, that patch is not there. > This is the one I know fixes a spinlock issue and which description is not > clear enough to state that. > > File fixed was: drivers/dsp/bridge/wmd/msg_sm.c > > [1]http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=b3900e6df1f4e16b59d506a299cd5084c67a6ede I tried to cherry-pick that commit... didn't help: BUG: spinlock lockup on CPU#0, gst-launch-0.10/534, c6404304 Backtrace: [] (dump_backtrace+0x0/0xf8) from [] (dump_stack+0x18/0x1c) r6:00000000 r5:c644a000 r4:c6404304 r3:00000000 [] (dump_stack+0x0/0x1c) from [] (__spin_lock_debug+0xbc/0xd0) [] (__spin_lock_debug+0x0/0xd0) from [] (do_raw_spin_lock+0x84/0xb4) r8:c644be54 r7:00000064 r6:c005f178 r5:80000013 r4:c6404304 [] (do_raw_spin_lock+0x0/0xb4) from [] (_raw_spin_lock_irqsave+0x5c/0x68) r4:c6404304 r3:c7865a00 [] (_raw_spin_lock_irqsave+0x0/0x68) from [] (completion_done+0x1c/0x38) r6:00000001 r5:c6404304 r4:c6404300 [] (completion_done+0x0/0x38) from [] (sync_wait_on_multiple_events+0x58/0x14c [bridgedriver]) r5:00000002 r4:c644be4c [] (sync_wait_on_multiple_events+0x0/0x14c [bridgedriver]) from [] (bridge_msg_get+0x154/0x240 [bridgedriver]) [] (bridge_msg_get+0x0/0x240 [bridgedriver]) from [] (node_get_message+0x94/0x128 [bridgedriver]) [] (node_get_message+0x0/0x128 [bridgedriver]) from [] (nodewrap_get_message+0x28/0x8c [bridgedriver]) r7:c004db48 r6:bf02e7d6 r5:c644bebc r4:c644bf04 [] (nodewrap_get_message+0x0/0x8c [bridgedriver]) from [] (wcd_call_dev_io_ctl+0xf8/0x120 [bridgedriver]) r5:00000040 r4:c644bf1c [] (wcd_call_dev_io_ctl+0x0/0x120 [bridgedriver]) from [] (bridge_ioctl+0xac/0xcc [bridgedriver]) r6:421e7d64 r5:c004db48 r4:c6419f00 r3:c65bb500 [] (bridge_ioctl+0x0/0xcc [bridgedriver]) from [] (vfs_ioctl+0x34/0xb4) r6:421e7d64 r5:bf029fac r4:c6419f00 [] (vfs_ioctl+0x0/0xb4) from [] (do_vfs_ioctl+0x1c4/0x1e0) r7:00000005 r6:c004db48 r5:421e7d64 r4:421e7d64 [] (do_vfs_ioctl+0x0/0x1e0) from [] (sys_ioctl+0x40/0x64) r4:c6419f00 [] (sys_ioctl+0x0/0x64) from [] (ret_fast_syscall+0x0/0x38) r7:00000036 r6:0006ef10 r5:4055d860 r4:0006a000 I'll try to rebase the patches to the latest head. Cheer.s -- Felipe Contreras