From: Felipe Contreras <felipe.contreras@gmail.com>
To: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: fernando.lugo@ti.com, ohad@wizery.com, deepak.chitriki@ti.com,
omar.ramirez@ti.com, h-kanigeri2@ti.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo
Date: Tue, 8 Jun 2010 12:43:28 +0300 [thread overview]
Message-ID: <AANLkTilasmQgcyckgBgpJspRHhsshDlVtdleItZiMp8M@mail.gmail.com> (raw)
In-Reply-To: <20100608.064632.104051482.Hiroshi.DOYU@nokia.com>
On Tue, Jun 8, 2010 at 6:46 AM, Hiroshi DOYU <Hiroshi.DOYU@nokia.com> wrote:
> From: "ext Guzman Lugo, Fernando" <fernando.lugo@ti.com>
>> I think the best thing to do here is remove the spinlock, if not,
>> you are preventing that omap_mbox_msg_send be executed from a
>> tasklet or isr context. That maybe in this moment it is not called
>> but it could be needed in the future. The caller of
>> omap_mbox_msg_send should be take care of that function can not be
>> call simultaneously.
>
> What about adding another function, omap_mbox_msg_send_sync()?
That's exactly what I was thinking about when I heard the problem.
Would this function send all the msgs already queued, and then wait
for the current one actually be sent?
--
Felipe Contreras
next prev parent reply other threads:[~2010-06-08 9:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 15:33 [PATCH v3 0/4] omap: mailbox: cleanup & simplify Ohad Ben-Cohen
2010-05-05 15:33 ` [PATCH v3 1/4] omap: mailbox: convert rwlocks to spinlock Ohad Ben-Cohen
2010-05-05 15:33 ` [PATCH v3 2/4] omap: mailbox cleanup: split MODULE_AUTHOR line Ohad Ben-Cohen
2010-05-05 15:33 ` [PATCH v3 3/4] omap: mailbox: remove (un)likely macros from cold paths Ohad Ben-Cohen
2010-05-05 15:33 ` [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Ohad Ben-Cohen
2010-06-07 18:52 ` Deepak Chitriki
2010-06-07 21:40 ` Ohad Ben-Cohen
2010-06-07 23:14 ` Guzman Lugo, Fernando
2010-06-08 2:54 ` Ohad Ben-Cohen
2010-06-09 5:07 ` Hiroshi DOYU
2010-06-09 5:16 ` Guzman Lugo, Fernando
2010-06-13 23:52 ` Ohad Ben-Cohen
2010-06-14 8:58 ` Hiroshi DOYU
2010-06-14 15:56 ` C.A, Subramaniam
2010-06-15 4:48 ` Ohad Ben-Cohen
2010-06-15 7:04 ` Hiroshi DOYU
2010-06-14 17:44 ` Sapiens, Rene
2010-06-14 17:47 ` Felipe Contreras
2010-06-15 4:43 ` Ohad Ben-Cohen
2010-06-15 8:04 ` Hiroshi DOYU
2010-06-16 5:09 ` Ohad Ben-Cohen
2010-06-16 5:50 ` Hiroshi DOYU
2010-06-23 0:29 ` Ohad Ben-Cohen
2010-07-02 12:08 ` Hiroshi DOYU
2010-06-08 3:46 ` Hiroshi DOYU
2010-06-08 9:43 ` Felipe Contreras [this message]
2010-06-08 9:55 ` Hiroshi DOYU
2010-06-08 18:49 ` Guzman Lugo, Fernando
2010-06-07 23:27 ` Deepak Chitriki
2010-06-08 3:11 ` Ohad Ben-Cohen
2010-06-08 3:55 ` Hiroshi DOYU
2010-06-08 9:51 ` Felipe Contreras
2010-06-08 3:40 ` Hiroshi DOYU
2010-06-08 17:02 ` Guzman Lugo, Fernando
2010-05-06 5:20 ` [PATCH v3 0/4] omap: mailbox: cleanup & simplify Hiroshi DOYU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTilasmQgcyckgBgpJspRHhsshDlVtdleItZiMp8M@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=deepak.chitriki@ti.com \
--cc=fernando.lugo@ti.com \
--cc=h-kanigeri2@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=omar.ramirez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).