From: Steve Sakoman <sakoman@gmail.com>
To: Anti Sullin <anti.sullin@artecdesign.ee>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Felipe Balbi <felipe.balbi@nokia.com>,
David Brownell <dbrownell@users.sourceforge.net>
Subject: Re: [PATCH] overo twl4030: fix twl4030 IRQ (used for usb otg detection)
Date: Wed, 15 Sep 2010 14:28:57 -0700 [thread overview]
Message-ID: <AANLkTimG7i72PdjaX-2_EqhJkZBFm==StMJZKkzywCf=@mail.gmail.com> (raw)
In-Reply-To: <4C90F46D.2020902@artecdesign.ee>
On Wed, Sep 15, 2010 at 9:29 AM, Anti Sullin <anti.sullin@artecdesign.ee> wrote:
> I was not getting OTG USB vbus/id pin change interrupts on Gumstix Overo
> and the reason was a mis-configured irq. I added some more checks to avoid
> having a non-bootable kernel on boards with bootloaders that have wrong pinmux.
> The changes of twl4030 should be tested on other boards too.
>
> ---
> Gumstix Overo has TPS65950 (TWL4030) IRQ1 connected to GPIO112.
I don't think that this change should be made.
>From what I understand from my discussions with Gumstix, early
versions of the Overo COM used GPIO112 as indicated above.
However all fab revisions >=2516 use GPIO0, so the code is correct for
current and future versions of Overo COMs (as is the bootloader
pinmuxing).
In fact, future versions of Overo will use GPIO112 for a revision ID.
Not an ideal situation, but I think we should leave things as they are
since it matches current and future production.
People with older boards will certainly need to use this patch to get
vbus/id interrupts.
Steve
next prev parent reply other threads:[~2010-09-15 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 16:29 [PATCH] overo twl4030: fix twl4030 IRQ (used for usb otg detection) Anti Sullin
2010-09-15 21:28 ` Steve Sakoman [this message]
2010-09-16 6:07 ` Felipe Balbi
2010-09-16 12:56 ` Steve Sakoman
2010-09-16 17:40 ` Tony Lindgren
2010-09-16 17:46 ` Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimG7i72PdjaX-2_EqhJkZBFm==StMJZKkzywCf=@mail.gmail.com' \
--to=sakoman@gmail.com \
--cc=anti.sullin@artecdesign.ee \
--cc=dbrownell@users.sourceforge.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).