Re: [pm-wip/uart][PATCH] Serial: Avoid populating uart_list in early init phase

[Govindraj <govindraj.ti@gmail.com>]

>
> Your inline patch is still getting mangled somehow.  It looks like
> you're using a webmail client (SquirrelMail) that seems to be altering
> the whitespace in the patch.  The attached .zip worked fine.  Please
> spend some time figuring out how to use git send-email directly
>

Have been trying to setup git-send quite some time, but firewall is blocking.
Will try to get this enabled somehow.

> However, I just discovered another snag...
>
> I did some more testing on Zoom3 and discovered that because we do the
> HWMOD_INIT_NO_IDLE, and omap_serial_init[_port] is never called on Zoom3
> (since it only uses debug board UART) the UART hwmods are left active
> are never disabled (since they are not used.)  This prevents retention :(
>

Yes I was able to reproduce this as said.

But I was trying to set this option from flags field from uart_hmwod
in omap_hwmod data file as below

.flags          = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET),

But strangely it doesn't work, but works only when we set the flag
from serial_early_init phase
any idea why so?

It was hitting retention for zoom2 with earlier suggested changes as
below: [ttyS3->console]

diff --git a/arch/arm/mach-omap2/board-zoom-debugboard.c
b/arch/arm/mach-omap2/board-zoom-debugboard.c
index 1d7f827..9307f58 100644
--- a/arch/arm/mach-omap2/board-zoom-debugboard.c
+++ b/arch/arm/mach-omap2/board-zoom-debugboard.c
@@ -96,7 +96,7 @@ static struct plat_serial8250_port serial_platform_data[] = {

 static struct platform_device zoom_debugboard_serial_device = {
        .name                   = "serial8250",
-       .id                     = PLAT8250_DEV_PLATFORM,
+       .id                     = PLAT8250_DEV_PLATFORM + 4,
        .dev                    = {
                .platform_data  = serial_platform_data,
        },
diff --git a/arch/arm/mach-omap2/board-zoom2.c
b/arch/arm/mach-omap2/board-zoom2.c
index 803ef14..c858b43 100644
--- a/arch/arm/mach-omap2/board-zoom2.c
+++ b/arch/arm/mach-omap2/board-zoom2.c
@@ -80,6 +80,7 @@ static struct omap_board_mux board_mux[] __initdata = {
 static void __init omap_zoom2_init(void)
 {
        omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
+       omap_serial_init();
        zoom_peripherals_init();
        zoom_debugboard_init();
 }


---
Regards,
Govindraj.R
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html