* [PATCH] OMAP4: Add IVA OPP enteries with Updated Voltage Rail Values.
@ 2011-03-03 9:27 Shweta Gulati
2011-03-03 9:34 ` Menon, Nishanth
0 siblings, 1 reply; 7+ messages in thread
From: Shweta Gulati @ 2011-03-03 9:27 UTC (permalink / raw)
To: linux-omap; +Cc: Shweta Gulati
This Patch adds OPP enteries for IVA in OMAP4 OPP Table
and updates IVA voltage Rail values obtained from latest
OMAP4430 Data Manual Operating Condition Addendum.
Tested on OMAP4430 SDP Board.
Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
---
arch/arm/mach-omap2/opp4xxx_data.c | 8 +++++++-
arch/arm/plat-omap/include/plat/voltage.h | 6 +++---
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/opp4xxx_data.c b/arch/arm/mach-omap2/opp4xxx_data.c
index 48d79e5..3e0fbdc 100644
--- a/arch/arm/mach-omap2/opp4xxx_data.c
+++ b/arch/arm/mach-omap2/opp4xxx_data.c
@@ -38,7 +38,13 @@ static struct omap_opp_def __initdata omap44xx_opp_def_list[] = {
OPP_INITIALIZER("l3_main_1", true, 100000000, OMAP4430_VDD_CORE_OPP50_UV),
/* L3 OPP2 - OPP100, OPP-Turbo, OPP-SB */
OPP_INITIALIZER("l3_main_1", true, 200000000, OMAP4430_VDD_CORE_OPP100_UV),
- /* TODO: add IVA, DSP, aess, fdif, gpu */
+ /* IVA OPP1 - OPP50 */
+ OPP_INITIALIZER("iva", true, 133000000, OMAP4430_VDD_IVA_OPP50_UV),
+ /* IVA OPP2 - OPP100 */
+ OPP_INITIALIZER("iva", true, 266100000, OMAP4430_VDD_IVA_OPP100_UV),
+ /* IVA OPP3 - OPP-Turbo */
+ OPP_INITIALIZER("iva", false, 332000000, OMAP4430_VDD_IVA_OPPTURBO_UV),
+ /* TODO: add DSP, aess, fdif, gpu */
};
/**
diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/arch/arm/plat-omap/include/plat/voltage.h
index 4d9bab1..27555ce 100644
--- a/arch/arm/plat-omap/include/plat/voltage.h
+++ b/arch/arm/plat-omap/include/plat/voltage.h
@@ -51,9 +51,9 @@
#define OMAP4430_VDD_MPU_OPPTURBO_UV 1313000
#define OMAP4430_VDD_MPU_OPPNITRO_UV 1375000
-#define OMAP4430_VDD_IVA_OPP50_UV 930000
-#define OMAP4430_VDD_IVA_OPP100_UV 1100000
-#define OMAP4430_VDD_IVA_OPPTURBO_UV 1260000
+#define OMAP4430_VDD_IVA_OPP50_UV 1013000
+#define OMAP4430_VDD_IVA_OPP100_UV 1188000
+#define OMAP4430_VDD_IVA_OPPTURBO_UV 1300000
#define OMAP4430_VDD_CORE_OPP50_UV 930000
#define OMAP4430_VDD_CORE_OPP100_UV 1100000
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: Add IVA OPP enteries with Updated Voltage Rail Values.
2011-03-03 9:27 [PATCH] OMAP4: Add IVA OPP enteries with Updated Voltage Rail Values Shweta Gulati
@ 2011-03-03 9:34 ` Menon, Nishanth
2011-03-03 10:09 ` Gulati, Shweta
0 siblings, 1 reply; 7+ messages in thread
From: Menon, Nishanth @ 2011-03-03 9:34 UTC (permalink / raw)
To: Shweta Gulati; +Cc: linux-omap
On Thu, Mar 3, 2011 at 14:57, Shweta Gulati <shweta.gulati@ti.com> wrote:
>
> This Patch adds OPP enteries for IVA in OMAP4 OPP Table
> and updates IVA voltage Rail values obtained from latest
> OMAP4430 Data Manual Operating Condition Addendum.
Do you think we should add the version of the document in the commit
message - it looks like every "latest" version we look at has some
update, so we'd know what baseline the code currently maps to when we
do a git blame at a later point of time
Regards,
Nishanth Menon
>
> Tested on OMAP4430 SDP Board.
>
> Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
> ---
> arch/arm/mach-omap2/opp4xxx_data.c | 8 +++++++-
> arch/arm/plat-omap/include/plat/voltage.h | 6 +++---
> 2 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/opp4xxx_data.c b/arch/arm/mach-omap2/opp4xxx_data.c
> index 48d79e5..3e0fbdc 100644
> --- a/arch/arm/mach-omap2/opp4xxx_data.c
> +++ b/arch/arm/mach-omap2/opp4xxx_data.c
> @@ -38,7 +38,13 @@ static struct omap_opp_def __initdata omap44xx_opp_def_list[] = {
> OPP_INITIALIZER("l3_main_1", true, 100000000, OMAP4430_VDD_CORE_OPP50_UV),
> /* L3 OPP2 - OPP100, OPP-Turbo, OPP-SB */
> OPP_INITIALIZER("l3_main_1", true, 200000000, OMAP4430_VDD_CORE_OPP100_UV),
> - /* TODO: add IVA, DSP, aess, fdif, gpu */
> + /* IVA OPP1 - OPP50 */
> + OPP_INITIALIZER("iva", true, 133000000, OMAP4430_VDD_IVA_OPP50_UV),
> + /* IVA OPP2 - OPP100 */
> + OPP_INITIALIZER("iva", true, 266100000, OMAP4430_VDD_IVA_OPP100_UV),
> + /* IVA OPP3 - OPP-Turbo */
> + OPP_INITIALIZER("iva", false, 332000000, OMAP4430_VDD_IVA_OPPTURBO_UV),
> + /* TODO: add DSP, aess, fdif, gpu */
> };
>
> /**
> diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/arch/arm/plat-omap/include/plat/voltage.h
> index 4d9bab1..27555ce 100644
> --- a/arch/arm/plat-omap/include/plat/voltage.h
> +++ b/arch/arm/plat-omap/include/plat/voltage.h
> @@ -51,9 +51,9 @@
> #define OMAP4430_VDD_MPU_OPPTURBO_UV 1313000
> #define OMAP4430_VDD_MPU_OPPNITRO_UV 1375000
>
> -#define OMAP4430_VDD_IVA_OPP50_UV 930000
> -#define OMAP4430_VDD_IVA_OPP100_UV 1100000
> -#define OMAP4430_VDD_IVA_OPPTURBO_UV 1260000
> +#define OMAP4430_VDD_IVA_OPP50_UV 1013000
> +#define OMAP4430_VDD_IVA_OPP100_UV 1188000
> +#define OMAP4430_VDD_IVA_OPPTURBO_UV 1300000
>
> #define OMAP4430_VDD_CORE_OPP50_UV 930000
> #define OMAP4430_VDD_CORE_OPP100_UV 1100000
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: Add IVA OPP enteries with Updated Voltage Rail Values.
2011-03-03 9:34 ` Menon, Nishanth
@ 2011-03-03 10:09 ` Gulati, Shweta
2011-03-03 10:23 ` Menon, Nishanth
0 siblings, 1 reply; 7+ messages in thread
From: Gulati, Shweta @ 2011-03-03 10:09 UTC (permalink / raw)
To: Menon, Nishanth; +Cc: linux-omap
Hi,
On Thu, Mar 3, 2011 at 3:04 PM, Menon, Nishanth <nm@ti.com> wrote:
> On Thu, Mar 3, 2011 at 14:57, Shweta Gulati <shweta.gulati@ti.com> wrote:
>>
>> This Patch adds OPP enteries for IVA in OMAP4 OPP Table
>> and updates IVA voltage Rail values obtained from latest
>> OMAP4430 Data Manual Operating Condition Addendum.
> Do you think we should add the version of the document in the commit
> message - it looks like every "latest" version we look at has some
> update, so we'd know what baseline the code currently maps to when we
> do a git blame at a later point of time
Ok, Will do.
> Regards,
> Nishanth Menon
>
>>
>> Tested on OMAP4430 SDP Board.
>>
>> Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
>> ---
>> arch/arm/mach-omap2/opp4xxx_data.c | 8 +++++++-
>> arch/arm/plat-omap/include/plat/voltage.h | 6 +++---
>> 2 files changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/opp4xxx_data.c b/arch/arm/mach-omap2/opp4xxx_data.c
>> index 48d79e5..3e0fbdc 100644
>> --- a/arch/arm/mach-omap2/opp4xxx_data.c
>> +++ b/arch/arm/mach-omap2/opp4xxx_data.c
>> @@ -38,7 +38,13 @@ static struct omap_opp_def __initdata omap44xx_opp_def_list[] = {
>> OPP_INITIALIZER("l3_main_1", true, 100000000, OMAP4430_VDD_CORE_OPP50_UV),
>> /* L3 OPP2 - OPP100, OPP-Turbo, OPP-SB */
>> OPP_INITIALIZER("l3_main_1", true, 200000000, OMAP4430_VDD_CORE_OPP100_UV),
>> - /* TODO: add IVA, DSP, aess, fdif, gpu */
>> + /* IVA OPP1 - OPP50 */
>> + OPP_INITIALIZER("iva", true, 133000000, OMAP4430_VDD_IVA_OPP50_UV),
>> + /* IVA OPP2 - OPP100 */
>> + OPP_INITIALIZER("iva", true, 266100000, OMAP4430_VDD_IVA_OPP100_UV),
>> + /* IVA OPP3 - OPP-Turbo */
>> + OPP_INITIALIZER("iva", false, 332000000, OMAP4430_VDD_IVA_OPPTURBO_UV),
>> + /* TODO: add DSP, aess, fdif, gpu */
>> };
>>
>> /**
>> diff --git a/arch/arm/plat-omap/include/plat/voltage.h b/arch/arm/plat-omap/include/plat/voltage.h
>> index 4d9bab1..27555ce 100644
>> --- a/arch/arm/plat-omap/include/plat/voltage.h
>> +++ b/arch/arm/plat-omap/include/plat/voltage.h
>> @@ -51,9 +51,9 @@
>> #define OMAP4430_VDD_MPU_OPPTURBO_UV 1313000
>> #define OMAP4430_VDD_MPU_OPPNITRO_UV 1375000
>>
>> -#define OMAP4430_VDD_IVA_OPP50_UV 930000
>> -#define OMAP4430_VDD_IVA_OPP100_UV 1100000
>> -#define OMAP4430_VDD_IVA_OPPTURBO_UV 1260000
>> +#define OMAP4430_VDD_IVA_OPP50_UV 1013000
>> +#define OMAP4430_VDD_IVA_OPP100_UV 1188000
>> +#define OMAP4430_VDD_IVA_OPPTURBO_UV 1300000
>>
>> #define OMAP4430_VDD_CORE_OPP50_UV 930000
>> #define OMAP4430_VDD_CORE_OPP100_UV 1100000
>> --
>> 1.7.0.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Thanks,
Regards,
Shweta
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: Add IVA OPP enteries with Updated Voltage Rail Values.
2011-03-03 10:09 ` Gulati, Shweta
@ 2011-03-03 10:23 ` Menon, Nishanth
2011-03-03 14:07 ` Gulati, Shweta
0 siblings, 1 reply; 7+ messages in thread
From: Menon, Nishanth @ 2011-03-03 10:23 UTC (permalink / raw)
To: Gulati, Shweta; +Cc: linux-omap
On Thu, Mar 3, 2011 at 15:39, Gulati, Shweta <shweta.gulati@ti.com> wrote:
> Hi,
>
> On Thu, Mar 3, 2011 at 3:04 PM, Menon, Nishanth <nm@ti.com> wrote:
>> On Thu, Mar 3, 2011 at 14:57, Shweta Gulati <shweta.gulati@ti.com> wrote:
>>>
>>> This Patch adds OPP enteries for IVA in OMAP4 OPP Table
>>> and updates IVA voltage Rail values obtained from latest
>>> OMAP4430 Data Manual Operating Condition Addendum.
>> Do you think we should add the version of the document in the commit
>> message - it looks like every "latest" version we look at has some
>> update, so we'd know what baseline the code currently maps to when we
>> do a git blame at a later point of time
> Ok, Will do.
Sorry, one more tiny point I missed - for the sake of ensuring the
functional bisectability - could you do the following:
a) update voltages (MPU,IVA) for doc 0.3
b) introduce IVA OPPs
what do you think?
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: Add IVA OPP enteries with Updated Voltage Rail Values.
2011-03-03 10:23 ` Menon, Nishanth
@ 2011-03-03 14:07 ` Gulati, Shweta
2011-03-03 14:41 ` Nishanth Menon
0 siblings, 1 reply; 7+ messages in thread
From: Gulati, Shweta @ 2011-03-03 14:07 UTC (permalink / raw)
To: Menon, Nishanth; +Cc: linux-omap
Hi,
On Thu, Mar 3, 2011 at 3:53 PM, Menon, Nishanth <nm@ti.com> wrote:
> On Thu, Mar 3, 2011 at 15:39, Gulati, Shweta <shweta.gulati@ti.com> wrote:
>> Hi,
>>
>> On Thu, Mar 3, 2011 at 3:04 PM, Menon, Nishanth <nm@ti.com> wrote:
>>> On Thu, Mar 3, 2011 at 14:57, Shweta Gulati <shweta.gulati@ti.com> wrote:
>>>>
>>>> This Patch adds OPP enteries for IVA in OMAP4 OPP Table
>>>> and updates IVA voltage Rail values obtained from latest
>>>> OMAP4430 Data Manual Operating Condition Addendum.
>>> Do you think we should add the version of the document in the commit
>>> message - it looks like every "latest" version we look at has some
>>> update, so we'd know what baseline the code currently maps to when we
>>> do a git blame at a later point of time
>> Ok, Will do.
> Sorry, one more tiny point I missed - for the sake of ensuring the
> functional bisectability - could you do the following:
> a) update voltages (MPU,IVA) for doc 0.3
> b) introduce IVA OPPs
> what do you think?
I think its better to submit MPU and IVA domain Patches seperately
The way I have done:
1. Patch Series that has MPU OPP Table and Voltage Rail Value changes.
2. Patch which adds IVA OPP Entries and updates Voltage Rail values.
>
> Regards,
> Nishanth Menon
>
--
Thanks,
Regards,
Shweta
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: Add IVA OPP enteries with Updated Voltage Rail Values.
2011-03-03 14:07 ` Gulati, Shweta
@ 2011-03-03 14:41 ` Nishanth Menon
2011-03-04 12:20 ` Gulati, Shweta
0 siblings, 1 reply; 7+ messages in thread
From: Nishanth Menon @ 2011-03-03 14:41 UTC (permalink / raw)
To: Gulati, Shweta; +Cc: linux-omap
Gulati, Shweta wrote, on 03/03/2011 07:37 PM:
> Hi,
>
> On Thu, Mar 3, 2011 at 3:53 PM, Menon, Nishanth<nm@ti.com> wrote:
>> On Thu, Mar 3, 2011 at 15:39, Gulati, Shweta<shweta.gulati@ti.com> wrote:
>>> Hi,
>>>
>>> On Thu, Mar 3, 2011 at 3:04 PM, Menon, Nishanth<nm@ti.com> wrote:
>>>> On Thu, Mar 3, 2011 at 14:57, Shweta Gulati<shweta.gulati@ti.com> wrote:
>>>>>
>>>>> This Patch adds OPP enteries for IVA in OMAP4 OPP Table
>>>>> and updates IVA voltage Rail values obtained from latest
>>>>> OMAP4430 Data Manual Operating Condition Addendum.
>>>> Do you think we should add the version of the document in the commit
>>>> message - it looks like every "latest" version we look at has some
>>>> update, so we'd know what baseline the code currently maps to when we
>>>> do a git blame at a later point of time
>>> Ok, Will do.
>> Sorry, one more tiny point I missed - for the sake of ensuring the
>> functional bisectability - could you do the following:
>> a) update voltages (MPU,IVA) for doc 0.3
>> b) introduce IVA OPPs
>
>> what do you think?
> I think its better to submit MPU and IVA domain Patches seperately
> The way I have done:
> 1. Patch Series that has MPU OPP Table and Voltage Rail Value changes.
> 2. Patch which adds IVA OPP Entries and updates Voltage Rail values.
Thank you, but I had already understood what had been done. I was
wondering if there is a reason why not we do:
a) voltage updates on the code we already have - this categorizes as a fix
b) introduce OPP entries for IVA - this in a way categorizes as a
"feature addition"
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: Add IVA OPP enteries with Updated Voltage Rail Values.
2011-03-03 14:41 ` Nishanth Menon
@ 2011-03-04 12:20 ` Gulati, Shweta
0 siblings, 0 replies; 7+ messages in thread
From: Gulati, Shweta @ 2011-03-04 12:20 UTC (permalink / raw)
To: Nishanth Menon; +Cc: linux-omap
Hi,
On Thu, Mar 3, 2011 at 8:11 PM, Nishanth Menon <nm@ti.com> wrote:
> Gulati, Shweta wrote, on 03/03/2011 07:37 PM:
>>
>> Hi,
>>
>> On Thu, Mar 3, 2011 at 3:53 PM, Menon, Nishanth<nm@ti.com> wrote:
>>>
>>> On Thu, Mar 3, 2011 at 15:39, Gulati, Shweta<shweta.gulati@ti.com>
>>> wrote:
>>>>
>>>> Hi,
>>>>
>>>> On Thu, Mar 3, 2011 at 3:04 PM, Menon, Nishanth<nm@ti.com> wrote:
>>>>>
>>>>> On Thu, Mar 3, 2011 at 14:57, Shweta Gulati<shweta.gulati@ti.com>
>>>>> wrote:
>>>>>>
>>>>>> This Patch adds OPP enteries for IVA in OMAP4 OPP Table
>>>>>> and updates IVA voltage Rail values obtained from latest
>>>>>> OMAP4430 Data Manual Operating Condition Addendum.
>>>>>
>>>>> Do you think we should add the version of the document in the commit
>>>>> message - it looks like every "latest" version we look at has some
>>>>> update, so we'd know what baseline the code currently maps to when we
>>>>> do a git blame at a later point of time
>>>>
>>>> Ok, Will do.
>>>
>>> Sorry, one more tiny point I missed - for the sake of ensuring the
>>> functional bisectability - could you do the following:
>>> a) update voltages (MPU,IVA) for doc 0.3
>>> b) introduce IVA OPPs
>>
>>> what do you think?
>>
>> I think its better to submit MPU and IVA domain Patches seperately
>> The way I have done:
>> 1. Patch Series that has MPU OPP Table and Voltage Rail Value changes.
>> 2. Patch which adds IVA OPP Entries and updates Voltage Rail values.
>
> Thank you, but I had already understood what had been done. I was wondering
> if there is a reason why not we do:
> a) voltage updates on the code we already have - this categorizes as a fix
> b) introduce OPP entries for IVA - this in a way categorizes as a "feature
> addition"
Ok, will do this way, rebasing all the patches to pm-core branch and
including all comments
received and putting features and fixes in different patches of a new
series.Thanks.
> --
> Regards,
> Nishanth Menon
>
--
Thanks,
Regards,
Shweta
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-03-04 12:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-03 9:27 [PATCH] OMAP4: Add IVA OPP enteries with Updated Voltage Rail Values Shweta Gulati
2011-03-03 9:34 ` Menon, Nishanth
2011-03-03 10:09 ` Gulati, Shweta
2011-03-03 10:23 ` Menon, Nishanth
2011-03-03 14:07 ` Gulati, Shweta
2011-03-03 14:41 ` Nishanth Menon
2011-03-04 12:20 ` Gulati, Shweta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).