From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ernesto Ramos <ernesto@ti.com>
Cc: gregkh@suse.de, omar.ramirez@ti.com, ohad@wizery.com,
ameya.palande@nokia.com, felipe.contreras@nokia.com,
fernando.lugo@ti.com, linux-kernel@vger.kernel.org, nm@ti.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict_strtoul
Date: Wed, 28 Jul 2010 21:43:54 +0300 [thread overview]
Message-ID: <AANLkTin-2_JC0-18QWAdo9r36Jx0QdnDwnB2+2AdePyc@mail.gmail.com> (raw)
In-Reply-To: <1280328052-31292-6-git-send-email-ernesto@ti.com>
On Wed, Jul 28, 2010 at 5:40 PM, Ernesto Ramos <ernesto@ti.com> wrote:
> Replace simple_strtoul by strict_strtoul in atoi function.
In general the question what is the purpose here to do the change?
> @@ -1023,7 +1025,9 @@ static s32 atoi(char *psz_buf)
> base = 16;
> }
>
> - return simple_strtoul(pch, NULL, base);
> + ret_val = strict_strtoul(pch, base, &res);
> +
> + return ret_val ? : res;
May be better to use explicit values in condition?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-07-28 18:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 14:40 [PATCH 0/5] staging:ti dspbridge: Checkpatch errors cleanup series Ernesto Ramos
2010-07-28 14:40 ` [PATCH 1/5] staging:ti dspbridge: remove unused typedef REG16 Ernesto Ramos
2010-07-28 14:40 ` [PATCH 2/5] staging:ti dspbridge: remove unnecessary check for NULL pointer in cmm.c Ernesto Ramos
2010-07-28 14:40 ` [PATCH 3/5] staging:ti dspbridge: remove function delete_strm_mgr Ernesto Ramos
2010-07-28 14:40 ` [PATCH 4/5] staging:ti dspbridge: remove unnecessary volatile variables Ernesto Ramos
2010-07-28 14:40 ` [PATCH 5/5] staging:ti dspbridge: replace simple_strtoul by strict_strtoul Ernesto Ramos
2010-07-28 15:09 ` Greg KH
2010-07-28 18:40 ` Andy Shevchenko
2010-07-28 18:56 ` Greg KH
2010-07-28 18:43 ` Andy Shevchenko [this message]
2010-08-03 17:33 ` Ramos Falcon, Ernesto
2010-07-28 15:03 ` [PATCH 4/5] staging:ti dspbridge: remove unnecessary volatile variables Nishanth Menon
2010-08-02 19:46 ` Ramos Falcon, Ernesto
2010-07-28 15:04 ` [PATCH 2/5] staging:ti dspbridge: remove unnecessary check for NULL pointer in cmm.c Nishanth Menon
2010-07-28 15:31 ` Nishanth Menon
2010-07-28 16:53 ` Ramos Falcon, Ernesto
2010-07-28 17:11 ` Felipe Contreras
2010-07-28 17:29 ` Ramos Falcon, Ernesto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin-2_JC0-18QWAdo9r36Jx0QdnDwnB2+2AdePyc@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=ameya.palande@nokia.com \
--cc=ernesto@ti.com \
--cc=felipe.contreras@nokia.com \
--cc=fernando.lugo@ti.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=ohad@wizery.com \
--cc=omar.ramirez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).