From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-2?Q?Micha=B3_Miros=B3aw?= Subject: Re: [PATCH v5 3/7] wireless: wl12xx: add platform data passing support Date: Wed, 15 Sep 2010 18:10:22 +0200 Message-ID: References: <1283376410-9999-1-git-send-email-ohad@wizery.com> <1283376410-9999-4-git-send-email-ohad@wizery.com> <20100906120716.GE20903@n2100.arm.linux.org.uk> <20100915082544.GA4625@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20100915082544.GA4625@n2100.arm.linux.org.uk> Sender: linux-mmc-owner@vger.kernel.org To: Russell King - ARM Linux Cc: Ohad Ben-Cohen , linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, Kalle Valo , Nicolas Pitre , Tony Lindgren , Mark Brown , Roger Quadros , Ido Yariv , San Mehat , Chikkature Rajashekar Madhusudhan , Luciano Coelho , akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org W dniu 15 wrze=B6nia 2010 10:25 u=BFytkownik Russell King - ARM Linux napisa=B3: > On Mon, Sep 06, 2010 at 09:42:41PM +0200, Micha=B3 Miros=B3aw wrote: >> W dniu 6 wrze=B6nia 2010 14:07 u=BFytkownik Russell King - ARM Linux >> napisa=B3: >> > On Sat, Sep 04, 2010 at 02:23:19PM +0200, Micha=B3 Miros=B3aw wrot= e: >> >> 2010/9/1 Ohad Ben-Cohen : >> >> > Add a simple mechanism to pass platform data to the >> >> > SDIO instances of wl12xx. >> [cut patch] >> >> Why do you need all that copying? Isn't the data constant? >> > The first copy is to allow platforms to have their data marked wit= h >> > __initdata. =A0The second copy probably isn't necessary, but avoid= s >> > problems where the driver may decide to modify the platform data. >> Sorry for pushing at this, but why would you mark data that's meant = to >> be used after init phase as __initdata? > Because you may have many instances of the data (due to multiple plat= form > support), and only need one of them at run-time. Ah. That makes sense. Thanks, Micha=B3 Miros=B3aw