From: Jean Pihet <jean.pihet@newoldbits.com>
To: andy.green@linaro.org, David Anders <x0132446@ti.com>
Cc: linux-omap@vger.kernel.org, khilman@deeprootsystems.com,
tony@atomide.com
Subject: Re: [PATCH] OMAP4: PandaBoard: remove unused power regulators
Date: Wed, 16 Mar 2011 10:19:41 +0100 [thread overview]
Message-ID: <AANLkTing6jerp4mVgVDkW7eTu9LPgwRNAR9KXQPZNWcs@mail.gmail.com> (raw)
In-Reply-To: <4D7FBA82.40403@linaro.org>
On Tue, Mar 15, 2011 at 8:14 PM, Andy Green <andy@warmcat.com> wrote:
> On 03/15/2011 07:10 PM, Somebody in the thread at some point said:
>>
>> the pandaboard does not use the VUSIM or VAUX1 power regulators on the
>> TWL6030
>> and are left floating. if the VUSIM and VAUX1 power regulators are
>> initilized,
>> noise on the unloaded regulators generates an overcurrent interrupt
>> causing the
>> system to power down. this patch removes the initialization of the unused
>> power
>> regulators of VUSIM and VAUX1.
>>
>> Signed-off-by: David Anders<x0132446@ti.com>
>
> Acked-by: Andy Green <andy.green@linaro.org>
>
> Great job finding this one David.
Great!
Acked-by: Jean Pihet <j-pihet@ti.com>
Thanks,
Jean
>
>> ---
>> arch/arm/mach-omap2/board-omap4panda.c | 28
>> ----------------------------
>> 1 files changed, 0 insertions(+), 28 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-omap4panda.c
>> b/arch/arm/mach-omap2/board-omap4panda.c
>> index e944025..abc913b 100644
>> --- a/arch/arm/mach-omap2/board-omap4panda.c
>> +++ b/arch/arm/mach-omap2/board-omap4panda.c
>> @@ -220,19 +220,6 @@ static int __init omap4_twl6030_hsmmc_init(struct
>> omap2_hsmmc_info *controllers)
>> return 0;
>> }
>>
>> -static struct regulator_init_data omap4_panda_vaux1 = {
>> - .constraints = {
>> - .min_uV = 1000000,
>> - .max_uV = 3000000,
>> - .apply_uV = true,
>> - .valid_modes_mask = REGULATOR_MODE_NORMAL
>> - | REGULATOR_MODE_STANDBY,
>> - .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
>> - | REGULATOR_CHANGE_MODE
>> - | REGULATOR_CHANGE_STATUS,
>> - },
>> -};
>> -
>> static struct regulator_init_data omap4_panda_vaux2 = {
>> .constraints = {
>> .min_uV = 1200000,
>> @@ -288,19 +275,6 @@ static struct regulator_init_data omap4_panda_vpp = {
>> },
>> };
>>
>> -static struct regulator_init_data omap4_panda_vusim = {
>> - .constraints = {
>> - .min_uV = 1200000,
>> - .max_uV = 2900000,
>> - .apply_uV = true,
>> - .valid_modes_mask = REGULATOR_MODE_NORMAL
>> - | REGULATOR_MODE_STANDBY,
>> - .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
>> - | REGULATOR_CHANGE_MODE
>> - | REGULATOR_CHANGE_STATUS,
>> - },
>> -};
>> -
>> static struct regulator_init_data omap4_panda_vana = {
>> .constraints = {
>> .min_uV = 2100000,
>> @@ -356,12 +330,10 @@ static struct twl4030_platform_data
>> omap4_panda_twldata = {
>> /* Regulators */
>> .vmmc =&omap4_panda_vmmc,
>> .vpp =&omap4_panda_vpp,
>> - .vusim =&omap4_panda_vusim,
>> .vana =&omap4_panda_vana,
>> .vcxio =&omap4_panda_vcxio,
>> .vdac =&omap4_panda_vdac,
>> .vusb =&omap4_panda_vusb,
>> - .vaux1 =&omap4_panda_vaux1,
>> .vaux2 =&omap4_panda_vaux2,
>> .vaux3 =&omap4_panda_vaux3,
>> .usb =&omap4_usbphy_data,
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-16 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 19:10 [PATCH] OMAP4: PandaBoard: remove unused power regulators David Anders
2011-03-15 19:14 ` Andy Green
2011-03-16 9:19 ` Jean Pihet [this message]
2011-03-16 15:28 ` Jarkko Nikula
2011-03-17 10:12 ` Anand Gadiyar
2011-03-17 14:36 ` Kevin Hilman
2011-03-18 23:43 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTing6jerp4mVgVDkW7eTu9LPgwRNAR9KXQPZNWcs@mail.gmail.com \
--to=jean.pihet@newoldbits.com \
--cc=andy.green@linaro.org \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=x0132446@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).