* [PATCH] OMAP4: PandaBoard: remove unused power regulators
@ 2011-03-15 19:10 David Anders
2011-03-15 19:14 ` Andy Green
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: David Anders @ 2011-03-15 19:10 UTC (permalink / raw)
To: linux-omap; +Cc: khilman, andy.green, tony, David Anders
the pandaboard does not use the VUSIM or VAUX1 power regulators on the TWL6030
and are left floating. if the VUSIM and VAUX1 power regulators are initilized,
noise on the unloaded regulators generates an overcurrent interrupt causing the
system to power down. this patch removes the initialization of the unused power
regulators of VUSIM and VAUX1.
Signed-off-by: David Anders <x0132446@ti.com>
---
arch/arm/mach-omap2/board-omap4panda.c | 28 ----------------------------
1 files changed, 0 insertions(+), 28 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
index e944025..abc913b 100644
--- a/arch/arm/mach-omap2/board-omap4panda.c
+++ b/arch/arm/mach-omap2/board-omap4panda.c
@@ -220,19 +220,6 @@ static int __init omap4_twl6030_hsmmc_init(struct omap2_hsmmc_info *controllers)
return 0;
}
-static struct regulator_init_data omap4_panda_vaux1 = {
- .constraints = {
- .min_uV = 1000000,
- .max_uV = 3000000,
- .apply_uV = true,
- .valid_modes_mask = REGULATOR_MODE_NORMAL
- | REGULATOR_MODE_STANDBY,
- .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
- | REGULATOR_CHANGE_MODE
- | REGULATOR_CHANGE_STATUS,
- },
-};
-
static struct regulator_init_data omap4_panda_vaux2 = {
.constraints = {
.min_uV = 1200000,
@@ -288,19 +275,6 @@ static struct regulator_init_data omap4_panda_vpp = {
},
};
-static struct regulator_init_data omap4_panda_vusim = {
- .constraints = {
- .min_uV = 1200000,
- .max_uV = 2900000,
- .apply_uV = true,
- .valid_modes_mask = REGULATOR_MODE_NORMAL
- | REGULATOR_MODE_STANDBY,
- .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
- | REGULATOR_CHANGE_MODE
- | REGULATOR_CHANGE_STATUS,
- },
-};
-
static struct regulator_init_data omap4_panda_vana = {
.constraints = {
.min_uV = 2100000,
@@ -356,12 +330,10 @@ static struct twl4030_platform_data omap4_panda_twldata = {
/* Regulators */
.vmmc = &omap4_panda_vmmc,
.vpp = &omap4_panda_vpp,
- .vusim = &omap4_panda_vusim,
.vana = &omap4_panda_vana,
.vcxio = &omap4_panda_vcxio,
.vdac = &omap4_panda_vdac,
.vusb = &omap4_panda_vusb,
- .vaux1 = &omap4_panda_vaux1,
.vaux2 = &omap4_panda_vaux2,
.vaux3 = &omap4_panda_vaux3,
.usb = &omap4_usbphy_data,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] OMAP4: PandaBoard: remove unused power regulators
2011-03-15 19:10 [PATCH] OMAP4: PandaBoard: remove unused power regulators David Anders
@ 2011-03-15 19:14 ` Andy Green
2011-03-16 9:19 ` Jean Pihet
2011-03-17 10:12 ` Anand Gadiyar
2011-03-17 14:36 ` Kevin Hilman
2 siblings, 1 reply; 7+ messages in thread
From: Andy Green @ 2011-03-15 19:14 UTC (permalink / raw)
To: David Anders; +Cc: linux-omap, khilman, tony
On 03/15/2011 07:10 PM, Somebody in the thread at some point said:
> the pandaboard does not use the VUSIM or VAUX1 power regulators on the TWL6030
> and are left floating. if the VUSIM and VAUX1 power regulators are initilized,
> noise on the unloaded regulators generates an overcurrent interrupt causing the
> system to power down. this patch removes the initialization of the unused power
> regulators of VUSIM and VAUX1.
>
> Signed-off-by: David Anders<x0132446@ti.com>
Acked-by: Andy Green <andy.green@linaro.org>
Great job finding this one David.
> ---
> arch/arm/mach-omap2/board-omap4panda.c | 28 ----------------------------
> 1 files changed, 0 insertions(+), 28 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index e944025..abc913b 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -220,19 +220,6 @@ static int __init omap4_twl6030_hsmmc_init(struct omap2_hsmmc_info *controllers)
> return 0;
> }
>
> -static struct regulator_init_data omap4_panda_vaux1 = {
> - .constraints = {
> - .min_uV = 1000000,
> - .max_uV = 3000000,
> - .apply_uV = true,
> - .valid_modes_mask = REGULATOR_MODE_NORMAL
> - | REGULATOR_MODE_STANDBY,
> - .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
> - | REGULATOR_CHANGE_MODE
> - | REGULATOR_CHANGE_STATUS,
> - },
> -};
> -
> static struct regulator_init_data omap4_panda_vaux2 = {
> .constraints = {
> .min_uV = 1200000,
> @@ -288,19 +275,6 @@ static struct regulator_init_data omap4_panda_vpp = {
> },
> };
>
> -static struct regulator_init_data omap4_panda_vusim = {
> - .constraints = {
> - .min_uV = 1200000,
> - .max_uV = 2900000,
> - .apply_uV = true,
> - .valid_modes_mask = REGULATOR_MODE_NORMAL
> - | REGULATOR_MODE_STANDBY,
> - .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
> - | REGULATOR_CHANGE_MODE
> - | REGULATOR_CHANGE_STATUS,
> - },
> -};
> -
> static struct regulator_init_data omap4_panda_vana = {
> .constraints = {
> .min_uV = 2100000,
> @@ -356,12 +330,10 @@ static struct twl4030_platform_data omap4_panda_twldata = {
> /* Regulators */
> .vmmc =&omap4_panda_vmmc,
> .vpp =&omap4_panda_vpp,
> - .vusim =&omap4_panda_vusim,
> .vana =&omap4_panda_vana,
> .vcxio =&omap4_panda_vcxio,
> .vdac =&omap4_panda_vdac,
> .vusb =&omap4_panda_vusb,
> - .vaux1 =&omap4_panda_vaux1,
> .vaux2 =&omap4_panda_vaux2,
> .vaux3 =&omap4_panda_vaux3,
> .usb =&omap4_usbphy_data,
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] OMAP4: PandaBoard: remove unused power regulators
2011-03-15 19:14 ` Andy Green
@ 2011-03-16 9:19 ` Jean Pihet
2011-03-16 15:28 ` Jarkko Nikula
0 siblings, 1 reply; 7+ messages in thread
From: Jean Pihet @ 2011-03-16 9:19 UTC (permalink / raw)
To: andy.green, David Anders; +Cc: linux-omap, khilman, tony
On Tue, Mar 15, 2011 at 8:14 PM, Andy Green <andy@warmcat.com> wrote:
> On 03/15/2011 07:10 PM, Somebody in the thread at some point said:
>>
>> the pandaboard does not use the VUSIM or VAUX1 power regulators on the
>> TWL6030
>> and are left floating. if the VUSIM and VAUX1 power regulators are
>> initilized,
>> noise on the unloaded regulators generates an overcurrent interrupt
>> causing the
>> system to power down. this patch removes the initialization of the unused
>> power
>> regulators of VUSIM and VAUX1.
>>
>> Signed-off-by: David Anders<x0132446@ti.com>
>
> Acked-by: Andy Green <andy.green@linaro.org>
>
> Great job finding this one David.
Great!
Acked-by: Jean Pihet <j-pihet@ti.com>
Thanks,
Jean
>
>> ---
>> arch/arm/mach-omap2/board-omap4panda.c | 28
>> ----------------------------
>> 1 files changed, 0 insertions(+), 28 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-omap4panda.c
>> b/arch/arm/mach-omap2/board-omap4panda.c
>> index e944025..abc913b 100644
>> --- a/arch/arm/mach-omap2/board-omap4panda.c
>> +++ b/arch/arm/mach-omap2/board-omap4panda.c
>> @@ -220,19 +220,6 @@ static int __init omap4_twl6030_hsmmc_init(struct
>> omap2_hsmmc_info *controllers)
>> return 0;
>> }
>>
>> -static struct regulator_init_data omap4_panda_vaux1 = {
>> - .constraints = {
>> - .min_uV = 1000000,
>> - .max_uV = 3000000,
>> - .apply_uV = true,
>> - .valid_modes_mask = REGULATOR_MODE_NORMAL
>> - | REGULATOR_MODE_STANDBY,
>> - .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
>> - | REGULATOR_CHANGE_MODE
>> - | REGULATOR_CHANGE_STATUS,
>> - },
>> -};
>> -
>> static struct regulator_init_data omap4_panda_vaux2 = {
>> .constraints = {
>> .min_uV = 1200000,
>> @@ -288,19 +275,6 @@ static struct regulator_init_data omap4_panda_vpp = {
>> },
>> };
>>
>> -static struct regulator_init_data omap4_panda_vusim = {
>> - .constraints = {
>> - .min_uV = 1200000,
>> - .max_uV = 2900000,
>> - .apply_uV = true,
>> - .valid_modes_mask = REGULATOR_MODE_NORMAL
>> - | REGULATOR_MODE_STANDBY,
>> - .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
>> - | REGULATOR_CHANGE_MODE
>> - | REGULATOR_CHANGE_STATUS,
>> - },
>> -};
>> -
>> static struct regulator_init_data omap4_panda_vana = {
>> .constraints = {
>> .min_uV = 2100000,
>> @@ -356,12 +330,10 @@ static struct twl4030_platform_data
>> omap4_panda_twldata = {
>> /* Regulators */
>> .vmmc =&omap4_panda_vmmc,
>> .vpp =&omap4_panda_vpp,
>> - .vusim =&omap4_panda_vusim,
>> .vana =&omap4_panda_vana,
>> .vcxio =&omap4_panda_vcxio,
>> .vdac =&omap4_panda_vdac,
>> .vusb =&omap4_panda_vusb,
>> - .vaux1 =&omap4_panda_vaux1,
>> .vaux2 =&omap4_panda_vaux2,
>> .vaux3 =&omap4_panda_vaux3,
>> .usb =&omap4_usbphy_data,
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] OMAP4: PandaBoard: remove unused power regulators
2011-03-16 9:19 ` Jean Pihet
@ 2011-03-16 15:28 ` Jarkko Nikula
0 siblings, 0 replies; 7+ messages in thread
From: Jarkko Nikula @ 2011-03-16 15:28 UTC (permalink / raw)
To: Jean Pihet; +Cc: andy.green, David Anders, linux-omap, khilman, tony
On Wed, 16 Mar 2011 10:19:41 +0100
Jean Pihet <jean.pihet@newoldbits.com> wrote:
> On Tue, Mar 15, 2011 at 8:14 PM, Andy Green <andy@warmcat.com> wrote:
> > On 03/15/2011 07:10 PM, Somebody in the thread at some point said:
> >>
> >> the pandaboard does not use the VUSIM or VAUX1 power regulators on the
> >> TWL6030
> >> and are left floating. if the VUSIM and VAUX1 power regulators are
> >> initilized,
> >> noise on the unloaded regulators generates an overcurrent interrupt
> >> causing the
> >> system to power down. this patch removes the initialization of the unused
> >> power
> >> regulators of VUSIM and VAUX1.
> >>
> >> Signed-off-by: David Anders<x0132446@ti.com>
> >
> > Acked-by: Andy Green <andy.green@linaro.org>
> >
> > Great job finding this one David.
> Great!
>
> Acked-by: Jean Pihet <j-pihet@ti.com>
>
Excellent! Some of us don't need a halogen lamp anymore to run
Panda [1] :-)
And indeed, the VUSIM and VAUX1 are unused according to schematics.
Definitely 2.6.38-rc material and probably 2.6.37 stable too?
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
---
1. http://marc.info/?l=linux-omap&m=129784674528539&w=2
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] OMAP4: PandaBoard: remove unused power regulators
2011-03-15 19:10 [PATCH] OMAP4: PandaBoard: remove unused power regulators David Anders
2011-03-15 19:14 ` Andy Green
@ 2011-03-17 10:12 ` Anand Gadiyar
2011-03-17 14:36 ` Kevin Hilman
2 siblings, 0 replies; 7+ messages in thread
From: Anand Gadiyar @ 2011-03-17 10:12 UTC (permalink / raw)
To: David Anders, linux-omap; +Cc: khilman, andy.green, tony
David Anders wrote:
> the pandaboard does not use the VUSIM or VAUX1 power regulators on the
TWL6030
> and are left floating. if the VUSIM and VAUX1 power regulators are
initilized,
> noise on the unloaded regulators generates an overcurrent interrupt
causing the
> system to power down. this patch removes the initialization of the
unused power
> regulators of VUSIM and VAUX1.
>
> Signed-off-by: David Anders <x0132446@ti.com>
For what it's worth, thanks for tracking this down!
Acked-by: Anand Gadiyar <gadiyar@ti.com>
> ---
> arch/arm/mach-omap2/board-omap4panda.c | 28
----------------------------
> 1 files changed, 0 insertions(+), 28 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c
> b/arch/arm/mach-omap2/board-omap4panda.c
> index e944025..abc913b 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -220,19 +220,6 @@ static int __init
> omap4_twl6030_hsmmc_init(struct omap2_hsmmc_info *controllers)
> return 0;
> }
>
> -static struct regulator_init_data omap4_panda_vaux1 = {
> - .constraints = {
> - .min_uV = 1000000,
> - .max_uV = 3000000,
> - .apply_uV = true,
> - .valid_modes_mask = REGULATOR_MODE_NORMAL
> - | REGULATOR_MODE_STANDBY,
> - .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
> - | REGULATOR_CHANGE_MODE
> - | REGULATOR_CHANGE_STATUS,
> - },
> -};
> -
> static struct regulator_init_data omap4_panda_vaux2 = {
> .constraints = {
> .min_uV = 1200000,
> @@ -288,19 +275,6 @@ static struct regulator_init_data omap4_panda_vpp =
{
> },
> };
>
> -static struct regulator_init_data omap4_panda_vusim = {
> - .constraints = {
> - .min_uV = 1200000,
> - .max_uV = 2900000,
> - .apply_uV = true,
> - .valid_modes_mask = REGULATOR_MODE_NORMAL
> - | REGULATOR_MODE_STANDBY,
> - .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE
> - | REGULATOR_CHANGE_MODE
> - | REGULATOR_CHANGE_STATUS,
> - },
> -};
> -
> static struct regulator_init_data omap4_panda_vana = {
> .constraints = {
> .min_uV = 2100000,
> @@ -356,12 +330,10 @@ static struct twl4030_platform_data
omap4_panda_twldata = {
> /* Regulators */
> .vmmc = &omap4_panda_vmmc,
> .vpp = &omap4_panda_vpp,
> - .vusim = &omap4_panda_vusim,
> .vana = &omap4_panda_vana,
> .vcxio = &omap4_panda_vcxio,
> .vdac = &omap4_panda_vdac,
> .vusb = &omap4_panda_vusb,
> - .vaux1 = &omap4_panda_vaux1,
> .vaux2 = &omap4_panda_vaux2,
> .vaux3 = &omap4_panda_vaux3,
> .usb = &omap4_usbphy_data,
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] OMAP4: PandaBoard: remove unused power regulators
2011-03-15 19:10 [PATCH] OMAP4: PandaBoard: remove unused power regulators David Anders
2011-03-15 19:14 ` Andy Green
2011-03-17 10:12 ` Anand Gadiyar
@ 2011-03-17 14:36 ` Kevin Hilman
2011-03-18 23:43 ` Tony Lindgren
2 siblings, 1 reply; 7+ messages in thread
From: Kevin Hilman @ 2011-03-17 14:36 UTC (permalink / raw)
To: David Anders; +Cc: linux-omap, andy.green, tony
David Anders <x0132446@ti.com> writes:
> the pandaboard does not use the VUSIM or VAUX1 power regulators on the TWL6030
> and are left floating. if the VUSIM and VAUX1 power regulators are initilized,
> noise on the unloaded regulators generates an overcurrent interrupt causing the
> system to power down. this patch removes the initialization of the unused power
> regulators of VUSIM and VAUX1.
>
> Signed-off-by: David Anders <x0132446@ti.com>
Thanks for finding and fixing the root cause.
Tested-by: Kevin Hilman <khilman@ti.com>
Kevin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP4: PandaBoard: remove unused power regulators
2011-03-17 14:36 ` Kevin Hilman
@ 2011-03-18 23:43 ` Tony Lindgren
0 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2011-03-18 23:43 UTC (permalink / raw)
To: Kevin Hilman; +Cc: David Anders, linux-omap, andy.green
* Kevin Hilman <khilman@ti.com> [110317 07:34]:
> David Anders <x0132446@ti.com> writes:
>
> > the pandaboard does not use the VUSIM or VAUX1 power regulators on the TWL6030
> > and are left floating. if the VUSIM and VAUX1 power regulators are initilized,
> > noise on the unloaded regulators generates an overcurrent interrupt causing the
> > system to power down. this patch removes the initialization of the unused power
> > regulators of VUSIM and VAUX1.
> >
> > Signed-off-by: David Anders <x0132446@ti.com>
>
> Thanks for finding and fixing the root cause.
>
> Tested-by: Kevin Hilman <khilman@ti.com>
Applying into fixes.
Tony
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-03-18 23:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-15 19:10 [PATCH] OMAP4: PandaBoard: remove unused power regulators David Anders
2011-03-15 19:14 ` Andy Green
2011-03-16 9:19 ` Jean Pihet
2011-03-16 15:28 ` Jarkko Nikula
2011-03-17 10:12 ` Anand Gadiyar
2011-03-17 14:36 ` Kevin Hilman
2011-03-18 23:43 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).