Re: [PATCH 0/4] iommu: Prevent oops in iommu_get() and while arch_iommu is in use

[David Cohen <dacohen@gmail.com>]

On Fri, Mar 25, 2011 at 5:17 PM, Sakari Ailus
<sakari.ailus@maxwell.research.nokia.com> wrote:
> Hi,

Hi Sakari,

>
> [Resend: the patches were accidentally sent to linux-media instead.
> Apologies.]
>
> This patchset is aimed to fix a problem in arch_iommu implementation
> references. When an actual arch_iommu implementation is not loaded while
> iommu_get() is being called results to a kernel oops, as well as
> removing an arch_iommu implementation which is in use.
>
> This patchset fixes both issues.

Sounds nice.

>
> The patchset assumes the arch_iommu is uninstalled at module unload
> time. Is this an acceptable requirement?

I can't see a reason why this assumption could be wrong. In my point
of view it's acceptable. Let's see Hiroshi's.

Regards,

David Cohen

>
> Serialisation of the access to arch_iommu is done using mutex called
> arch_iommu_mutex.
>
> module_put() doesn't need to have the arch_iommu_mutex since when this
> gets called there won't be any users on the arch_iommu anyway.
>
> Comments are welcome. :-)
>
> Cheers,
>
> --
> Sakari Ailus
> sakari.ailus@maxwell.research.nokia.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html