Re: [PATCH] omap:usb: fixing ehci phy gpio values for omap3

["Menon, Nishanth" <nm-l0cyMroinI0@public.gmane.org>]

On Thu, Apr 21, 2011 at 09:22, Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org> wrote:
>
> From: Keshava Munegowda <Keshava_mgowda-l0cyMroinI0@public.gmane.org>
>
> The gpio of EHCI phy should be 0 instead of 1;
> This fixes the hub enumeration issue in beagle xm board.
>
> Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>

Dumb q1: Has this been tested on PandaBoard?
Dumb q2: is'nt it better to introduce polarity e.g.
pdata->ehci_data->reset_gpio_polarity etc? this will allow board files
to describe polarity of pin information to driver which can then be
Phy and any board specific mods(e.g. inverter on the line) independent
completely..

Regards,
Nishanth Menon

> ---
>  drivers/mfd/omap-usb-host.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index b3bb3ac..a12202e 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -718,14 +718,14 @@ static int usbhs_enable(struct device *dev)
>                        gpio_request(pdata->ehci_data->reset_gpio_port[0],
>                                                "USB1 PHY reset");
>                        gpio_direction_output
> -                               (pdata->ehci_data->reset_gpio_port[0], 1);
> +                               (pdata->ehci_data->reset_gpio_port[0], 0);
>                }
>
>                if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1])) {
>                        gpio_request(pdata->ehci_data->reset_gpio_port[1],
>                                                "USB2 PHY reset");
>                        gpio_direction_output
> -                               (pdata->ehci_data->reset_gpio_port[1], 1);
> +                               (pdata->ehci_data->reset_gpio_port[1], 0);
>                }
>
>                /* Hold the PHY in RESET for enough time till DIR is high */
> @@ -905,11 +905,11 @@ static int usbhs_enable(struct device *dev)
>
>                if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0]))
>                        gpio_set_value
> -                               (pdata->ehci_data->reset_gpio_port[0], 0);
> +                               (pdata->ehci_data->reset_gpio_port[0], 1);
>
>                if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1]))
>                        gpio_set_value
> -                               (pdata->ehci_data->reset_gpio_port[1], 0);
> +                               (pdata->ehci_data->reset_gpio_port[1], 1);
>        }
>
>  end_count:
> --
> 1.6.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html