From: "Gulati, Shweta" <shweta.gulati@ti.com>
To: Todd Poynor <toddpoynor@google.com>
Cc: linux-omap@vger.kernel.org, Nishanth Menon <nm@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3] OMAP3+: SR Layer Cleanup
Date: Thu, 12 May 2011 10:34:36 +0530 [thread overview]
Message-ID: <BANLkTi=m_0whpiWzq0tzuNsYhd40mqizFw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTin07ZkWwhMtqUEMhLtwugKNmhku9g@mail.gmail.com>
Hi,
On Wed, May 11, 2011 at 10:06 PM, Todd Poynor <toddpoynor@google.com> wrote:
> On Wed, May 11, 2011 at 2:12 AM, Shweta Gulati <shweta.gulati@ti.com> wrote:
> ...
>>
>> diff --git a/arch/arm/mach-omap2/sr_device.c
>> b/arch/arm/mach-omap2/sr_device.c
>> index 2782d3f..65b2aae 100644
>> --- a/arch/arm/mach-omap2/sr_device.c
>> +++ b/arch/arm/mach-omap2/sr_device.c
>> @@ -82,6 +82,7 @@ static int sr_dev_init(struct omap_hwmod *oh, void
>> *user)
>> struct omap_sr_data *sr_data;
>> struct omap_device *od;
>> struct omap_volt_data *volt_data;
>> + struct omap_sr_dev_attr *sr_dev_attr;
>> char *name = "smartreflex";
>> static int i;
>>
>> @@ -92,9 +93,11 @@ static int sr_dev_init(struct omap_hwmod *oh, void
>> *user)
>> return -ENOMEM;
>> }
>>
>> - if (!oh->vdd_name) {
>> + sr_dev_attr = (struct omap_sr_dev_attr *)oh->dev_attr;
>> + if (!sr_dev_attr->voltdm_name) {
>> pr_err("%s: No voltage domain specified for %s."
>
> Suggest if (!sr_dev_attr || !sr_dev_attr->voltdm_name) to catch this error.
Fair enough, Thanks for catching
NULL pointer shouldn't be deferenced.
>
>>
>> - "Cannot initialize\n", __func__, oh->name);
>> + "Cannot initialize\n", __func__,
>> + sr_dev_attr->voltdm_name);
>
> Should leave the hwmod's oh->name as the pr_err
> param, sr_dev_attr->voltdm_name has just been verified bogus.
Fair, will do.
> Todd
>
>
Thanks for reviewing.
--
Thanks,
Regards,
Shweta
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-12 5:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 9:12 [PATCH V3] OMAP3+: SR Layer Cleanup Shweta Gulati
2011-05-11 11:15 ` Menon, Nishanth
2011-05-12 9:50 ` Kevin Hilman
2011-05-12 12:48 ` Gulati, Shweta
2011-05-12 17:37 ` Menon, Nishanth
2011-05-11 16:36 ` Todd Poynor
2011-05-11 18:27 ` Todd Poynor
2011-05-12 5:04 ` Gulati, Shweta [this message]
2011-05-12 11:41 ` Cousson, Benoit
2011-05-12 12:49 ` Gulati, Shweta
2011-05-12 13:23 ` Gulati, Shweta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=m_0whpiWzq0tzuNsYhd40mqizFw@mail.gmail.com' \
--to=shweta.gulati@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).