From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gulati, Shweta" Subject: Re: [PATCH V2] OMAP2+: SR Layer Cleanup. Date: Tue, 10 May 2011 10:03:23 +0530 Message-ID: References: <1302243280-10891-1-git-send-email-shweta.gulati@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from na3sys009aog109.obsmtp.com ([74.125.149.201]:60627 "EHLO na3sys009aog109.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798Ab1EJEd0 convert rfc822-to-8bit (ORCPT ); Tue, 10 May 2011 00:33:26 -0400 Received: by bwg12 with SMTP id 12so5440747bwg.12 for ; Mon, 09 May 2011 21:33:23 -0700 (PDT) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Menon, Nishanth" Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi, On Tue, May 10, 2011 at 5:52 AM, Menon, Nishanth wrote: > might be a bit late, but seeing that Kevin has'nt picked this up yet, > a couple of cosmetic comments > I think it might be great if it could be folded into one of kevin's p= atches. > else, > $subject - OMAP3+ and could you drop the .? Will correct the Subject line > On Fri, Apr 8, 2011 at 01:14, Shweta Gulati wr= ote: >> As a part of Voltage Layer Cleanup Patches, >> submitted by Kevin Hilman, Voltage domain >> Information is removed from hwmod, >> So the patch removes 'vdd_name' info from omap_hwmod >> and adds that info into dev_attr as SR code uses vdd_name >> to get voltagedomain sructure info. > word wrap cleanup a bit, also please indicate the issue you see if th= e > patch is not applied. Would Rephrase the commit log. > Regards, > Nishanth Menon > > >> >> Tested on OMAP3630 SDP and OMAP4430 SDP Board >> >> Signed-off-by: Shweta Gulati > > > >> --- >> =A0V2: >> =A0Rebased on latest 'pm-wip/voltdm_a' branch. >> >> =A0arch/arm/mach-omap2/omap_hwmod_3xxx_data.c =A0 | =A0 17 +++++++++= ++++---- >> =A0arch/arm/mach-omap2/omap_hwmod_44xx_data.c =A0 | =A0 19 +++++++++= +++++++--- >> =A0arch/arm/mach-omap2/smartreflex.h =A0 =A0 =A0 =A0 =A0 =A0| =A0 10= ++++++++++ >> =A0arch/arm/mach-omap2/sr_device.c =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 = 11 +++++++---- >> =A0arch/arm/plat-omap/include/plat/omap_hwmod.h | =A0 =A01 - >> =A05 files changed, 46 insertions(+), 12 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/m= ach-omap2/omap_hwmod_3xxx_data.c >> index 3cd91ac..6a704bd 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >> @@ -29,6 +29,7 @@ >> >> =A0#include "omap_hwmod_common_data.h" >> >> +#include "smartreflex.h" >> =A0#include "prm-regbits-34xx.h" >> =A0#include "cm-regbits-34xx.h" >> =A0#include "wd_timer.h" >> @@ -2904,6 +2905,10 @@ static struct omap_hwmod_class omap36xx_smart= reflex_hwmod_class =3D { >> =A0}; >> >> =A0/* SR1 */ >> +static struct omap_sr_dev_attr sr1_dev_attr =3D { >> + =A0 =A0 =A0 .voltdm_name =A0 =3D "mpu_iva", >> +}; >> + >> =A0static struct omap_hwmod_ocp_if *omap3_sr1_slaves[] =3D { >> =A0 =A0 =A0 =A0&omap3_l4_core__sr1, >> =A0}; >> @@ -2912,7 +2917,6 @@ static struct omap_hwmod omap34xx_sr1_hwmod =3D= { >> =A0 =A0 =A0 =A0.name =A0 =A0 =A0 =A0 =A0 =3D "sr1_hwmod", >> =A0 =A0 =A0 =A0.class =A0 =A0 =A0 =A0 =A0=3D &omap34xx_smartreflex_h= wmod_class, >> =A0 =A0 =A0 =A0.main_clk =A0 =A0 =A0 =3D "sr1_fck", >> - =A0 =A0 =A0 .vdd_name =A0 =A0 =A0 =3D "mpu_iva", >> =A0 =A0 =A0 =A0.prcm =A0 =A0 =A0 =A0 =A0 =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.omap2 =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.prcm_reg_id =3D 1, >> @@ -2924,6 +2928,7 @@ static struct omap_hwmod omap34xx_sr1_hwmod =3D= { >> =A0 =A0 =A0 =A0}, >> =A0 =A0 =A0 =A0.slaves =A0 =A0 =A0 =A0 =3D omap3_sr1_slaves, >> =A0 =A0 =A0 =A0.slaves_cnt =A0 =A0 =3D ARRAY_SIZE(omap3_sr1_slaves), >> + =A0 =A0 =A0 .dev_attr =A0 =A0 =A0 =3D &sr1_dev_attr, >> =A0 =A0 =A0 =A0.omap_chip =A0 =A0 =A0=3D OMAP_CHIP_INIT(CHIP_IS_OMAP= 3430ES2 | >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0CHIP_IS_OMAP3430ES3_0 | >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0CHIP_IS_OMAP3430ES3_1), >> @@ -2934,7 +2939,6 @@ static struct omap_hwmod omap36xx_sr1_hwmod =3D= { >> =A0 =A0 =A0 =A0.name =A0 =A0 =A0 =A0 =A0 =3D "sr1_hwmod", >> =A0 =A0 =A0 =A0.class =A0 =A0 =A0 =A0 =A0=3D &omap36xx_smartreflex_h= wmod_class, >> =A0 =A0 =A0 =A0.main_clk =A0 =A0 =A0 =3D "sr1_fck", >> - =A0 =A0 =A0 .vdd_name =A0 =A0 =A0 =3D "mpu_iva", >> =A0 =A0 =A0 =A0.prcm =A0 =A0 =A0 =A0 =A0 =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.omap2 =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.prcm_reg_id =3D 1, >> @@ -2946,10 +2950,15 @@ static struct omap_hwmod omap36xx_sr1_hwmod = =3D { >> =A0 =A0 =A0 =A0}, >> =A0 =A0 =A0 =A0.slaves =A0 =A0 =A0 =A0 =3D omap3_sr1_slaves, >> =A0 =A0 =A0 =A0.slaves_cnt =A0 =A0 =3D ARRAY_SIZE(omap3_sr1_slaves), >> + =A0 =A0 =A0 .dev_attr =A0 =A0 =A0 =3D &sr1_dev_attr, >> =A0 =A0 =A0 =A0.omap_chip =A0 =A0 =A0=3D OMAP_CHIP_INIT(CHIP_IS_OMAP= 3630ES1), >> =A0}; >> >> =A0/* SR2 */ >> +static struct omap_sr_dev_attr sr2_dev_attr =3D { >> + =A0 =A0 =A0 .voltdm_name =A0 =A0=3D "core", >> +}; >> + >> =A0static struct omap_hwmod_ocp_if *omap3_sr2_slaves[] =3D { >> =A0 =A0 =A0 =A0&omap3_l4_core__sr2, >> =A0}; >> @@ -2958,7 +2967,6 @@ static struct omap_hwmod omap34xx_sr2_hwmod =3D= { >> =A0 =A0 =A0 =A0.name =A0 =A0 =A0 =A0 =A0 =3D "sr2_hwmod", >> =A0 =A0 =A0 =A0.class =A0 =A0 =A0 =A0 =A0=3D &omap34xx_smartreflex_h= wmod_class, >> =A0 =A0 =A0 =A0.main_clk =A0 =A0 =A0 =3D "sr2_fck", >> - =A0 =A0 =A0 .vdd_name =A0 =A0 =A0 =3D "core", >> =A0 =A0 =A0 =A0.prcm =A0 =A0 =A0 =A0 =A0 =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.omap2 =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.prcm_reg_id =3D 1, >> @@ -2970,6 +2978,7 @@ static struct omap_hwmod omap34xx_sr2_hwmod =3D= { >> =A0 =A0 =A0 =A0}, >> =A0 =A0 =A0 =A0.slaves =A0 =A0 =A0 =A0 =3D omap3_sr2_slaves, >> =A0 =A0 =A0 =A0.slaves_cnt =A0 =A0 =3D ARRAY_SIZE(omap3_sr2_slaves), >> + =A0 =A0 =A0 .dev_attr =A0 =A0 =A0 =3D &sr2_dev_attr, >> =A0 =A0 =A0 =A0.omap_chip =A0 =A0 =A0=3D OMAP_CHIP_INIT(CHIP_IS_OMAP= 3430ES2 | >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0CHIP_IS_OMAP3430ES3_0 | >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0CHIP_IS_OMAP3430ES3_1), >> @@ -2980,7 +2989,6 @@ static struct omap_hwmod omap36xx_sr2_hwmod =3D= { >> =A0 =A0 =A0 =A0.name =A0 =A0 =A0 =A0 =A0 =3D "sr2_hwmod", >> =A0 =A0 =A0 =A0.class =A0 =A0 =A0 =A0 =A0=3D &omap36xx_smartreflex_h= wmod_class, >> =A0 =A0 =A0 =A0.main_clk =A0 =A0 =A0 =3D "sr2_fck", >> - =A0 =A0 =A0 .vdd_name =A0 =A0 =A0 =3D "core", >> =A0 =A0 =A0 =A0.prcm =A0 =A0 =A0 =A0 =A0 =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.omap2 =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.prcm_reg_id =3D 1, >> @@ -2992,6 +3000,7 @@ static struct omap_hwmod omap36xx_sr2_hwmod =3D= { >> =A0 =A0 =A0 =A0}, >> =A0 =A0 =A0 =A0.slaves =A0 =A0 =A0 =A0 =3D omap3_sr2_slaves, >> =A0 =A0 =A0 =A0.slaves_cnt =A0 =A0 =3D ARRAY_SIZE(omap3_sr2_slaves), >> + =A0 =A0 =A0 .dev_attr =A0 =A0 =A0 =3D &sr2_dev_attr, >> =A0 =A0 =A0 =A0.omap_chip =A0 =A0 =A0=3D OMAP_CHIP_INIT(CHIP_IS_OMAP= 3630ES1), >> =A0}; >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/m= ach-omap2/omap_hwmod_44xx_data.c >> index 3e88dd3..1331b39 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >> @@ -30,6 +30,7 @@ >> >> =A0#include "omap_hwmod_common_data.h" >> >> +#include "smartreflex.h" >> =A0#include "cm1_44xx.h" >> =A0#include "cm2_44xx.h" >> =A0#include "prm44xx.h" >> @@ -3775,6 +3776,10 @@ static struct omap_hwmod_class omap44xx_smart= reflex_hwmod_class =3D { >> =A0}; >> >> =A0/* smartreflex_core */ >> +static struct omap_sr_dev_attr sr_core_dev_attr =3D { >> + =A0 =A0 =A0 .voltdm_name =A0 =3D "core", >> +}; >> + >> =A0static struct omap_hwmod omap44xx_smartreflex_core_hwmod; >> =A0static struct omap_hwmod_irq_info omap44xx_smartreflex_core_irqs[= ] =3D { >> =A0 =A0 =A0 =A0{ .irq =3D 19 + OMAP44XX_IRQ_GIC_START }, >> @@ -3809,7 +3814,6 @@ static struct omap_hwmod omap44xx_smartreflex_= core_hwmod =3D { >> =A0 =A0 =A0 =A0.mpu_irqs =A0 =A0 =A0 =3D omap44xx_smartreflex_core_i= rqs, >> =A0 =A0 =A0 =A0.mpu_irqs_cnt =A0 =3D ARRAY_SIZE(omap44xx_smartreflex= _core_irqs), >> =A0 =A0 =A0 =A0.main_clk =A0 =A0 =A0 =3D "smartreflex_core_fck", >> - =A0 =A0 =A0 .vdd_name =A0 =A0 =A0 =3D "core", >> =A0 =A0 =A0 =A0.prcm =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.omap4 =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.clkctrl_reg =3D OMAP= 4430_CM_ALWON_SR_CORE_CLKCTRL, >> @@ -3817,10 +3821,15 @@ static struct omap_hwmod omap44xx_smartrefle= x_core_hwmod =3D { >> =A0 =A0 =A0 =A0}, >> =A0 =A0 =A0 =A0.slaves =A0 =A0 =A0 =A0 =3D omap44xx_smartreflex_core= _slaves, >> =A0 =A0 =A0 =A0.slaves_cnt =A0 =A0 =3D ARRAY_SIZE(omap44xx_smartrefl= ex_core_slaves), >> + =A0 =A0 =A0 .dev_attr =A0 =A0 =A0 =3D &sr_core_dev_attr, >> =A0 =A0 =A0 =A0.omap_chip =A0 =A0 =A0=3D OMAP_CHIP_INIT(CHIP_IS_OMAP= 4430), >> =A0}; >> >> =A0/* smartreflex_iva */ >> +static struct omap_sr_dev_attr sr_iva_dev_attr =3D { >> + =A0 =A0 =A0 .voltdm_name =A0 =3D "iva", >> +}; >> + >> =A0static struct omap_hwmod omap44xx_smartreflex_iva_hwmod; >> =A0static struct omap_hwmod_irq_info omap44xx_smartreflex_iva_irqs[]= =3D { >> =A0 =A0 =A0 =A0{ .irq =3D 102 + OMAP44XX_IRQ_GIC_START }, >> @@ -3855,7 +3864,6 @@ static struct omap_hwmod omap44xx_smartreflex_= iva_hwmod =3D { >> =A0 =A0 =A0 =A0.mpu_irqs =A0 =A0 =A0 =3D omap44xx_smartreflex_iva_ir= qs, >> =A0 =A0 =A0 =A0.mpu_irqs_cnt =A0 =3D ARRAY_SIZE(omap44xx_smartreflex= _iva_irqs), >> =A0 =A0 =A0 =A0.main_clk =A0 =A0 =A0 =3D "smartreflex_iva_fck", >> - =A0 =A0 =A0 .vdd_name =A0 =A0 =A0 =3D "iva", >> =A0 =A0 =A0 =A0.prcm =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.omap4 =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.clkctrl_reg =3D OMAP= 4430_CM_ALWON_SR_IVA_CLKCTRL, >> @@ -3863,10 +3871,15 @@ static struct omap_hwmod omap44xx_smartrefle= x_iva_hwmod =3D { >> =A0 =A0 =A0 =A0}, >> =A0 =A0 =A0 =A0.slaves =A0 =A0 =A0 =A0 =3D omap44xx_smartreflex_iva_= slaves, >> =A0 =A0 =A0 =A0.slaves_cnt =A0 =A0 =3D ARRAY_SIZE(omap44xx_smartrefl= ex_iva_slaves), >> + =A0 =A0 =A0 .dev_attr =A0 =A0 =A0 =3D &sr_iva_dev_attr, >> =A0 =A0 =A0 =A0.omap_chip =A0 =A0 =A0=3D OMAP_CHIP_INIT(CHIP_IS_OMAP= 4430), >> =A0}; >> >> =A0/* smartreflex_mpu */ >> +static struct omap_sr_dev_attr sr_mpu_dev_attr =3D { >> + =A0 =A0 =A0 .voltdm_name =A0 =3D "mpu", >> +}; >> + >> =A0static struct omap_hwmod omap44xx_smartreflex_mpu_hwmod; >> =A0static struct omap_hwmod_irq_info omap44xx_smartreflex_mpu_irqs[]= =3D { >> =A0 =A0 =A0 =A0{ .irq =3D 18 + OMAP44XX_IRQ_GIC_START }, >> @@ -3901,7 +3914,6 @@ static struct omap_hwmod omap44xx_smartreflex_= mpu_hwmod =3D { >> =A0 =A0 =A0 =A0.mpu_irqs =A0 =A0 =A0 =3D omap44xx_smartreflex_mpu_ir= qs, >> =A0 =A0 =A0 =A0.mpu_irqs_cnt =A0 =3D ARRAY_SIZE(omap44xx_smartreflex= _mpu_irqs), >> =A0 =A0 =A0 =A0.main_clk =A0 =A0 =A0 =3D "smartreflex_mpu_fck", >> - =A0 =A0 =A0 .vdd_name =A0 =A0 =A0 =3D "mpu", >> =A0 =A0 =A0 =A0.prcm =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.omap4 =3D { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.clkctrl_reg =3D OMAP= 4430_CM_ALWON_SR_MPU_CLKCTRL, >> @@ -3909,6 +3921,7 @@ static struct omap_hwmod omap44xx_smartreflex_= mpu_hwmod =3D { >> =A0 =A0 =A0 =A0}, >> =A0 =A0 =A0 =A0.slaves =A0 =A0 =A0 =A0 =3D omap44xx_smartreflex_mpu_= slaves, >> =A0 =A0 =A0 =A0.slaves_cnt =A0 =A0 =3D ARRAY_SIZE(omap44xx_smartrefl= ex_mpu_slaves), >> + =A0 =A0 =A0 .dev_attr =A0 =A0 =A0 =3D &sr_mpu_dev_attr, >> =A0 =A0 =A0 =A0.omap_chip =A0 =A0 =A0=3D OMAP_CHIP_INIT(CHIP_IS_OMAP= 4430), >> =A0}; >> >> diff --git a/arch/arm/mach-omap2/smartreflex.h b/arch/arm/mach-omap2= /smartreflex.h >> index 5f35b9e..9a7f770 100644 >> --- a/arch/arm/mach-omap2/smartreflex.h >> +++ b/arch/arm/mach-omap2/smartreflex.h >> @@ -197,6 +197,16 @@ struct omap_sr_nvalue_table { >> =A0}; >> >> =A0/** >> + * struct omap_sr_dev_attr - Smartreflex Device attribute. >> + * >> + * @voltdm_name: =A0 =A0 =A0 Name of voltdomain of SR instance >> + */ >> + >> +struct omap_sr_dev_attr { >> + =A0 =A0 =A0 const char =A0 =A0 =A0*voltdm_name; >> +}; >> + >> +/** >> =A0* struct omap_sr_data - Smartreflex platform data. >> =A0* >> =A0* @ip_type: =A0 =A0 =A0 =A0 =A0 Smartreflex IP type. >> diff --git a/arch/arm/mach-omap2/sr_device.c b/arch/arm/mach-omap2/s= r_device.c >> index 2782d3f..65b2aae 100644 >> --- a/arch/arm/mach-omap2/sr_device.c >> +++ b/arch/arm/mach-omap2/sr_device.c >> @@ -82,6 +82,7 @@ static int sr_dev_init(struct omap_hwmod *oh, void= *user) >> =A0 =A0 =A0 =A0struct omap_sr_data *sr_data; >> =A0 =A0 =A0 =A0struct omap_device *od; >> =A0 =A0 =A0 =A0struct omap_volt_data *volt_data; >> + =A0 =A0 =A0 struct omap_sr_dev_attr *sr_dev_attr; >> =A0 =A0 =A0 =A0char *name =3D "smartreflex"; >> =A0 =A0 =A0 =A0static int i; >> >> @@ -92,9 +93,11 @@ static int sr_dev_init(struct omap_hwmod *oh, voi= d *user) >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return -ENOMEM; >> =A0 =A0 =A0 =A0} >> >> - =A0 =A0 =A0 if (!oh->vdd_name) { >> + =A0 =A0 =A0 sr_dev_attr =3D (struct omap_sr_dev_attr *)oh->dev_att= r; >> + =A0 =A0 =A0 if (!sr_dev_attr->voltdm_name) { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0pr_err("%s: No voltage domain specifi= ed for %s." >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "Cannot initialize\n",= __func__, oh->name); >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "Canno= t initialize\n", __func__, >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 sr_dev_attr->voltdm_name); >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto exit; >> =A0 =A0 =A0 =A0} >> >> @@ -102,10 +105,10 @@ static int sr_dev_init(struct omap_hwmod *oh, = void *user) >> =A0 =A0 =A0 =A0sr_data->senn_mod =3D 0x1; >> =A0 =A0 =A0 =A0sr_data->senp_mod =3D 0x1; >> >> - =A0 =A0 =A0 sr_data->voltdm =3D voltdm_lookup(oh->vdd_name); >> + =A0 =A0 =A0 sr_data->voltdm =3D voltdm_lookup(sr_dev_attr->voltdm_= name); >> =A0 =A0 =A0 =A0if (IS_ERR(sr_data->voltdm)) { >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0pr_err("%s: Unable to get voltage dom= ain pointer for VDD %s\n", >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 __func__, oh->vdd_name= ); >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 __func__, sr_dev_attr-= >voltdm_name); >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0goto exit; >> =A0 =A0 =A0 =A0} >> >> diff --git a/arch/arm/plat-omap/include/plat/omap_hwmod.h b/arch/arm= /plat-omap/include/plat/omap_hwmod.h >> index a5fa7c1..39d809a 100644 >> --- a/arch/arm/plat-omap/include/plat/omap_hwmod.h >> +++ b/arch/arm/plat-omap/include/plat/omap_hwmod.h >> @@ -519,7 +519,6 @@ struct omap_hwmod { >> =A0 =A0 =A0 =A0const char =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= *main_clk; >> =A0 =A0 =A0 =A0struct clk =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= *_clk; >> =A0 =A0 =A0 =A0struct omap_hwmod_opt_clk =A0 =A0 =A0 *opt_clks; >> - =A0 =A0 =A0 char =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0*vdd_name; >> =A0 =A0 =A0 =A0struct omap_hwmod_ocp_if =A0 =A0 =A0 =A0**masters; /*= connect to *_IA */ >> =A0 =A0 =A0 =A0struct omap_hwmod_ocp_if =A0 =A0 =A0 =A0**slaves; =A0= /* connect to *_TA */ >> =A0 =A0 =A0 =A0void =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0*dev_attr; >> -- >> 1.7.0.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap= " in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at =A0http://vger.kernel.org/majordomo-info.html >> > --=20 Thanks, Regards, Shweta -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html