From: "Menon, Nishanth" <nm@ti.com>
To: Kevin Hilman <khilman@ti.com>
Cc: Sanjeev Premi <premi@ti.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap:pm: Fix boot-time errors with debugfs disabled
Date: Wed, 18 May 2011 13:48:51 -0500 [thread overview]
Message-ID: <BANLkTikZaNpp-3TM732zXo2ASQR_Wq5yFA@mail.gmail.com> (raw)
In-Reply-To: <87fwocrmr9.fsf@ti.com>
On Wed, May 18, 2011 at 11:34, Kevin Hilman <khilman@ti.com> wrote:
> Basically, I'm in the process of a pretty major cleanup of the VC/VP and
> SR layers. For example, in my pm-wip/voltdm_* branches, the debugfs
> interface to the voltage layer has been completely removed. I'm also
> thinking of removing the SR debugfs interface also, as I don't really
> think we need a userspace interface for this. A board-level interface
> is probably enough (/me waits for flame from Nishanth :)
/me obliges with my 2cents ;) :
on board level interface - yes - we should have it.
on plugging out userspace: This is too risky an approach - having a
mechanism to control SR from userspace is critical - yes folks can do
a regwrite over /dev/mem to plug it out, but with multiple SR classes,
it hardly ever going to be right. further, SR is a touchy beast to bad
clk and system configurations - if we view debugfs as what it was
meant to be: debug interface, SR deserves it. I agree that asking for
userspace to have a sysfs is not worth it if board level interface has
it. (and adding custom patches for every board developer out there...
well.. it is not really worth the pain).
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-18 18:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 17:36 [PATCH] omap:pm: Fix boot-time errors with debugfs disabled Sanjeev Premi
2011-05-12 18:02 ` Menon, Nishanth
2011-05-12 19:16 ` Premi, Sanjeev
2011-05-12 19:58 ` Todd Poynor
2011-05-12 21:03 ` Nishanth Menon
2011-05-13 12:48 ` Premi, Sanjeev
2011-05-17 14:40 ` Premi, Sanjeev
2011-05-18 8:25 ` Menon, Nishanth
2011-05-18 9:00 ` Premi, Sanjeev
2011-05-18 9:06 ` Menon, Nishanth
2011-05-18 9:16 ` Premi, Sanjeev
2011-05-18 16:34 ` Kevin Hilman
2011-05-18 18:48 ` Menon, Nishanth [this message]
2011-05-19 10:30 ` Premi, Sanjeev
2011-05-19 13:58 ` Menon, Nishanth
2011-05-20 15:21 ` Premi, Sanjeev
2011-05-24 23:57 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikZaNpp-3TM732zXo2ASQR_Wq5yFA@mail.gmail.com \
--to=nm@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).