Re: [RFC PATCH 07/10] OMAP: GPIO: cleanup suspend and resume functions

["Varadarajan, Charulatha" <charu@ti.com>]

Tarun,

On Mon, May 16, 2011 at 17:11, Tarun Kanti DebBarma <tarun.kanti@ti.com> wrote:
> Since wake_status, wake_clear, wake_set is common for all banks on a given
> OMAP version it is enough to get their values once during probe().
> Also, register offsets are already initialzed according to OMAP versions
> during device registration. We no longer need these explicit checks.
>
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
> Cc: Charulatha V <charu@ti.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Kevin Hilman <khilman@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> ---
>  arch/arm/mach-omap1/gpio16xx.c         |    3 +
>  arch/arm/mach-omap2/gpio.c             |    6 +++
>  arch/arm/plat-omap/gpio.c              |   78 +++++++------------------------
>  arch/arm/plat-omap/include/plat/gpio.h |    3 +
>  4 files changed, 30 insertions(+), 60 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/gpio16xx.c b/arch/arm/mach-omap1/gpio16xx.c
> index d886b88..bc4cc8f 100644
> --- a/arch/arm/mach-omap1/gpio16xx.c
> +++ b/arch/arm/mach-omap1/gpio16xx.c
> @@ -46,6 +46,9 @@ static struct omap_gpio_reg_offs omap16xx_mpuio_regs = {
>        .irqenable      = OMAP_MPUIO_GPIO_MASKIT,
>        .irqenable_inv  = true,
>        .ctrl           = USHRT_MAX,
> +       .wkupstatus     = OMAP1610_GPIO_WAKEUPENABLE,
> +       .wkupclear      = OMAP1610_GPIO_CLEAR_WAKEUPENA,
> +       .wkupset        = OMAP1610_GPIO_SET_WAKEUPENA,

This should have been added for omap16xx_gpio_regs and not for
omap16xx_mpuio_regs.

-V Charulatha

>  };
>
>  static struct __initdata omap_gpio_platform_data omap16xx_mpu_gpio_config = {

[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html