Re: [PATCH V4] OMAP3+: SR Layer Cleanup

["Gulati, Shweta" <shweta.gulati@ti.com>]

Hi,

On Tue, May 24, 2011 at 5:22 PM, Cousson, Benoit <b-cousson@ti.com> wrote:
> On 5/23/2011 6:40 AM, Gulati, Shweta wrote:
>>
>> Benoit,
>>
>> On Fri, May 20, 2011 at 7:19 PM, Cousson, Benoit<b-cousson@ti.com>  wrote:
>>>
>>> Hi Shweta,
>>>
>>> On 5/13/2011 8:27 AM, Gulati, Shweta wrote:
>>>>
>>>> To set sr ntarget values  for all volt_domain,
>>>> volt_table is retrieved by doing a look_up of 'vdd_name'
>>>> field from omap_hwmod but voltage domain pointer does not
>>>> belong to omap_hwmod and is not used anywhere else.
>>>> As a part of voltage layer and SR Layer clean up volt
>>>> pointer is removed from omap_hwmod and added in dev
>>>> attributes of SR.
>>>>
>>>> Tested on OMAP3630 SDP and OMAP4430 SDP Board
>>>>
>>>> Signed-off-by: Shweta Gulati<shweta.gulati@ti.com>
>>>> Acked by: Nishanth Menon<nm@ti.com>
>>>> Cc: Benoit Cousson<b-cousson@ti.com>
>>>> Cc: Paul Walmsley<paul@pwsan.com>
>>>> ---
>>>>
>>>> V4:
>>>>   Fixed comments like checking for NULL pointers
>>>>   and following conventions in naming the instances
>>>>   recommended by Todd Poynor and Benoit Cousson.
>>>
>>> It looks like you missed at least two comments I did on the previous
>>> version
>>> whereas you did agree to fix them.
>>
>> You told me to move smartrefex_xxxx_dev_attr above
>> omap44xx_smartreflex_XXX_hwmod struct,
>
> Just before the struct which is not the case.
Ok will do , just above that struct.
>> which is already in that order and the other thing you suggested was
>> to move .dev_attr before .slaves,
>> that I have not done explaining that, to follow the standard as in all
>> defined hwmod struct .dev_attr are placed after .slaves.
>
> Could you give some example in the OMAP4 data file?
Benoit, I checked in  OMAP3 data file, So it that in OMAP3 and OMAP4 data file
the order should be different, what do you suggest?
> In the generic form, you should have opt_clk attribute then dev_attr then
> .slaves.
>
> Anyway, do not say you will fix something if you decide not to fix them
> after. Or in case of valid concern, please provide some explanation in the
> cover letter.
Benoit, I did send a mail asking for this concern earlier too, Anyways we can
decide order for OMAP3 and OMAP 4data files and I would change that in V5.

Thanks.
>
> Regards,
> Benoit
>
>



-- 
Thanks,
Regards,
Shweta
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html