From: "Menon, Nishanth" <nm@ti.com>
To: Todd Poynor <toddpoynor@google.com>
Cc: linux-omap <linux-omap@vger.kernel.org>, Kevin <khilman@ti.com>
Subject: Re: [PM-WIP_CPUFREQ][PATCH V3 5/8] OMAP2+: cpufreq: fix invalid cpufreq table with central alloc/free
Date: Wed, 25 May 2011 18:21:18 -0700 [thread overview]
Message-ID: <BANLkTinHv4iOiOA5KP0S1D8CvWMtSn67Cw@mail.gmail.com> (raw)
In-Reply-To: <20110526010904.GB21212@google.com>
On Wed, May 25, 2011 at 18:09, Todd Poynor <toddpoynor@google.com> wrote:
>> + if (result || !freq_table) {
>> + dev_err(mpu_dev, "%s: cpu%d: unable to get freq table [%d]\n",
>> + __func__, policy->cpu, result);
>> + return result;
>
> The "|| !freq_table" isn't needed, and technically allows the code to
> return zero for an error return if the subexpression does evaluate
> true.
>
Ack..
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-26 1:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 23:38 [PM-WIP_CPUFREQ][PATCH 0/6 V3] Cleanups for cpufreq Nishanth Menon
2011-05-25 23:38 ` [PM-WIP_CPUFREQ][PATCH V3 1/8] OMAP2+: cpufreq: move clk name decision to init Nishanth Menon
2011-05-26 17:33 ` Kevin Hilman
2011-05-25 23:38 ` [PM-WIP_CPUFREQ][PATCH V3 2/8] OMAP2+: cpufreq: deny initialization if no mpudev Nishanth Menon
2011-05-26 17:34 ` Kevin Hilman
2011-05-25 23:38 ` [PM-WIP_CPUFREQ][PATCH V3 3/8] OMAP2+: cpufreq: use opp/clk_*cpufreq_table based on silicon Nishanth Menon
2011-05-26 17:38 ` Kevin Hilman
2011-05-26 18:35 ` Menon, Nishanth
2011-05-26 18:39 ` Menon, Nishanth
2011-05-26 20:25 ` Kevin Hilman
2011-05-25 23:38 ` [PM-WIP_CPUFREQ][PATCH V3 4/8] OMAP2+: cpufreq: dont support !freq_table Nishanth Menon
2011-05-26 0:51 ` Todd Poynor
2011-05-26 0:53 ` Menon, Nishanth
[not found] ` <SNT104-W336E0DDFB034FA635C328BBA770@phx.gbl>
2011-05-26 1:03 ` Menon, Nishanth
2011-05-25 23:38 ` [PM-WIP_CPUFREQ][PATCH V3 5/8] OMAP2+: cpufreq: fix invalid cpufreq table with central alloc/free Nishanth Menon
2011-05-26 1:09 ` Todd Poynor
2011-05-26 1:21 ` Menon, Nishanth [this message]
2011-05-25 23:38 ` [PM-WIP_CPUFREQ][PATCH V3 6/8] OMAP2+: cpufreq: fix freq_table leak Nishanth Menon
2011-05-26 0:16 ` Kevin Hilman
2011-05-26 0:47 ` Menon, Nishanth
2011-05-26 17:11 ` Kevin Hilman
2011-05-26 18:34 ` Menon, Nishanth
2011-05-26 1:25 ` Todd Poynor
2011-05-26 1:36 ` Menon, Nishanth
2011-05-25 23:38 ` [PM-WIP_CPUFREQ][PATCH V3 7/8] OMAP2+: cpufreq: put clk if cpu_init failed Nishanth Menon
2011-05-25 23:38 ` [PM-WIP_CPUFREQ][PATCH V3 8/8] OMAP: cpufreq: minor file header updates Nishanth Menon
2011-05-26 0:18 ` Kevin Hilman
2011-05-26 0:48 ` Menon, Nishanth
2011-05-26 18:15 ` Kevin Hilman
2011-05-26 18:10 ` [PM-WIP_CPUFREQ][PATCH 0/6 V3] Cleanups for cpufreq Kevin Hilman
2011-05-26 18:36 ` Menon, Nishanth
2011-05-27 5:06 ` Santosh Shilimkar
2011-05-27 6:07 ` Menon, Nishanth
2011-05-27 6:26 ` Santosh Shilimkar
2011-05-27 15:33 ` Turquette, Mike
2011-05-27 23:27 ` Kevin Hilman
2011-05-29 17:25 ` Menon, Nishanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinHv4iOiOA5KP0S1D8CvWMtSn67Cw@mail.gmail.com \
--to=nm@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).