Re: [RFC][PATCH 10/9] OMAP4: HWMOD: differentiate 4430 and 4460 bandgap

["Menon, Nishanth" <nm@ti.com>]

On Wed, May 25, 2011 at 20:46, Pandita, Vikram <vikram.pandita@ti.com> wrote:
> On Wed, May 25, 2011 at 8:41 PM, Nishanth Menon <nm@ti.com> wrote:
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> <snip>
>> +static struct omap_hwmod_opt_clk bandgap446x_opt_clks[] = {
>> +       { .role = "fclk", .clk = "bandgap_ts_fclk" },
>> +};
>> +
>> +static struct omap_hwmod omap446x_bandgap_hwmod = {
>> +       .name           = "bandgap",
>> +       .class          = &omap44xx_bandgap_hwmod_class,
>> +       .prcm           = {
>> +               .omap4 = {
>> +                       .clkctrl_reg = OMAP4430_CM_WKUP_BANDGAP_CLKCTRL,
>> +               },
>> +       },
>> +       .opt_clks       = bandgap446x_opt_clks,
>> +       .opt_clks_cnt   = ARRAY_SIZE(bandgap446x_opt_clks),
>> +       .omap_chip      = OMAP_CHIP_INIT(CHIP_IS_OMAP4460),
>
> Does it call for having CHIP_IS_OMAP446X instead of CHIP_IS_OMAP4460 ?
>
> What happens when we get say es2.0 for 4460? how do you accommodate that?
> Take care of that case when the new silicon arrives or fix it now :-)

Probably Paul/Benoit can state their preference.

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html