* [PATCH] media: omap3isp: fix format string warning
@ 2011-05-29 7:04 Ohad Ben-Cohen
2011-05-30 14:57 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Ohad Ben-Cohen @ 2011-05-29 7:04 UTC (permalink / raw)
To: linux-media; +Cc: laurent.pinchart, linux-omap, Ohad Ben-Cohen
Trivially fix this:
drivers/media/video/omap3isp/isp.c: In function 'isp_isr_dbg':
drivers/media/video/omap3isp/isp.c:394: warning: zero-length gnu_printf format string
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
---
drivers/media/video/omap3isp/isp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/omap3isp/isp.c b/drivers/media/video/omap3isp/isp.c
index 472a693..a0d5e69 100644
--- a/drivers/media/video/omap3isp/isp.c
+++ b/drivers/media/video/omap3isp/isp.c
@@ -391,7 +391,7 @@ static inline void isp_isr_dbg(struct isp_device *isp, u32 irqstatus)
};
int i;
- dev_dbg(isp->dev, "");
+ dev_dbg(isp->dev, "%s\n", __func__);
for (i = 0; i < ARRAY_SIZE(name); i++) {
if ((1 << i) & irqstatus)
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: omap3isp: fix format string warning
2011-05-29 7:04 [PATCH] media: omap3isp: fix format string warning Ohad Ben-Cohen
@ 2011-05-30 14:57 ` Laurent Pinchart
2011-05-30 15:05 ` Ohad Ben-Cohen
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2011-05-30 14:57 UTC (permalink / raw)
To: Ohad Ben-Cohen; +Cc: linux-media, linux-omap
Hi Ohad,
On Sunday 29 May 2011 09:04:51 Ohad Ben-Cohen wrote:
> Trivially fix this:
>
> drivers/media/video/omap3isp/isp.c: In function 'isp_isr_dbg':
> drivers/media/video/omap3isp/isp.c:394: warning: zero-length gnu_printf
> format string
Thanks for the patch, but I've already applied something similar to my tree.
Sorry :-)
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> ---
> drivers/media/video/omap3isp/isp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/omap3isp/isp.c
> b/drivers/media/video/omap3isp/isp.c index 472a693..a0d5e69 100644
> --- a/drivers/media/video/omap3isp/isp.c
> +++ b/drivers/media/video/omap3isp/isp.c
> @@ -391,7 +391,7 @@ static inline void isp_isr_dbg(struct isp_device *isp,
> u32 irqstatus) };
> int i;
>
> - dev_dbg(isp->dev, "");
> + dev_dbg(isp->dev, "%s\n", __func__);
>
> for (i = 0; i < ARRAY_SIZE(name); i++) {
> if ((1 << i) & irqstatus)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: omap3isp: fix format string warning
2011-05-30 14:57 ` Laurent Pinchart
@ 2011-05-30 15:05 ` Ohad Ben-Cohen
0 siblings, 0 replies; 3+ messages in thread
From: Ohad Ben-Cohen @ 2011-05-30 15:05 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, linux-omap
On Mon, May 30, 2011 at 5:57 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Thanks for the patch, but I've already applied something similar to my tree.
> Sorry :-)
np, thanks. I'm just playing with omap3isp a bit and wanted to get rid
of that "hey what did I do wrong this time" feeling every time I
recompiled it :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-30 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-29 7:04 [PATCH] media: omap3isp: fix format string warning Ohad Ben-Cohen
2011-05-30 14:57 ` Laurent Pinchart
2011-05-30 15:05 ` Ohad Ben-Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).