linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] nand: Renaming, moving and fixing NAND and ELM drivers
@ 2014-09-11 13:47 Ezequiel Garcia
  2014-09-11 13:47 ` [PATCH 1/3] mtd: nand: Move ELM driver and rename as omap_elm Ezequiel Garcia
                   ` (3 more replies)
  0 siblings, 4 replies; 17+ messages in thread
From: Ezequiel Garcia @ 2014-09-11 13:47 UTC (permalink / raw)
  To: Roger Quadros, Brian Norris
  Cc: Tony Lindgren, linux-omap, linux-mtd, Ezequiel Garcia

Following the recent discussion with Roger, here's a few patches that
(hopefully) fix all the issues.

The first patches rename the OMAP NAND drivers, so they are now called
omap2_nand and omap_elm.

The last patch picks an idea from Yann E. Morin and fixes the build issue
reported by Roger. Quoting Roger:

""
I still get the following error if I set CONFIG_MTD_NAND_OMAP2 to y and
CONFIG_MTD_NAND_OMAP_BCH to m.

CONFIG_MTD_NAND_OMAP_BCH is used to select the ELM driver and it must be limited to
be built-in if CONFIG_MTD_NAND_OMAP2 is built-in.

Maybe it should be a sub option of CONFIG_MTD_NAND_OMAP2.
IMHO the elm.c file must be moved from mtd/devices to mtd/nand and renamed to omap_elm.c

drivers/built-in.o: In function `omap_nand_probe':
/work/linux-2.6/drivers/mtd/nand/omap2.c:2010: undefined reference to `elm_config'
/work/linux-2.6/drivers/mtd/nand/omap2.c:1980: undefined reference to `elm_config'
/work/linux-2.6/drivers/mtd/nand/omap2.c:1927: undefined reference to `elm_config'
drivers/built-in.o: In function `omap_elm_correct_data':
/work/linux-2.6/drivers/mtd/nand/omap2.c:1444: undefined reference to `elm_decode_bch_error_page'
make: *** [vmlinux] Error 1
""

[1] https://lkml.org/lkml/2013/5/4/84

Ezequiel Garcia (3):
  mtd: nand: Move ELM driver and rename as omap_elm
  mtd: nand: Rename OMAP NAND driver
  mtd: nand: Force omap_elm to be built as a module if omap2_nand is a
    module

 drivers/mtd/devices/Makefile                   | 1 -
 drivers/mtd/nand/Kconfig                       | 8 +++++++-
 drivers/mtd/nand/Makefile                      | 3 ++-
 drivers/mtd/nand/{omap2.c => omap2_nand.c}     | 0
 drivers/mtd/{devices/elm.c => nand/omap_elm.c} | 0
 5 files changed, 9 insertions(+), 3 deletions(-)
 rename drivers/mtd/nand/{omap2.c => omap2_nand.c} (100%)
 rename drivers/mtd/{devices/elm.c => nand/omap_elm.c} (100%)

-- 
2.1.0


^ permalink raw reply	[flat|nested] 17+ messages in thread
end of thread, other threads:[~2014-09-22 19:04 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-11 13:47 [PATCH 0/3] nand: Renaming, moving and fixing NAND and ELM drivers Ezequiel Garcia
2014-09-11 13:47 ` [PATCH 1/3] mtd: nand: Move ELM driver and rename as omap_elm Ezequiel Garcia
2014-09-12  8:55   ` Roger Quadros
2014-09-11 13:47 ` [PATCH 2/3] mtd: nand: Rename OMAP NAND driver Ezequiel Garcia
2014-09-12  8:55   ` Roger Quadros
2014-09-11 13:47 ` [PATCH 3/3] mtd: nand: Force omap_elm to be built as a module if omap2_nand is a module Ezequiel Garcia
2014-09-12  9:01   ` Roger Quadros
2014-09-12 16:56     ` Ezequiel Garcia
2014-09-15  8:27       ` Roger Quadros
2014-09-18  3:00         ` Brian Norris
2014-09-18  8:40           ` Ezequiel Garcia
2014-09-18  8:42             ` Roger Quadros
2014-09-18  8:40           ` Roger Quadros
2014-09-22 19:04       ` Brian Norris
2014-09-12  8:54 ` [PATCH 0/3] nand: Renaming, moving and fixing NAND and ELM drivers Roger Quadros
2014-09-12 16:46   ` Ezequiel Garcia
2014-09-15  8:20     ` Roger Quadros

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).