From: Belisko Marek <marek.belisko@gmail.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH] omap: twl-common: Fix musb-hdrc device name.
Date: Tue, 3 Dec 2013 10:08:38 +0100 [thread overview]
Message-ID: <CAAfyv37Vie1vZK2XQ1cfVq6eVnSuaBLfykk6pU8fwEyqvPF4BA@mail.gmail.com> (raw)
In-Reply-To: <529D9D43.6040101@ti.com>
Hi,
On Tue, Dec 3, 2013 at 9:58 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
> Hi,
>
> On Tuesday 03 December 2013 02:03 PM, Marek Belisko wrote:
>> Without this change when booting omap3 device (gta04) with board file
>> leads to follwing errors:
>>
>> [ 1.203308] musb-hdrc musb-hdrc.0.auto: unable to find phy
>> [ 1.209075] HS USB OTG: no transceiver configured
>> [ 1.214019] musb-hdrc musb-hdrc.0.auto: musb_init_controller failed with status -517
>>
>> and usb isn't working.
>>
>> This is probably regression caused by commit: 6c27f939
>
> I think a better fix would be to have this merged..
> https://lkml.org/lkml/2013/7/26/91
Yes I see but how this could help with current situation? Ho you then
specify device number?
This patch is fixing 3.13-rcx regression.
>>
>> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
>> ---
>> arch/arm/mach-omap2/twl-common.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
>> index b0d54da..3640ce0 100644
>> --- a/arch/arm/mach-omap2/twl-common.c
>> +++ b/arch/arm/mach-omap2/twl-common.c
>> @@ -92,7 +92,7 @@ void __init omap_pmic_late_init(void)
>>
>> #if defined(CONFIG_ARCH_OMAP3)
>> struct phy_consumer consumers[] = {
>> - PHY_CONSUMER("musb-hdrc.0", "usb"),
>> + PHY_CONSUMER("musb-hdrc.0.auto", "usb"),
>
> the index '0' might vary for some boards leading it to again break musb.
If you run grep for musb-hdrc :
arch/arm/mach-omap2/board-3430sdp.c: usb_bind_phy("musb-hdrc.0.auto",
0, "twl4030_usb");
arch/arm/mach-omap2/board-devkit8000.c:
usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
arch/arm/mach-omap2/board-overo.c: usb_bind_phy("musb-hdrc.0.auto", 0,
"twl4030_usb");
arch/arm/mach-omap2/board-omap3beagle.c:
usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
arch/arm/mach-omap2/board-omap3touchbook.c:
usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
arch/arm/mach-omap2/board-cm-t35.c: usb_bind_phy("musb-hdrc.0.auto",
0, "twl4030_usb");
arch/arm/mach-omap2/board-omap3stalker.c:
usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
arch/arm/mach-omap2/board-omap3logic.c:
usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
arch/arm/mach-omap2/board-2430sdp.c: usb_bind_phy("musb-hdrc.0.auto",
0, "twl4030_usb");
arch/arm/mach-omap2/board-ldp.c: usb_bind_phy("musb-hdrc.0.auto", 0,
"twl4030_usb");
arch/arm/mach-omap2/board-rx51.c: usb_bind_phy("musb-hdrc.0.auto", 0,
"twl4030_usb");
arch/arm/mach-omap2/board-omap3pandora.c:
usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
Until mentioned patch isn't merged and PHY_CONSUMER isn't updated I
think this is correct solution.
>
> Thanks
> Kishon
BR,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
next prev parent reply other threads:[~2013-12-03 9:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 8:33 [PATCH] omap: twl-common: Fix musb-hdrc device name Marek Belisko
2013-12-03 8:58 ` Kishon Vijay Abraham I
2013-12-03 9:08 ` Belisko Marek [this message]
2013-12-03 9:19 ` Kishon Vijay Abraham I
2013-12-03 9:20 ` Belisko Marek
2013-12-05 18:43 ` Tony Lindgren
2013-12-09 7:35 ` Belisko Marek
2013-12-09 17:50 ` Tony Lindgren
2013-12-13 11:27 ` Belisko Marek
2013-12-13 11:56 ` Kishon Vijay Abraham I
2013-12-13 17:36 ` Tony Lindgren
2013-12-16 8:52 ` Kishon Vijay Abraham I
2013-12-16 15:26 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAfyv37Vie1vZK2XQ1cfVq6eVnSuaBLfykk6pU8fwEyqvPF4BA@mail.gmail.com \
--to=marek.belisko@gmail.com \
--cc=hns@goldelico.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).