From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2 00/22] mfd: demodularization of non-modular drivers Date: Wed, 5 Dec 2018 12:50:51 +0100 Message-ID: References: <1543811009-15112-1-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1543811009-15112-1-git-send-email-paul.gortmaker@windriver.com> Sender: linux-kernel-owner@vger.kernel.org To: Paul Gortmaker Cc: Lee Jones , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Cory Maccarrone , David Dajun Chen , Dong Aisheng , Eric Miao , Graeme Gregory , Guennadi Liakhovetski , Haojian Zhuang , jinyoungp@nvidia.com, Jorge Eduardo Candelaria , Laxman Dewangan , Mark Brown , Mattias NILSSON , Michael Hennerich , Mike Rapoport , ext Tony Lindgren , Ve List-Id: linux-omap@vger.kernel.org On Mon, Dec 3, 2018 at 5:24 AM Paul Gortmaker wrote: > [v1 --> v2: add some more commits as requested by Lee (MFD maintainer), > update the 00/NN text; re-do build and link testing on new linux-next. ] > > This group of MFD drivers are all controlled by "bool" Kconfig settings, > but contain various amounts of largely pointless uses of infrastructure > related to modular operations, even though they can't be built modular. > > We can easily remove/replace all of it. We are trying to make driver > code consistent with the Makefiles/Kconfigs that control them. This > means not using modular functions/macros for drivers that can never be > built as a module. Some of the downfalls this oversight leads to are: This series: Acked-by: Linus Walleij IMO it is clearly the right thing to do, moving a whole bunch of clutter out of the way so we can see clearly and the effect of getting rid of the is a substantial improvement in its own right. Yours. Linus Walleij