Re: [PATCH v3] iio: light: new driver for the ROHM BH1780

Re: [PATCH v3] iio: light: new driver for the ROHM BH1780

[Tony Lindgren]

* Peter De Schrijver <pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> [160404 00:43]:
> On Sun, Apr 03, 2016 at 06:30:49PM +0200, Linus Walleij wrote:
> > On Sun, Apr 3, 2016 at 11:51 AM, Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > > On 30/03/16 09:34, Linus Walleij wrote:
> > 
> > >> I want to phase out the old misc driver, but don't know how that
> > >> should properly be handled. The driver has an old (totally
> > >> undocumented) sysfs ABI for raw measurements, should I add
> > >> this as backward-compatibility and symlink the device to the old
> > >> location?
> > >
> > > Good question.  I guess we unfortunately do need to jump through the hoops as
> > > who knows what userspace code there is out there using that interface.
> > > At least it is small!
> > 
> > The maintainer Hemanth seems to have disappeared.
> > 
> > Let's ask some of the OMAP and ex-OMAP people, I think they know
> > or know who knows...
> > 
> > Tony, Peter, Paul: drivers/misc/bh1780gli.c has a funky sysfs ABI.
> > It is only used in arch/arm/boot/dts/omap4-sdp.dts as far as I can
> > tell. What device is this, and more importantly, who is running it
> > and with what userspace? I'm happy to go and patch that userspace
> > if I can just get a pointer to whoever is developing it. Sailfish?
> 
> Sailfish has never used OMAP4 afaik. OMAP4 sdp is a TI dev board, so maybe
> someone from TI knows what this is for?

Adding linux-omap to Cc. I suggest do a minimal patch to remove the
sysfs interface, then revert the patch if needed. I don't think
people are using it.

Regards,

Tony

Re: [PATCH v3] iio: light: new driver for the ROHM BH1780

[Linus Walleij]

On Tue, Apr 5, 2016 at 12:35 AM, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> wrote:

> Adding linux-omap to Cc. I suggest do a minimal patch to remove the
> sysfs interface, then revert the patch if needed. I don't think
> people are using it.

The old driver in misc is just using sysfs for everything, so removing the
sysfs is like deleting the driver. Once the IIO driver is merged I guess
I'll boldly post a patch to delete it and then a patch to activate the new
driver in the OMAP defconfig.

Yours,
Linus Walleij

Re: [PATCH v3] iio: light: new driver for the ROHM BH1780

[Tony Lindgren]

* Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> [160405 00:51]:
> On Tue, Apr 5, 2016 at 12:35 AM, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> wrote:
> 
> > Adding linux-omap to Cc. I suggest do a minimal patch to remove the
> > sysfs interface, then revert the patch if needed. I don't think
> > people are using it.
> 
> The old driver in misc is just using sysfs for everything, so removing the
> sysfs is like deleting the driver. Once the IIO driver is merged I guess
> I'll boldly post a patch to delete it and then a patch to activate the new
> driver in the OMAP defconfig.

OK

Tony