linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Clark <rob.clark@linaro.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Greg KH <greg@kroah.com>,
	linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org,
	patches@linaro.org
Subject: Re: [PATCH 1/2] omap2+: add drm device
Date: Mon, 16 Jan 2012 10:37:29 -0600	[thread overview]
Message-ID: <CAF6AEGt0qYcWh8_hdygswroWNdiWmVB9-Cv3c00zKn3OSVmD4A@mail.gmail.com> (raw)
In-Reply-To: <CAMP44s0EYp1inCHZkAZES7ezOiL7F533-euGQCk83hS_QN-LgQ@mail.gmail.com>

On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark <rob.clark@linaro.org> wrote:
>> On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras
>> <felipe.contreras@gmail.com> wrote:
>>> On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark <rob.clark@linaro.org> wrote:
>>>> diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap/Makefile
>>>> index 9a58461..b86e6cb 100644
>>>> --- a/arch/arm/plat-omap/Makefile
>>>> +++ b/arch/arm/plat-omap/Makefile
>>>> @@ -4,7 +4,7 @@
>>>>
>>>>  # Common support
>>>>  obj-y := common.o sram.o clock.o devices.o dma.o mux.o \
>>>> -        usb.o fb.o counter_32k.o
>>>> +        usb.o fb.o counter_32k.o drm.o
>>>
>>> Should be something like this:
>>> obj-$(CONFIG_DRM_OMAP) += drm.o
>>
>> btw, how does that work if CONFIG_DRM_OMAP=m?  Do you end up w/ a
>> plat-omap module?
>
> Yes, and platform drivers are supposed to be loaded automatically at
> boot-time by udev (or similar).

oh, but this won't work, because common.c has to call
omapdrm_reserve_vram() (similar to how omapfb_reserve_sdram_memblock()
works).. so I think it has to stay the way it is in this patch.

I guess this is the reason that omapfb (fb.c is the example I copied)
device is setup in the same way.

BR,
-R

> --
> Felipe Contreras
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-01-16 16:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-13 20:41 [PATCH 1/2] omap2+: add drm device Rob Clark
2012-01-13 20:42 ` [PATCH 2/2] drm/omap: platform data structs moved to plat-omap Rob Clark
2012-01-13 20:59 ` [PATCH 1/2] omap2+: add drm device Felipe Contreras
2012-01-13 21:04   ` Rob Clark
2012-01-13 21:19   ` Rob Clark
2012-01-16 14:12     ` Felipe Contreras
2012-01-16 16:37       ` Rob Clark [this message]
2012-01-16 16:59         ` Felipe Contreras
2012-01-16 17:01           ` Rob Clark
2012-01-16 20:37             ` Felipe Contreras
2012-01-16 21:24               ` Rob Clark
2012-01-24 15:33                 ` Felipe Contreras
2012-01-24 15:54                   ` Rob Clark
2012-01-25  2:17                     ` Felipe Contreras
2012-01-25  2:32                       ` Rob Clark
2012-01-25 13:51                         ` Rob Clark
2012-01-23 17:24 ` Cousson, Benoit
2012-01-23 17:48   ` Rob Clark
2012-02-17 21:14   ` Gross, Andy
2012-02-09 17:28 ` Greg KH
2012-02-09 17:41   ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAF6AEGt0qYcWh8_hdygswroWNdiWmVB9-Cv3c00zKn3OSVmD4A@mail.gmail.com \
    --to=rob.clark@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=felipe.contreras@gmail.com \
    --cc=greg@kroah.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).