From mboxrd@z Thu Jan 1 00:00:00 1970 From: "R, Sricharan" Subject: Re: [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T Date: Wed, 12 Sep 2012 18:50:00 +0530 Message-ID: References: <1347429006-10879-1-git-send-email-r.sricharan@ti.com> <5050841A.7030203@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from na3sys009aog111.obsmtp.com ([74.125.149.205]:58918 "EHLO na3sys009aog111.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754924Ab2ILNUK (ORCPT ); Wed, 12 Sep 2012 09:20:10 -0400 Received: by vbbff1 with SMTP id ff1so1959315vbb.19 for ; Wed, 12 Sep 2012 06:20:00 -0700 (PDT) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: Cyril Chemparathy , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Catalin Marinas Hi, On Wed, Sep 12, 2012 at 6:27 PM, Shilimkar, Santosh wrote: > On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy wrote: >> >> On 9/12/2012 1:50 AM, R Sricharan wrote: >>> >>> Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, >>> the feature is not getting selected. >>> Adding a string description in the Kconfig resolves this. >>> >>> But not sure if this is the right way to fix this. >>> >> >> Shouldn't you be selecting this in your 64-bit dma address capable arch >> instead? >> > Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens > in the arch which needs it. Since this option was made as simple bool, > looks like because of some KCONFIG magic, it was not getting selected. > Adding some help text does fix the issue and thats is the patch all about. > Correct. So even if you select this in the arch/defconfig, today this option is not getting enabled in the finally generated .config. So by adding this description text, this can really be selected from arch level. Thanks, Sricharan