From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Ramirez Luna, Omar" <omar.ramirez@ti.com>
Cc: Felipe Contreras <felipe.contreras@nokia.com>,
linux-omap@vger.kernel.org,
"Justin P. Mattock" <justinmattock@gmail.com>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
Jiri Kosina <jkosina@suse.cz>,
Greg KH <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] staging: tidspbridge: enable watchdog by default
Date: Sun, 12 Feb 2012 01:03:21 +0200 [thread overview]
Message-ID: <CAMP44s1yY8N4z_uF1b=DKdEMGXORJUhkytEpbK2AoCSTbmiJNw@mail.gmail.com> (raw)
In-Reply-To: <CAB-zwWhSoiMNVGQ=u=6-Umte-AaP9Qih8QMJFTyk8pjXaXysLg@mail.gmail.com>
On Sat, Feb 11, 2012 at 9:19 PM, Ramirez Luna, Omar <omar.ramirez@ti.com> wrote:
>
> On Feb 10, 2012 12:44 PM, "Felipe Contreras" <felipe.contreras@gmail.com>
> wrote:
>>
>> On Fri, Feb 10, 2012 at 10:35 PM, Dan Carpenter
>> <dan.carpenter@oracle.com> wrote:
>> > On Fri, Feb 10, 2012 at 09:42:32PM +0200, Felipe Contreras wrote:
>> >> On Fri, Feb 10, 2012 at 8:00 PM, Dan Carpenter
>> >> <dan.carpenter@oracle.com> wrote:
>> >> > On Fri, Feb 10, 2012 at 01:30:48AM +0200, Felipe Contreras wrote:
>> >> >> It's not an oops, it's a warning, and again, it depends on the
>> >> >> firmware being used. We don't have control over that, and we have no
>> >> >> way to detect if this feature is there. It's up to the user.
>> >> >
>> >> > Perhaps just remove the warning message and handle the condition
>> >> > instead of printing a stack dump? The user should be triggering
>> >> > stack dumps. What on earth?
>> >>
>> >> The warning doesn't come from the driver.
>> >
>> > I'm not sure I understand. Are you saying that because it comes
>> > from the arch/ directory, it can't be fixed? I have good news for
>> > you my friend. :) It's all open source! \o/
>>
>> The fact that you _can_ remove the warning doesn't mean you should. To
>> me it sounds like a proper warning.
>>
>> > Anyway, I saw in another email that Omar is working on a fix so
>> > probably we can just wait for his patch, yes?
>>
>> He only proposed a solution, I doubt he is working on. And to me, that
>> sounded like a hack rather than a proper fix.
>
> I'm out on travel but will be able to look at it on Monday.
>
> Well, I think it is the right way, you look on the firmware if it has WDT
> you use it if it doesn't then you don't. Rather than guessing if you have
> the feature. It would be like reading a config option in the firmware.
Yeah, but it's not really firmware, it's an operating system image. I
can be running Linux there, and I might have implemented WDT. How is
that code going to find that out?
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-02-11 23:03 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 1:01 [PATCH] staging: tidspbridge: enable watchdog by default Felipe Contreras
2012-02-01 1:12 ` Greg KH
2012-02-01 1:37 ` Felipe Contreras
2012-02-01 3:22 ` Justin P. Mattock
2012-02-01 8:11 ` Felipe Contreras
2012-02-01 20:22 ` Ramirez Luna, Omar
2012-02-01 3:44 ` Greg KH
2012-02-01 7:26 ` Felipe Contreras
2012-02-09 17:35 ` Greg KH
2012-02-09 18:41 ` Felipe Contreras
2012-02-09 18:43 ` Felipe Contreras
2012-02-09 18:59 ` Greg KH
2012-02-09 23:30 ` Felipe Contreras
2012-02-10 0:45 ` Ramirez Luna, Omar
2012-02-10 5:18 ` Greg KH
2012-02-10 15:35 ` Justin P. Mattock
2012-02-10 16:05 ` Felipe Contreras
2012-02-10 16:14 ` Justin P. Mattock
2012-02-10 16:16 ` Greg KH
2012-02-10 16:29 ` Felipe Contreras
2012-02-10 16:16 ` Felipe Contreras
2012-02-10 17:48 ` Greg KH
2012-02-14 1:12 ` Ramirez Luna, Omar
2012-02-10 18:00 ` Dan Carpenter
2012-02-10 19:42 ` Felipe Contreras
2012-02-10 20:35 ` Dan Carpenter
2012-02-10 20:43 ` Felipe Contreras
[not found] ` <CAB-zwWhSoiMNVGQ=u=6-Umte-AaP9Qih8QMJFTyk8pjXaXysLg@mail.gmail.com>
2012-02-11 23:03 ` Felipe Contreras [this message]
2012-02-14 1:06 ` Ramirez Luna, Omar
2012-02-14 16:23 ` Felipe Contreras
2012-02-15 2:56 ` Ramirez Luna, Omar
2012-02-15 9:43 ` Víctor M. Jáquez L.
2012-02-15 11:41 ` Felipe Contreras
2012-02-15 12:02 ` Víctor M. Jáquez L.
2012-02-15 22:32 ` Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s1yY8N4z_uF1b=DKdEMGXORJUhkytEpbK2AoCSTbmiJNw@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=felipe.contreras@nokia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=justinmattock@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=omar.ramirez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).