From: Felipe Contreras <felipe.contreras@gmail.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Hema HK <hemahk@ti.com>
Subject: Re: [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown
Date: Thu, 12 Jan 2012 17:59:58 +0200 [thread overview]
Message-ID: <CAMP44s3rG+ZOoDSBdg0D+4-gFO5+akmLOeeDJ0f+3rtLnieHZw@mail.gmail.com> (raw)
In-Reply-To: <CANOLnOMj-Z7T8tcgjr-r1RrGFPpohbtvOg=FG6fVJR3ua17bxg@mail.gmail.com>
On Thu, Jan 12, 2012 at 5:55 PM, Grazvydas Ignotas <notasas@gmail.com> wrote:
> On Thu, Jan 12, 2012 at 5:45 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> On Thu, Jan 12, 2012 at 3:21 PM, Grazvydas Ignotas <notasas@gmail.com> wrote:
>>> Since commit 4f9edd2d7e8d "usb: musb: Fix the crash issue during reboot"
>>> musb_shutdown() does pm_runtime_get_sync/pm_runtime_put by itself, so
>>> this no longer needs to be done by the caller. Also, musb_exit_debugfs()
>>> doesn't access the device, so just drop those runtime_pm calls.
>>
>> I don't understand what is the relationship with 4f9edd2d7e8d and
>> musb_shutdown(), it seems this patch is basically reverting
>> 4f9edd2d7e8d.
>
> No it's not, read my patch and it's description again. 4f9edd2d7e8d is
> patching musb_shutdown(), mine musb_remove().
Ohh, OK.
--
Felipe Contreras
next prev parent reply other threads:[~2012-01-12 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 13:21 [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown Grazvydas Ignotas
2012-01-12 15:45 ` Felipe Contreras
[not found] ` <CAMP44s3PnWCmCD1ip1EP9wMBDeOZ0EacpFTOTvASxYcFJh+W6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-12 15:55 ` Grazvydas Ignotas
2012-01-12 15:59 ` Felipe Contreras [this message]
2012-01-13 5:32 ` Shubhrajyoti
2012-01-24 9:52 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s3rG+ZOoDSBdg0D+4-gFO5+akmLOeeDJ0f+3rtLnieHZw@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=balbi@ti.com \
--cc=hemahk@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).