* [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown
@ 2012-01-12 13:21 Grazvydas Ignotas
2012-01-12 15:45 ` Felipe Contreras
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Grazvydas Ignotas @ 2012-01-12 13:21 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-usb, linux-omap, Hema HK, Grazvydas Ignotas
Since commit 4f9edd2d7e8d "usb: musb: Fix the crash issue during reboot"
musb_shutdown() does pm_runtime_get_sync/pm_runtime_put by itself, so
this no longer needs to be done by the caller. Also, musb_exit_debugfs()
doesn't access the device, so just drop those runtime_pm calls.
Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
---
drivers/usb/musb/musb_core.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 485f7ba..b2ca6fd 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -2162,11 +2162,9 @@ static int __exit musb_remove(struct platform_device *pdev)
* - Peripheral mode: peripheral is deactivated (or never-activated)
* - OTG mode: both roles are deactivated (or never-activated)
*/
- pm_runtime_get_sync(musb->controller);
musb_exit_debugfs(musb);
musb_shutdown(pdev);
- pm_runtime_put(musb->controller);
musb_free(musb);
iounmap(ctrl_base);
device_init_wakeup(&pdev->dev, 0);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown
2012-01-12 13:21 [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown Grazvydas Ignotas
@ 2012-01-12 15:45 ` Felipe Contreras
[not found] ` <CAMP44s3PnWCmCD1ip1EP9wMBDeOZ0EacpFTOTvASxYcFJh+W6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-13 5:32 ` Shubhrajyoti
2012-01-24 9:52 ` Felipe Balbi
2 siblings, 1 reply; 6+ messages in thread
From: Felipe Contreras @ 2012-01-12 15:45 UTC (permalink / raw)
To: Grazvydas Ignotas; +Cc: Felipe Balbi, linux-usb, linux-omap, Hema HK
On Thu, Jan 12, 2012 at 3:21 PM, Grazvydas Ignotas <notasas@gmail.com> wrote:
> Since commit 4f9edd2d7e8d "usb: musb: Fix the crash issue during reboot"
> musb_shutdown() does pm_runtime_get_sync/pm_runtime_put by itself, so
> this no longer needs to be done by the caller. Also, musb_exit_debugfs()
> doesn't access the device, so just drop those runtime_pm calls.
I don't understand what is the relationship with 4f9edd2d7e8d and
musb_shutdown(), it seems this patch is basically reverting
4f9edd2d7e8d.
Cheers.
--
Felipe Contreras
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown
2012-01-12 13:21 [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown Grazvydas Ignotas
2012-01-12 15:45 ` Felipe Contreras
@ 2012-01-13 5:32 ` Shubhrajyoti
2012-01-24 9:52 ` Felipe Balbi
2 siblings, 0 replies; 6+ messages in thread
From: Shubhrajyoti @ 2012-01-13 5:32 UTC (permalink / raw)
To: Grazvydas Ignotas; +Cc: Felipe Balbi, linux-usb, linux-omap, Hema HK
On Thursday 12 January 2012 06:51 PM, Grazvydas Ignotas wrote:
> Since commit 4f9edd2d7e8d "usb: musb: Fix the crash issue during reboot"
> musb_shutdown() does pm_runtime_get_sync/pm_runtime_put by itself, so
> this no longer needs to be done by the caller. Also, musb_exit_debugfs()
> doesn't access the device, so just drop those runtime_pm calls.
>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Looks good to me
Reviewed-by: Shubhrajyoti D <shubhrajyoti@ti.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown
2012-01-12 13:21 [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown Grazvydas Ignotas
2012-01-12 15:45 ` Felipe Contreras
2012-01-13 5:32 ` Shubhrajyoti
@ 2012-01-24 9:52 ` Felipe Balbi
2 siblings, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2012-01-24 9:52 UTC (permalink / raw)
To: Grazvydas Ignotas; +Cc: Felipe Balbi, linux-usb, linux-omap, Hema HK
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
On Thu, Jan 12, 2012 at 03:21:38PM +0200, Grazvydas Ignotas wrote:
> Since commit 4f9edd2d7e8d "usb: musb: Fix the crash issue during reboot"
> musb_shutdown() does pm_runtime_get_sync/pm_runtime_put by itself, so
> this no longer needs to be done by the caller. Also, musb_exit_debugfs()
> doesn't access the device, so just drop those runtime_pm calls.
>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
applied, thanks
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-01-24 9:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-12 13:21 [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown Grazvydas Ignotas
2012-01-12 15:45 ` Felipe Contreras
[not found] ` <CAMP44s3PnWCmCD1ip1EP9wMBDeOZ0EacpFTOTvASxYcFJh+W6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-12 15:55 ` Grazvydas Ignotas
2012-01-12 15:59 ` Felipe Contreras
2012-01-13 5:32 ` Shubhrajyoti
2012-01-24 9:52 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).