linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: stephane eranian <eranian@googlemail.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "Ming Lei" <ming.lei@canonical.com>,
	"Måns Rullgård" <mans@mansr.com>,
	"Cousson, Benoit" <b-cousson@ti.com>,
	"oprofile-list@lists.sourceforge.net"
	<oprofile-list@lists.sourceforge.net>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"santosh.shilimkar@ti.com" <santosh.shilimkar@ti.com>
Subject: Re: oprofile and ARM A9 hardware counter
Date: Fri, 27 Jan 2012 18:03:28 +0100	[thread overview]
Message-ID: <CAMsRxf+iv06zOCMzhYONeLaf6RvOLp38T53mR--8ESHvCXMeFQ@mail.gmail.com> (raw)
In-Reply-To: <20120127165941.GK2347@mudshark.cambridge.arm.com>

On Fri, Jan 27, 2012 at 5:59 PM, Will Deacon <will.deacon@arm.com> wrote:
> On Fri, Jan 27, 2012 at 03:57:25PM +0000, stephane eranian wrote:
>> On Fri, Jan 27, 2012 at 4:54 PM, Will Deacon <will.deacon@arm.com> wrote:
>> >
>> > Ok. Note that on ARM the PMU generates a standard IRQ (i.e. not an NMI) so
>> > you may miss samples if they occur during critical kernel sections (and if
>> > you look at a profile, spin_unlock_irqrestore will be quite high).
>> >
>> But I am only running a user space noploop. So it spends 99% in user space, no
>> critical section.
>
> and your result is almost 99% of the way there :)
>
> There are also potential overheads from the PMU interrupts themselves, since
> there is a latency between overflow and taking the interrupt and then
> between there are actually reading the counter (they continue to count after
> overflow).
>
> That said, if you see any bugs in the code please do shout!
>
I suspect there is something wrong, we shouldn't hit the max_rate_limit.
You may have bursts of interrupts (samples). I'll check on that this week-end.

>> > A7 and A15 have the ability to filter counters based on privilege level, so
>> > you can get more accurate userspace counts there.
>>
>> Ok, that's better. Need to update libpfm4 for A15 with priv levels then!
>
> How do you handle that in libpfm4? On ARM, the event encodings remain the same,
> you just need to set some extra bits to determine which levels are included or
> excluded (you can do this with the perf tool by using the :{u,k,h} suffix on an
> event description).
>
It depends what you call the encoding? If the priv level can be encoded in the
attr->config field, then that's easy. If it needs to be set somewhere else, then
we need to figure out how you encode it in the attr struct. Either in some other
bits in attr->config or use attr->config1, for instance. You tell me.

> Will

  reply	other threads:[~2012-01-27 17:03 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAAO=S0+L2Q1YZC-pfm2Lz8jPooTeHYOMaZbtRgHYFoL_m7rvhA@mail.gmail.com>
     [not found] ` <4F0B182D.7060507@us.ibm.com>
2012-01-09 22:49   ` oprofile and ARM A9 hardware counter Will Deacon
2012-01-09 23:30     ` Ming Lei
2012-01-10  0:46       ` stephane eranian
2012-01-18  4:18         ` Ming Lei
2012-01-18  9:33           ` Ming Lei
2012-01-18 11:39             ` Shilimkar, Santosh
2012-01-18 12:24               ` Ming Lei
2012-01-18 12:33                 ` Shilimkar, Santosh
2012-04-03  9:25                   ` Will Deacon
2012-04-03  9:42                     ` Shilimkar, Santosh
2012-04-03  9:47                       ` Will Deacon
2012-04-03 10:01                         ` Shilimkar, Santosh
2012-04-03 12:34                           ` Will Deacon
2012-04-03 12:41                             ` Shilimkar, Santosh
2012-04-03 14:27                             ` Kevin Hilman
2012-04-03 16:07                               ` Will Deacon
2012-04-03 23:14                                 ` Kevin Hilman
2012-04-03 23:29                                   ` Paul Walmsley
2012-04-04  3:42                                     ` Ming Lei
2012-04-04 11:15                                     ` Will Deacon
2012-04-26 18:07                                       ` Will Deacon
2012-04-30 22:25                                         ` Kevin Hilman
2012-05-07 17:27                                           ` Ming Lei
2012-05-04 22:17                                         ` Jon Hunter
2012-05-07 17:15                                           ` Kevin Hilman
2012-05-07 19:53                                             ` Jon Hunter
2012-05-07 23:28                                               ` Kevin Hilman
2012-05-08 11:01                                                 ` Cousson, Benoit
2012-05-08 11:23                                                   ` Jean Pihet
2012-05-08 12:37                                                     ` Cousson, Benoit
2012-05-08 13:18                                                       ` Jean Pihet
2012-05-08 14:00                                                         ` Kevin Hilman
2012-05-08 14:03                                                           ` Cousson, Benoit
2012-05-08 16:18                                                             ` Kevin Hilman
2012-05-08 19:51                                                               ` Jon Hunter
2012-05-08 21:28                                                                 ` Kevin Hilman
2012-05-08 22:20                                                                   ` Jon Hunter
2012-05-08 22:12                                                                 ` Ming Lei
2012-05-08 17:31                                                   ` Jon Hunter
2012-05-08 21:22                                                     ` Kevin Hilman
2012-05-08 23:59                                                       ` Jon Hunter
2012-05-09 10:58                                                       ` Cousson, Benoit
2012-05-09 18:04                                                         ` Jon Hunter
2012-05-09 19:28                                                           ` Jon Hunter
2012-05-09 21:45                                                             ` Jon Hunter
2012-05-10  8:44                                                               ` Will Deacon
2012-05-10  9:12                                                                 ` stephane eranian
2012-05-10 18:55                                                                 ` Jon Hunter
2012-05-11 12:25                                                                   ` Will Deacon
2012-05-11 13:47                                                                     ` Jon Hunter
2012-05-11 13:49                                                                       ` Will Deacon
2012-05-11 14:52                                                                         ` Jon Hunter
2012-05-11 15:02                                                                           ` Will Deacon
2012-05-11 16:31                                                                             ` Jon Hunter
2012-05-11 16:38                                                                               ` Will Deacon
2012-05-11 23:51                                                                                 ` Jon Hunter
2012-05-15 13:52                                                                                   ` Will Deacon
2012-05-10 14:12                                                               ` Kevin Hilman
2012-05-10 19:05                                                                 ` Jon Hunter
2012-05-10  6:59                                                         ` Santosh Shilimkar
2012-05-08 21:50                                                 ` Paul Walmsley
2012-04-04  0:00                             ` Paul Walmsley
2012-04-04 11:07                               ` Will Deacon
2012-01-18  9:54           ` stephane eranian
2012-01-18 10:07             ` Ming Lei
2012-01-18 21:58               ` stephane eranian
2012-01-19  1:21                 ` Ming Lei
2012-01-19 11:34                   ` stephane eranian
2012-01-19 12:45                     ` Ming Lei
2012-01-19 12:51                       ` stephane eranian
2012-01-19 12:55                         ` stephane eranian
2012-01-19 13:14                         ` Ming Lei
2012-01-19 13:26                           ` Ming Lei
2012-01-19 13:32                             ` stephane eranian
2012-01-19 13:51                               ` Ming Lei
2012-01-19 17:07                                 ` stephane eranian
2012-01-20 13:47                                   ` stephane eranian
2012-01-21  3:25                                     ` Ming Lei
2012-01-21  9:16                                       ` stephane eranian
2012-01-27 12:13                                         ` Will Deacon
2012-01-27 12:45                                           ` stephane eranian
2012-01-27 12:56                                           ` Måns Rullgård
2012-01-27 13:28                                             ` Will Deacon
2012-01-27 13:32                                               ` stephane eranian
2012-01-27 13:47                                               ` Måns Rullgård
2012-01-27 13:56                                                 ` Will Deacon
2012-01-27 14:05                                                   ` Måns Rullgård
2012-01-27 14:09                                               ` Ming Lei
2012-01-27 15:45                                                 ` stephane eranian
2012-01-27 15:54                                                   ` Will Deacon
2012-01-27 15:57                                                     ` stephane eranian
2012-01-27 16:59                                                       ` Will Deacon
2012-01-27 17:03                                                         ` stephane eranian [this message]
2012-01-27 17:10                                                           ` Will Deacon
2012-01-27 17:16                                                             ` stephane eranian
2012-01-29 17:36                                                               ` stephane eranian
2012-01-30  9:40                                                                 ` Ming Lei
2012-01-30 10:24                                                                   ` stephane eranian
2012-01-30 13:43                                                                     ` stephane eranian
2012-01-30 14:49                                                                       ` Ming Lei
2012-01-30 16:02                                                                         ` stephane eranian
2012-01-30 16:08                                                                           ` Måns Rullgård
2012-01-30 17:15                                                                             ` stephane eranian
2012-01-30 17:24                                                                               ` Will Deacon
2012-01-30 17:45                                                                                 ` stephane eranian
2012-01-30 19:14                                                                                   ` Will Deacon
2012-01-30 20:45                                                                                     ` stephane eranian
2012-03-07  2:49                                                     ` Ming Lei
2012-03-07  9:48                                                       ` Will Deacon
2012-01-27 14:06                                           ` Ming Lei
2012-01-18 10:18             ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMsRxf+iv06zOCMzhYONeLaf6RvOLp38T53mR--8ESHvCXMeFQ@mail.gmail.com \
    --to=eranian@googlemail.com \
    --cc=b-cousson@ti.com \
    --cc=eranian@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mans@mansr.com \
    --cc=ming.lei@canonical.com \
    --cc=oprofile-list@lists.sourceforge.net \
    --cc=santosh.shilimkar@ti.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).