Re: [PATCH] memory: OMAP_GPMC should depend on ARCH_OMAP2PLUS || ARCH_K3

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Roger,

On Tue, May 10, 2022 at 10:10 AM Roger Quadros <rogerq@kernel.org> wrote:
> On 10/05/2022 11:06, Geert Uytterhoeven wrote:
> > On Tue, May 10, 2022 at 9:40 AM Roger Quadros <rogerq@kernel.org> wrote:
> >> On 10/05/2022 10:30, Geert Uytterhoeven wrote:
> >>> On Tue, May 10, 2022 at 9:22 AM Roger Quadros <rogerq@kernel.org> wrote:
> >>>> On 09/05/2022 16:48, Geert Uytterhoeven wrote:
> >>>>> The Texas Instruments OMAP General Purpose Memory Controller (GPMC) is
> >>>>> only present on TI OMAP2/3/4/5, AM33xx, AM43x, DRA7xx, TI81xx, and K3
> >>>>> SoCs.  Hence add a dependency on ARCH_OMAP2PLUS || ARCH_K3, to prevent
> >>>>> asking the user about this driver when configuring a kernel without
> >>>>> OMAP2+ or K3 SoC family support.
> >>>>>
> >>>>> Fixes: be34f45f0d4aa91c ("memory: omap-gpmc: Make OMAP_GPMC config visible and selectable")
> >>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> >> Could you please also add ARCH_KEYSTONE in the 'depends on' list
> >> as some SoCs in that architecture do have the GPMC block.
> >
> > Are you sure? AFAICS, none of the Keystone DTS files have device
> > nodes that are compatible with the match list in the omap-gpmc driver.
>
> Yes, the 66AK2G12 SoC contains the GPMC module. [1]
>
> > Or perhaps the GPMC support still has to be added to the Keystone
> > DTS files (and or driver)?
>
> That's most likely the case.

So would it make sense to compile the omap-gpmc driver on keystone
yet, or does that need the introduction of e.g. a ti,k2g-gpmc compatible
value first, and thus should it be postponed?

> [1] 66AK2G12 datasheet: https://www.ti.com/lit/ds/symlink/66ak2g12.pdf?ts=1652170122865&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252F66AK2G12

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds