linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Duplicate TI EDMA debugfs registration
@ 2025-08-12 13:32 Geert Uytterhoeven
  0 siblings, 0 replies; only message in thread
From: Geert Uytterhoeven @ 2025-08-12 13:32 UTC (permalink / raw)
  To: Peter Ujfalusi, Aaro Koskinen, Andreas Kemnade, Kevin Hilman,
	Roger Quadros, Tony Lindgren, Vinod Koul, Matti Vaittinen
  Cc: dmaengine, open list:TI ETHERNET SWITCH DRIVER (CPSW),
	Linux Kernel Mailing List

Hi,

The TI EDMA driver registers two DMA engines:
https://elixir.bootlin.com/linux/v6.16/source/drivers/dma/ti/edma.c#L2525

This was fine when support for the second engine was introduced[1],
as it predated debugfs support for DMA engines[2].
However, both instances contain a pointer to the same physical device,
hence when the debugfs directory is created for the second engine at
https://elixir.bootlin.com/linux/v6.16/source/drivers/dma/dmaengine.c#L71,
it fails.

E.g. on BeagleBone Black:

    debugfs: '49000000.dma' already exists in 'dmaengine'

Note that this is not really a new problem, but it was brought to my
attention because the printed error message was changed in v6.17-rc1[3].
Before, it printed:

    debugfs: Directory '49000000.dma' with parent 'dmaengine' already present!

Thanks!

[1] 1be5336bc7ba050e ("dmaengine: edma: New device tree binding")
[2] 26cf132de6f79c06 ("dmaengine: Create debug directories for DMA devices")
[3] 59200f4526748158 ("new helper: simple_start_creating()")

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-08-12 13:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-12 13:32 Duplicate TI EDMA debugfs registration Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).