From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Nelson Subject: Re: [PATCH] omap3_beagle: init uart2 for beagle rev AX/BX only Date: Tue, 6 Mar 2012 18:39:34 -0600 Message-ID: References: <1331024711-23578-1-git-send-email-govindraj.raja@ti.com> <20120306213859.GA12083@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-wi0-f174.google.com ([209.85.212.174]:45342 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756654Ab2CGAjf (ORCPT ); Tue, 6 Mar 2012 19:39:35 -0500 Received: by wibhm2 with SMTP id hm2so3021042wib.19 for ; Tue, 06 Mar 2012 16:39:34 -0800 (PST) In-Reply-To: <20120306213859.GA12083@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: "Govindraj.R" , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Ujfalusi , Kevin Hilman , Koen Kooi On Tue, Mar 6, 2012 at 3:38 PM, Tony Lindgren wrote: > * Govindraj.R [120306 00:34]: >> From: "Govindraj.R" >> >> All beagle boards rev > AX/BX have external usb hubs connected to ehci >> interface, external hub/peripheral uses a nreset sequence for which >> uart2_rx.gpio_147 pin in mux mode4(USB2HS_nRST) is used on all beagle >> boards expect rev Ax/BX. >> (Reference to all beagle boards rev schematics: >> http://beagleboard.org/hardware/design) >> >> Initialising uart2 will lead to serial init taking over uart2_rx pin >> so init uart2_rx pin mux only for Beagle AX/BX rev boards. >> Dont init uart2 for all other boards allowing usb_ehci functionality. >> >> To initialise individual uart port by id utilise and modify the existing >> available func. omap_serial_board_init. >> >> Cc: Tony Lindgren >> Cc: Kevin Hilman >> Cc: Koen Kooi >> Tested-by: Peter Ujfalusi >> Tested-by: Robert Nelson >> Signed-off-by: Govindraj.R > > Can somebody please test this on non-xm beagle too and > reply with a Tested-by? Here's an update for my: Tested-by: Robert Nelson Just tested with one of my Beagle C4's, (and re-verified the new patch on a xM B) using usb flash drives on the ehci port... beagle c4: v3.2.9 Bus 001 Device 002: ID 0457:0151 Silicon Integrated Systems Corp. Super Flash 1GB / GXT 64MB Flash Drive v3.3-rc6: ehci broken v3.3-rc6 + this patch: Bus 001 Device 002: ID 0457:0151 Silicon Integrated Systems Corp. Super Flash 1GB / GXT 64MB Flash Driv beagle xM B: v3.2.9 Bus 001 Device 004: ID 1977:0824 T-Logic v3.3-rc6: ehci broken v3.3-rc6 + this patch: Bus 001 Device 004: ID 1977:0824 T-Logic Regards, -- Robert Nelson http://www.rcn-ee.com/