linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: omap2plus_defconfig: use CONFIG_CPUFREQ_DT
@ 2014-12-12 17:18 Nishanth Menon
  2014-12-15  4:23 ` Viresh Kumar
  2014-12-15 10:42 ` Geert Uytterhoeven
  0 siblings, 2 replies; 4+ messages in thread
From: Nishanth Menon @ 2014-12-12 17:18 UTC (permalink / raw)
  To: Tony Lindgren, viresh.kumar
  Cc: linux-kernel, linux-arm-kernel, linux-omap, linux-pm,
	Olof Johansson, Arnd Bergmann, Simon Horman, linux-sh,
	Nishanth Menon

CONFIG_GENERIC_CPUFREQ_CPU0 disappeared with commit bbcf071969b20f
("cpufreq: cpu0: rename driver and internals to 'cpufreq_dt'")

Use the renamed CONFIG_CPUFREQ_DT generic driver. It looks like with
v3.18-rc1, commit bbcf071969b20f and fdc509b15eb3eb came in via
different trees causing the resultant v3.18-rc1 to be non-functional for
cpufreq as default supported with omap2plus_defconfig.

Fixes: fdc509b15eb3eb ("ARM: omap2plus_defconfig: Add cpufreq to defconfig")
Signed-off-by: Nishanth Menon <nm@ti.com>
---

NOTE: as of v3.18 tag, The following still need to be fixed - I do not have all
the platforms impacted to make a generic change, so CCying folks who might be interested

arch/arm/configs/shmobile_defconfig:CONFIG_GENERIC_CPUFREQ_CPU0=y
arch/arm/configs/multi_v7_defconfig:CONFIG_GENERIC_CPUFREQ_CPU0=y

 arch/arm/configs/omap2plus_defconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index 3e09286..5fc0dbe 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -68,7 +68,7 @@ CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
 CONFIG_CPU_FREQ_GOV_POWERSAVE=y
 CONFIG_CPU_FREQ_GOV_USERSPACE=y
 CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
-CONFIG_GENERIC_CPUFREQ_CPU0=y
+CONFIG_CPUFREQ_DT=y
 # CONFIG_ARM_OMAP2PLUS_CPUFREQ is not set
 CONFIG_CPU_IDLE=y
 CONFIG_BINFMT_MISC=y
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: omap2plus_defconfig: use CONFIG_CPUFREQ_DT
  2014-12-12 17:18 [PATCH] ARM: omap2plus_defconfig: use CONFIG_CPUFREQ_DT Nishanth Menon
@ 2014-12-15  4:23 ` Viresh Kumar
  2014-12-15 10:42 ` Geert Uytterhoeven
  1 sibling, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2014-12-15  4:23 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Tony Lindgren, Arnd Bergmann, Linux PM list, linux-sh,
	linux-kernel@vger.kernel.org, Simon Horman, Olof Johansson,
	linux-omap, linux-arm-kernel@lists.infradead.org

On Fri, Dec 12, 2014 at 10:48 PM, Nishanth Menon <nm@ti.com> wrote:
> CONFIG_GENERIC_CPUFREQ_CPU0 disappeared with commit bbcf071969b20f
> ("cpufreq: cpu0: rename driver and internals to 'cpufreq_dt'")
>
> Use the renamed CONFIG_CPUFREQ_DT generic driver. It looks like with
> v3.18-rc1, commit bbcf071969b20f and fdc509b15eb3eb came in via
> different trees causing the resultant v3.18-rc1 to be non-functional for
> cpufreq as default supported with omap2plus_defconfig.
>
> Fixes: fdc509b15eb3eb ("ARM: omap2plus_defconfig: Add cpufreq to defconfig")
> Signed-off-by: Nishanth Menon <nm@ti.com>

Whomsoever applies it, please add:

Cc: <stable@vger.kernel.org>        # 3.18

> ---
>
> NOTE: as of v3.18 tag, The following still need to be fixed - I do not have all
> the platforms impacted to make a generic change, so CCying folks who might be interested
>
> arch/arm/configs/shmobile_defconfig:CONFIG_GENERIC_CPUFREQ_CPU0=y
> arch/arm/configs/multi_v7_defconfig:CONFIG_GENERIC_CPUFREQ_CPU0=y

I have fixed them now.

>
>  arch/arm/configs/omap2plus_defconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index 3e09286..5fc0dbe 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -68,7 +68,7 @@ CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y
>  CONFIG_CPU_FREQ_GOV_POWERSAVE=y
>  CONFIG_CPU_FREQ_GOV_USERSPACE=y
>  CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
> -CONFIG_GENERIC_CPUFREQ_CPU0=y
> +CONFIG_CPUFREQ_DT=y
>  # CONFIG_ARM_OMAP2PLUS_CPUFREQ is not set
>  CONFIG_CPU_IDLE=y
>  CONFIG_BINFMT_MISC=y

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: omap2plus_defconfig: use CONFIG_CPUFREQ_DT
  2014-12-12 17:18 [PATCH] ARM: omap2plus_defconfig: use CONFIG_CPUFREQ_DT Nishanth Menon
  2014-12-15  4:23 ` Viresh Kumar
@ 2014-12-15 10:42 ` Geert Uytterhoeven
  2015-01-05 19:17   ` Tony Lindgren
  1 sibling, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2014-12-15 10:42 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Tony Lindgren, Viresh Kumar, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Linux PM list, Olof Johansson, Arnd Bergmann, Simon Horman,
	Linux-sh list

On Fri, Dec 12, 2014 at 6:18 PM, Nishanth Menon <nm@ti.com> wrote:
> CONFIG_GENERIC_CPUFREQ_CPU0 disappeared with commit bbcf071969b20f
> ("cpufreq: cpu0: rename driver and internals to 'cpufreq_dt'")
>
> Use the renamed CONFIG_CPUFREQ_DT generic driver. It looks like with
> v3.18-rc1, commit bbcf071969b20f and fdc509b15eb3eb came in via
> different trees causing the resultant v3.18-rc1 to be non-functional for
> cpufreq as default supported with omap2plus_defconfig.
>
> Fixes: fdc509b15eb3eb ("ARM: omap2plus_defconfig: Add cpufreq to defconfig")
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> NOTE: as of v3.18 tag, The following still need to be fixed - I do not have all
> the platforms impacted to make a generic change, so CCying folks who might be interested
>
> arch/arm/configs/shmobile_defconfig:CONFIG_GENERIC_CPUFREQ_CPU0=y

Thanks!

FTR: this has been fixed in Simon's defconfig-for-v3.20 branch.

> arch/arm/configs/multi_v7_defconfig:CONFIG_GENERIC_CPUFREQ_CPU0=y

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: omap2plus_defconfig: use CONFIG_CPUFREQ_DT
  2014-12-15 10:42 ` Geert Uytterhoeven
@ 2015-01-05 19:17   ` Tony Lindgren
  0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2015-01-05 19:17 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Nishanth Menon, Viresh Kumar, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Linux PM list, Olof Johansson, Arnd Bergmann, Simon Horman,
	Linux-sh list

* Geert Uytterhoeven <geert@linux-m68k.org> [141215 02:44]:
> On Fri, Dec 12, 2014 at 6:18 PM, Nishanth Menon <nm@ti.com> wrote:
> > CONFIG_GENERIC_CPUFREQ_CPU0 disappeared with commit bbcf071969b20f
> > ("cpufreq: cpu0: rename driver and internals to 'cpufreq_dt'")
> >
> > Use the renamed CONFIG_CPUFREQ_DT generic driver. It looks like with
> > v3.18-rc1, commit bbcf071969b20f and fdc509b15eb3eb came in via
> > different trees causing the resultant v3.18-rc1 to be non-functional for
> > cpufreq as default supported with omap2plus_defconfig.
> >
> > Fixes: fdc509b15eb3eb ("ARM: omap2plus_defconfig: Add cpufreq to defconfig")
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> >
> > NOTE: as of v3.18 tag, The following still need to be fixed - I do not have all
> > the platforms impacted to make a generic change, so CCying folks who might be interested
> >
> > arch/arm/configs/shmobile_defconfig:CONFIG_GENERIC_CPUFREQ_CPU0=y
> 
> Thanks!
> 
> FTR: this has been fixed in Simon's defconfig-for-v3.20 branch.
> 
> > arch/arm/configs/multi_v7_defconfig:CONFIG_GENERIC_CPUFREQ_CPU0=y

Oops looks like this is still missing from omap2plus_defconfig, so
applying into omap-for-v3.19/fixes.

Regards,

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-01-05 19:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-12 17:18 [PATCH] ARM: omap2plus_defconfig: use CONFIG_CPUFREQ_DT Nishanth Menon
2014-12-15  4:23 ` Viresh Kumar
2014-12-15 10:42 ` Geert Uytterhoeven
2015-01-05 19:17   ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).