Re: [PATCH] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

["Munegowda, Keshava" <keshava_mgowda-l0cyMroinI0@public.gmane.org>]

On Fri, Mar 16, 2012 at 9:50 PM, Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> wrote:
> Hi Keshava,
>
> On Thu, Mar 08, 2012 at 08:30:21PM +0530, Munegowda, Keshava wrote:
>> On Fri, Mar 2, 2012 at 7:36 PM, Munegowda, Keshava
>> <keshava_mgowda-l0cyMroinI0@public.gmane.org> wrote:
>> > On Fri, Feb 24, 2012 at 5:14 PM, Munegowda, Keshava
>> > <keshava_mgowda-l0cyMroinI0@public.gmane.org> wrote:
>> >> On Fri, Feb 24, 2012 at 3:46 PM, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> wrote:
>> >>> Hi,
>> >>>
>> >>> On Fri, Feb 24, 2012 at 03:36:15PM +0530, Keshava Munegowda wrote:
>> >>>> From: Keshava Munegowda <Keshava_mgowda-l0cyMroinI0@public.gmane.org>
>> >>>>
>> >>>> It is observed that the echi ports of 3430 sdp board
>> >>>> are not working due to the random timing of programming
>> >>>> the associated GPIOs of the ULPI PHYs of the EHCI for reset.
>> >>>> If the PHYs are reset at during usbhs core driver, host ports will
>> >>>> not work because EHCI driver is loaded after the resetting PHYs.
>> >>>> The PHYs should be in reset state while initializing the EHCI
>> >>>> controller.
>> >>>> The code which does the GPIO pins associated with the PHYs
>> >>>> are programmed to reset is moved from the USB host core driver
>> >>>> to EHCI driver.
>> >>>>
>> >>>> Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
>> >>>> Reviewed-by: Partha Basak <parthab-PpE0FKYn9XJWk0Htik3J/w@public.gmane.org>
>> >>>
>> >>> won't this cause issues with EHCI/OHCI interactions ? I mean, what if
>> >>> you connect a FS/LS device and port is handed over to OHCI, does OHCI
>> >>> have any needs to reset the PHY or something similar ?
>> >>
>> >> No, it will not cause any issues with EHCI-OHCI issues.
>> >> But its difficult to comment on this because we don't have port
>> >> handoff supported
>> >> in hardware.
>> >>
>> >> regards
>> >> keshava
>> >
>> > Hi Samuel
>> >        please let me know if you have any comments on this patch.
>> > This is required patch for omap3 ehci enumeration instabilities.
>> >
>> > Regards
>> > Keshava
>>
>> Hi Samuel
>>       do you have any comments on this patch?
> I actually never received the actual patch, I think.
>
>
>> Felipe has reviewed this patch and he is agreed for this patch.
>> there are no comments from your side, requesting to push this change
>> to mainline.
> I looked at it on gmame, and it seems fine to me. If you want me to push this
> patch, then please (re-)send it to me, even privately.
>
> Cheers,
> Samuel.
>

Thanks Samuel
           yes, I will resend this ASAP.


regards
keshava
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html