Re: [PATCH v2 15/20] drm/tilcdc: Remove the use of drm_device private_data

Luca Ceresoli
2025-12-17T14:26:12Z

On Thu Dec 11, 2025 at 5:38 PM CET, Kory Maincent (TI.com) wrote:
> The DRM core documentation recommends against using dev_private:
> "Instead of using this pointer it is recommended that drivers use
> embed the struct &drm_device in their larger per-device structure."
>
> This patch refactors the tilcdc driver to follow this recommendation
> by embedding struct drm_device within struct tilcdc_drm_private and
> replacing all dev->dev_private accesses with the ddev_to_tilcdc_priv()
> helper macro that uses container_of().
>
> This change aligns the driver with modern DRM best practices.
>
> Signed-off-by: Kory Maincent (TI.com) <kory.maincent@bootlin.com>

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering