From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44490346A0E; Wed, 17 Dec 2025 14:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765981553; cv=none; b=dA3eckU5AcjuWjnTjIRHugsLGnv5koZQDd+xAzaNGYiQU7wGiwkWwyOZe99661O7H6ck2N+RGn6QVumIvVpUUBkR45B5k8YFU0kI9s/mQNlPnzN7HIYXBLWvv1i1Y0eJXK5dkSgufBkVFwQ05MHuLsdEL6WvoI6cZq3HeIM+RLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765981553; c=relaxed/simple; bh=OyUFMVB+avuA9qdP6LHrbIMa2+RkfJiwfusPIfOEQS8=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=Juqnl1DnrrkSu2u3WKhEBBvDBmumT05/rta/irjdmjBMBdGIpp5hmIUZp+UdG+Q30SwxZiAGSEqrd9fzT7kDD4J/1pD/QnvHyyaDgK8fBKtxfi4UtfE4+hVPEFgkXaWtIgrE18BphnmqEhfgrRVoYzTrQrX4yYydlJlnrMB2uVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=YLwG9uu4; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="YLwG9uu4" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 2E5871A2281; Wed, 17 Dec 2025 14:25:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 030396072F; Wed, 17 Dec 2025 14:25:49 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 92D3D102F0AD6; Wed, 17 Dec 2025 15:25:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765981543; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=zHGq9IXZnBW7eRUrSpb4u2mpy3tMbvnCqqPzrqz3jkY=; b=YLwG9uu4miJcCiS4PauUoFGBmSt4Mu4Of8VQF1/watYpRV/stxgihcWzmBzdtEOqrKg9Ly 8/oPQA2xCa+x6ofTLP1MFsLEq3Jmq7BU1EQZk/cxjnvqqEYw/JbAN2KBL8cb0USXNPnYCY PdFUm+IY3U+L5PZpe2g7/lv4rwmcCF8rWEgIbDglIdKzooK5tEC1D6FSwxw7ybGKQRRB8d SE6cn645lDh2cDY7Q0mGW18ZQfeqQkEckS5q30CEGHA996HMzSN1copF7e1hBLEPYStFCY 1S+mdIgzNdfjxEdTd8RzpiwkgH/uoNYmdLVcz96dyNvfZDEvQB4EkzwI2nhQQQ== Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 17 Dec 2025 15:25:40 +0100 Message-Id: Subject: Re: [PATCH v2 13/20] drm/tilcdc: Remove the useless module list support Cc: "Markus Schneider-Pargmann" , "Bajjuri Praneeth" , "Louis Chauvet" , "Thomas Petazzoni" , "Miguel Gazquez" , , , , , To: "Kory Maincent (TI.com)" , "Jyri Sarha" , "Tomi Valkeinen" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Russell King" , "Bartosz Golaszewski" , "Tony Lindgren" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20251211-feature_tilcdc-v2-0-f48bac3cd33e@bootlin.com> <20251211-feature_tilcdc-v2-13-f48bac3cd33e@bootlin.com> In-Reply-To: <20251211-feature_tilcdc-v2-13-f48bac3cd33e@bootlin.com> X-Last-TLS-Session-Version: TLSv1.3 On Thu Dec 11, 2025 at 5:38 PM CET, Kory Maincent (TI.com) wrote: > The tilcdc driver previously supported a sub-module system where > external display drivers (panels, encoders) could register themselves > through tilcdc_module_init() and be automatically initialized through > a module list. This infrastructure became unused after the component > framework support and panel driver was removed. > > Signed-off-by: Kory Maincent (TI.com) [...] > @@ -562,24 +533,7 @@ static struct platform_driver tilcdc_platform_driver= =3D { > .of_match_table =3D tilcdc_of_match, > }, > }; > - > -static int __init tilcdc_drm_init(void) > -{ > - if (drm_firmware_drivers_only()) > - return -ENODEV; > - > - DBG("init"); > - return platform_driver_register(&tilcdc_platform_driver); > -} > - > -static void __exit tilcdc_drm_fini(void) > -{ > - DBG("fini"); > - platform_driver_unregister(&tilcdc_platform_driver); > -} > - > -module_init(tilcdc_drm_init); > -module_exit(tilcdc_drm_fini); > +module_platform_driver(tilcdc_platform_driver); Is this hunk related to the removal of the module list? Looks like it should be a separate patch. With that hunk removed (or kept if I'm wrong and it should stay): Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com