Re: [PATCH 25/25] ARM: pm: omap34xx: convert to generic suspend/resume support

Russell King - ARM Linux
2011-06-23T10:21:08Z

On Thu, Jun 23, 2011 at 11:06:10AM +0100, Russell King - ARM Linux wrote:
> On Wed, Jun 22, 2011 at 04:16:58PM +0100, Russell King - ARM Linux wrote:
> > + /* Now branch to the common CPU resume function */
> > + ldr r0, =cpu_resume
> > + bx r0
> >
> > + .ltorg
>
> A slight correction - firstly this code does not run from SRAM.
> Secondly, this will try to branch to the virtual address of cpu_resume
> which is not a good idea.
>
> Replace this with:
> b cpu_resume
>
> and comment out the auxillary control register write in proc-v7.S, and
> it should work on OMAP3.

Actually... writing to the ACR seems fine on OMAP3.

Santosh,

I thought you pointed out a problem with the code in proc-v7.S which meant
there was a problem executing it in non-secure mode? I can't seem to find
any problem there. Could you re-state your concern please?