linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sicelo <absicsz@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
	maemo-leste@lists.dyne.org, Felipe Balbi <balbi@kernel.org>,
	phone-devel@vger.kernel.org, Bin Liu <b-liu@ti.com>,
	Rob Herring <robh@kernel.org>,
	"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [maemo-leste] USB PHY Initialization Fails on Nokia N900 Since 5.19
Date: Tue, 11 Oct 2022 08:39:22 +0300	[thread overview]
Message-ID: <Y0UBindrJa1ptyR0@atomide.com> (raw)
In-Reply-To: <Y0PhEOl+MwlQ8HAD@tp440p.steeds.sam>

Hi,

Adding Rob and HNS to Cc too for commit cf081d009c44 ("usb: musb: Set the
DT node on the child device").

* Sicelo <absicsz@gmail.com> [221010 09:00]:
> I have tried to bisect, but due to inexperience and lack of proper
> tooling (e.g. no serial console), I have not been able to pinpoint the
> cause of the error so far. However, on linux 6.0 with cf081d009c447647
> reverted, there is a more detailed trace in dmesg - the same trace
> appeared in other kernel versions while bisecting:

To me it seems that we now somehow have a probe issue for musb depending
on how it gets probed depending on the following line:

device_set_of_node_from_dev(&musb->dev, &pdev->dev);

I think commit 239071064732 ("partially Revert "usb: musb: Set the DT node
on the child device"") fixed the issue for omap3 that still uses hwmod
by removing the device_set_of_node_from_dev(). However, it somehow broke
SoCs using ti-sysc like omap4.

My guess is commit 239071064732 will fix the issue for you?

I'm not sure what the proper fix here might be to have both working
though :)

FYI, I have a pending patch set to convert omap3 also to probe with
ti-sysc for musb, but seems like there's some other issue here that
should be fixed first.

Regards,

Tony


  reply	other threads:[~2022-10-11  5:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  9:08 USB PHY Initialization Fails on Nokia N900 Since 5.19 Sicelo
2022-10-11  5:39 ` Tony Lindgren [this message]
2022-10-11 10:44   ` [maemo-leste] " Sicelo
2022-11-11  8:36     ` Sicelo
2022-11-18  8:12       ` Tony Lindgren
2022-11-18  9:24         ` Sicelo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0UBindrJa1ptyR0@atomide.com \
    --to=tony@atomide.com \
    --cc=absicsz@gmail.com \
    --cc=b-liu@ti.com \
    --cc=balbi@kernel.org \
    --cc=hns@goldelico.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=maemo-leste@lists.dyne.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).